| Message ID | 1521121410-17103-1-git-send-email-giulio.benetti@micronovasrl.com (mailing list archive) |
|---|---|
| State | Rejected, archived |
| Headers | show |
Hi Giulio, On Thu, Mar 15, 2018 at 02:43:30PM +0100, Giulio Benetti wrote: > The A20 supports RGB888 with H/V sync from LCD0. Add a pinmux setting > for the needed pins. > > Signed-off-by: Giulio Benetti <giulio.benetti@micronovasrl.com> Like we discussed last time, we only merge this kind of patches if there's an immediate user. Maxime
Hi Maxime, Il 16/03/2018 07:47, Maxime Ripard ha scritto: > Hi Giulio, > > On Thu, Mar 15, 2018 at 02:43:30PM +0100, Giulio Benetti wrote: >> The A20 supports RGB888 with H/V sync from LCD0. Add a pinmux setting >> for the needed pins. >> >> Signed-off-by: Giulio Benetti <giulio.benetti@micronovasrl.com> > > Like we discussed last time, we only merge this kind of patches if > there's an immediate user. You're right. In few time(I hope), I'm going to send dts for Linova1-4_3 and Linova1-7, where I use those pins. I have also to send 2 patches for 2 new panels for panel-simple. So I think I have to send 2 displays' patches before. And a patchset for the 2 boards and rgb888 pins. One question: do I have to wait for panels' patches to applied and then send patchset for boards dts? Or can I send a unique patchset? Because as I understand those patches should be applied to 2 different repositories, right? Thanks in advance
On Fri, Mar 16, 2018 at 5:19 PM, Giulio Benetti <giulio.benetti@micronovasrl.com> wrote: > Hi Maxime, > > Il 16/03/2018 07:47, Maxime Ripard ha scritto: >> >> Hi Giulio, >> >> On Thu, Mar 15, 2018 at 02:43:30PM +0100, Giulio Benetti wrote: >>> >>> The A20 supports RGB888 with H/V sync from LCD0. Add a pinmux setting >>> for the needed pins. >>> >>> Signed-off-by: Giulio Benetti <giulio.benetti@micronovasrl.com> >> >> >> Like we discussed last time, we only merge this kind of patches if >> there's an immediate user. > > > You're right. > In few time(I hope), I'm going to send dts for Linova1-4_3 and Linova1-7, > where I use those pins. > I have also to send 2 patches for 2 new panels for panel-simple. > > So I think I have to send 2 displays' patches before. > And a patchset for the 2 boards and rgb888 pins. > > One question: do I have to wait for panels' patches to applied and then send > patchset for boards dts? > Or can I send a unique patchset? > Because as I understand those patches should be applied to 2 different > repositories, right? If none of them have been merged yet, it's best to send all of them as part of the same series, and to all parties involved. That way, people have the full picture of what you're trying to achieve when they review your patches. Unless your series is really big. Maintainers will pick up patches that need to go through their trees. In general you don't need to do much coordination beyond pointing out whether the patches are safe to go in independently or there are dependencies that the maintainers need to be aware of. ChenYu
Hi, Il 16/03/2018 10:39, Chen-Yu Tsai ha scritto: > On Fri, Mar 16, 2018 at 5:19 PM, Giulio Benetti > <giulio.benetti@micronovasrl.com> wrote: >> Hi Maxime, >> >> Il 16/03/2018 07:47, Maxime Ripard ha scritto: >>> >>> Hi Giulio, >>> >>> On Thu, Mar 15, 2018 at 02:43:30PM +0100, Giulio Benetti wrote: >>>> >>>> The A20 supports RGB888 with H/V sync from LCD0. Add a pinmux setting >>>> for the needed pins. >>>> >>>> Signed-off-by: Giulio Benetti <giulio.benetti@micronovasrl.com> >>> >>> >>> Like we discussed last time, we only merge this kind of patches if >>> there's an immediate user. >> >> >> You're right. >> In few time(I hope), I'm going to send dts for Linova1-4_3 and Linova1-7, >> where I use those pins. >> I have also to send 2 patches for 2 new panels for panel-simple. >> >> So I think I have to send 2 displays' patches before. >> And a patchset for the 2 boards and rgb888 pins. >> >> One question: do I have to wait for panels' patches to applied and then send >> patchset for boards dts? >> Or can I send a unique patchset? >> Because as I understand those patches should be applied to 2 different >> repositories, right? > > If none of them have been merged yet, it's best to send all of them > as part of the same series, and to all parties involved. That way, > people have the full picture of what you're trying to achieve when > they review your patches. Unless your series is really big. > > Maintainers will pick up patches that need to go through their trees. > In general you don't need to do much coordination beyond pointing out > whether the patches are safe to go in independently or there are > dependencies that the maintainers need to be aware of. Ok, now it's clear to me. I've submitted only few patches till now, so I didn't know about that. Thank you very much
diff --git a/arch/arm/boot/dts/sun7i-a20.dtsi b/arch/arm/boot/dts/sun7i-a20.dtsi index bd0cd32..d4b2d18 100644 --- a/arch/arm/boot/dts/sun7i-a20.dtsi +++ b/arch/arm/boot/dts/sun7i-a20.dtsi @@ -922,6 +922,14 @@ pins = "PI20", "PI21"; function = "uart7"; }; + + lcd0_rgb888_pins: lcd0-rgb888-pins { + pins = "PD0", "PD1", "PD2", "PD3", "PD4", "PD5", "PD6", "PD7", + "PD8", "PD9", "PD10", "PD11", "PD12", "PD13", "PD14", "PD15", + "PD16", "PD17", "PD18", "PD19", "PD20", "PD21", "PD22", "PD23", + "PD24", "PD25", "PD26", "PD27"; + function = "lcd0"; + }; }; timer@1c20c00 {
The A20 supports RGB888 with H/V sync from LCD0. Add a pinmux setting for the needed pins. Signed-off-by: Giulio Benetti <giulio.benetti@micronovasrl.com> --- arch/arm/boot/dts/sun7i-a20.dtsi | 8 ++++++++ 1 file changed, 8 insertions(+)