From patchwork Tue Mar 20 16:54:15 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Boyd X-Patchwork-Id: 10297477 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id B248F60385 for ; Tue, 20 Mar 2018 16:54:37 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id A19CA28ABE for ; Tue, 20 Mar 2018 16:54:37 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 965BB28B4C; Tue, 20 Mar 2018 16:54:37 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 12A5A28ABE for ; Tue, 20 Mar 2018 16:54:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Date:Subject:Message-ID:References: In-Reply-To:From:To:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=EeeEETtL3wOb3gTo7p8hw68pUyl4UusHpaFcimesD30=; b=gnan9U8F7x2jp8 3iqDrzjG+FZQUO0rP3QpDlXVb0rfjuZYGqO8PvHHtE4PoUEJt6q7OQ7WFutakNN6Mrne0QVHwgiEp f6nCWb8NLfE0rrWVXGDdRcVDJt1LyZ6wVhr/0g/gfB6EXDcTvkRtJxLWtk49ayIu0dCZVnrcWAh/w p9NO9/xdtSqL1dPg5r5qBI9kLEFloDlCfbV0JH0RSd3vsQ7Bqv6otqKncxrZZ1UAWhafR7G4XwEnC jR5e660latA7wX4R84ab33wFrVcA7OLWv08NdEvB1hrFgDv7n+d6kIE/VL+EId5JKlW7JiSqVx9kY Ov8088SDn4kCtf0sipIA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1eyKWs-0007M0-MI; Tue, 20 Mar 2018 16:54:30 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1eyKWp-0007Jg-2u for linux-arm-kernel@lists.infradead.org; Tue, 20 Mar 2018 16:54:28 +0000 Received: from localhost (unknown [104.132.1.75]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 073A221770; Tue, 20 Mar 2018 16:54:16 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 073A221770 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=sboyd@kernel.org MIME-Version: 1.0 To: David Lechner , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org From: Stephen Boyd In-Reply-To: <1521168778-27236-19-git-send-email-david@lechnology.com> References: <1521168778-27236-1-git-send-email-david@lechnology.com> <1521168778-27236-19-git-send-email-david@lechnology.com> Message-ID: <152156485535.183971.1627687499726447092@swboyd.mtv.corp.google.com> User-Agent: alot/0.7 Subject: Re: [PATCH v8 18/42] clk: davinci: New driver for TI DA8XX CFGCHIP clocks Date: Tue, 20 Mar 2018 09:54:15 -0700 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20180320_095427_236319_DB342B9B X-CRM114-Status: UNSURE ( 7.75 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , David Lechner , Kevin Hilman , Stephen Boyd , Michael Turquette , Sekhar Nori , linux-kernel@vger.kernel.org, Bartosz Golaszewski , Rob Herring , Adam Ford Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP Quoting David Lechner (2018-03-15 19:52:34) > + > +typedef int (*da8xx_cfgchip_init)(struct device *dev, void __iomem *base); Should be struct regmap *regmap? I've squashed this in. diff --git a/drivers/clk/davinci/da8xx-cfgchip.c b/drivers/clk/davinci/da8xx-cfgchip.c index 858d3786b27b..c971111d2601 100644 --- a/drivers/clk/davinci/da8xx-cfgchip.c +++ b/drivers/clk/davinci/da8xx-cfgchip.c @@ -736,7 +736,7 @@ static const struct platform_device_id da8xx_cfgchip_id_table[] = { { } }; -typedef int (*da8xx_cfgchip_init)(struct device *dev, void __iomem *base); +typedef int (*da8xx_cfgchip_init)(struct device *dev, struct regmap *regmap); static int da8xx_cfgchip_probe(struct platform_device *pdev) {