| Message ID | 1521800336-19266-7-git-send-email-sricharan@codeaurora.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Fri 23 Mar 03:18 PDT 2018, Sricharan R wrote: > +#include "qcom-ipq4019-ap.dk04.1.dtsi" > + > +/ { > + model = "Qualcomm Technologies, Inc. IPQ4019/AP-DK04.1-C1"; > + If this is the board and qcom-ipq4019-ap.dk04.1.dtsi is the platform file then the compatible should be here and not there. Also qcom,ipq4019 is not an awesome compatible for a board file. > + soc { > + dma@7984000 { > + status = "ok"; > + }; > + > + qpic-nand@79b0000 { > + pinctrl-0 = <&nand_pins>; > + pinctrl-names = "default"; > + status = "ok"; > + }; nand_pins defines the muxing and is defined in the other dtsi. So please move these pinctrl-* properties to the dtsi. As long as the node is disabled the pinctrl state won't be applied anyways. If there are electrical properties that needs to be specified you can override the pinctrl state in the board specific file. Regards, Bjorn
Hi Bjorn, On 3/27/2018 10:42 PM, Bjorn Andersson wrote: > On Fri 23 Mar 03:18 PDT 2018, Sricharan R wrote: >> +#include "qcom-ipq4019-ap.dk04.1.dtsi" >> + >> +/ { >> + model = "Qualcomm Technologies, Inc. IPQ4019/AP-DK04.1-C1"; >> + > > If this is the board and qcom-ipq4019-ap.dk04.1.dtsi is the platform > file then the compatible should be here and not there. Also qcom,ipq4019 > is not an awesome compatible for a board file. > ok, agree. Will correct the compatible and move it here. >> + soc { >> + dma@7984000 { >> + status = "ok"; >> + }; >> + >> + qpic-nand@79b0000 { >> + pinctrl-0 = <&nand_pins>; >> + pinctrl-names = "default"; >> + status = "ok"; >> + }; > > nand_pins defines the muxing and is defined in the other dtsi. So please > move these pinctrl-* properties to the dtsi. > > As long as the node is disabled the pinctrl state won't be applied > anyways. > > > If there are electrical properties that needs to be specified you can > override the pinctrl state in the board specific file. > ok, understood. Will follow these conventions in rest of the places as well. Regards, Sricharan
On Fri, Mar 23, 2018 at 03:48:49PM +0530, Sricharan R wrote: > Reviewed-by: Abhishek Sahu <absahu@codeaurora.org> > Signed-off-by: Sricharan R <sricharan@codeaurora.org> > --- > arch/arm/boot/dts/Makefile | 1 + > arch/arm/boot/dts/qcom-ipq4019-ap.dk04.1-c1.dts | 20 ++++++++++++++++++++ > 2 files changed, 21 insertions(+) > create mode 100644 arch/arm/boot/dts/qcom-ipq4019-ap.dk04.1-c1.dts > NAND, BAM and SPI work fine. Tested-by: Varadarajan Narayanan <varada@codeaurora.org> -Varada > diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile > index ade7a38..b6c62c6 100644 > --- a/arch/arm/boot/dts/Makefile > +++ b/arch/arm/boot/dts/Makefile > @@ -747,6 +747,7 @@ dtb-$(CONFIG_ARCH_QCOM) += \ > qcom-apq8084-ifc6540.dtb \ > qcom-apq8084-mtp.dtb \ > qcom-ipq4019-ap.dk01.1-c1.dtb \ > + qcom-ipq4019-ap.dk04.1-c1.dtb \ > qcom-ipq8064-ap148.dtb \ > qcom-msm8660-surf.dtb \ > qcom-msm8960-cdp.dtb \ > diff --git a/arch/arm/boot/dts/qcom-ipq4019-ap.dk04.1-c1.dts b/arch/arm/boot/dts/qcom-ipq4019-ap.dk04.1-c1.dts > new file mode 100644 > index 0000000..526b7f8 > --- /dev/null > +++ b/arch/arm/boot/dts/qcom-ipq4019-ap.dk04.1-c1.dts > @@ -0,0 +1,20 @@ > +// SPDX-License-Identifier: GPL-2.0 > +// Copyright (c) 2018, The Linux Foundation. All rights reserved. > + > +#include "qcom-ipq4019-ap.dk04.1.dtsi" > + > +/ { > + model = "Qualcomm Technologies, Inc. IPQ4019/AP-DK04.1-C1"; > + > + soc { > + dma@7984000 { > + status = "ok"; > + }; > + > + qpic-nand@79b0000 { > + pinctrl-0 = <&nand_pins>; > + pinctrl-names = "default"; > + status = "ok"; > + }; > + }; > +}; > -- > QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation > > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile index ade7a38..b6c62c6 100644 --- a/arch/arm/boot/dts/Makefile +++ b/arch/arm/boot/dts/Makefile @@ -747,6 +747,7 @@ dtb-$(CONFIG_ARCH_QCOM) += \ qcom-apq8084-ifc6540.dtb \ qcom-apq8084-mtp.dtb \ qcom-ipq4019-ap.dk01.1-c1.dtb \ + qcom-ipq4019-ap.dk04.1-c1.dtb \ qcom-ipq8064-ap148.dtb \ qcom-msm8660-surf.dtb \ qcom-msm8960-cdp.dtb \ diff --git a/arch/arm/boot/dts/qcom-ipq4019-ap.dk04.1-c1.dts b/arch/arm/boot/dts/qcom-ipq4019-ap.dk04.1-c1.dts new file mode 100644 index 0000000..526b7f8 --- /dev/null +++ b/arch/arm/boot/dts/qcom-ipq4019-ap.dk04.1-c1.dts @@ -0,0 +1,20 @@ +// SPDX-License-Identifier: GPL-2.0 +// Copyright (c) 2018, The Linux Foundation. All rights reserved. + +#include "qcom-ipq4019-ap.dk04.1.dtsi" + +/ { + model = "Qualcomm Technologies, Inc. IPQ4019/AP-DK04.1-C1"; + + soc { + dma@7984000 { + status = "ok"; + }; + + qpic-nand@79b0000 { + pinctrl-0 = <&nand_pins>; + pinctrl-names = "default"; + status = "ok"; + }; + }; +};