diff mbox

arm64: defconfig: add CONFIG_UNIPHIER_THERMAL and CONFIG_SNI_AVE

Message ID 1522153407-21430-1-git-send-email-hayashi.kunihiko@socionext.com (mailing list archive)
State New, archived
Headers show

Commit Message

Kunihiko Hayashi March 27, 2018, 12:23 p.m. UTC
Enable the thermal monitor driver and the AVE ethernet driver
implemented on UniPhier SoCs.

Signed-off-by: Kunihiko Hayashi <hayashi.kunihiko@socionext.com>
---
 arch/arm64/configs/defconfig | 2 ++
 1 file changed, 2 insertions(+)

Comments

Arnd Bergmann March 27, 2018, 1:32 p.m. UTC | #1
On Tue, Mar 27, 2018 at 2:23 PM, Kunihiko Hayashi
<hayashi.kunihiko@socionext.com> wrote:
> Enable the thermal monitor driver and the AVE ethernet driver
> implemented on UniPhier SoCs.
>
> Signed-off-by: Kunihiko Hayashi <hayashi.kunihiko@socionext.com>

Any reason why this is a built-in driver rather than a loadable module?

We have a mix of both today for ethernet drivers, but generally I
would count them as non-essential.

     Arnd
Kunihiko Hayashi March 29, 2018, 5:08 a.m. UTC | #2
Hello Arnd,

Sorry for late reply and thanks for applying it.

On Tue, 27 Mar 2018 15:32:34 +0200 <arnd@arndb.de> wrote:

> On Tue, Mar 27, 2018 at 2:23 PM, Kunihiko Hayashi
> <hayashi.kunihiko@socionext.com> wrote:
> > Enable the thermal monitor driver and the AVE ethernet driver
> > implemented on UniPhier SoCs.
> >
> > Signed-off-by: Kunihiko Hayashi <hayashi.kunihiko@socionext.com>
> 
> Any reason why this is a built-in driver rather than a loadable module?
> 
> We have a mix of both today for ethernet drivers, but generally I
> would count them as non-essential.

I have no big reason.
I think it's necessary when mounting fs over the network.

Thank you,

---
Best Regards,
Kunihiko Hayashi
diff mbox

Patch

diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
index 1d3b406..4a66e78 100644
--- a/arch/arm64/configs/defconfig
+++ b/arch/arm64/configs/defconfig
@@ -220,6 +220,7 @@  CONFIG_QCOM_EMAC=m
 CONFIG_RAVB=y
 CONFIG_SMC91X=y
 CONFIG_SMSC911X=y
+CONFIG_SNI_AVE=y
 CONFIG_SNI_NETSEC=y
 CONFIG_STMMAC_ETH=m
 CONFIG_MDIO_BUS_MUX_MMIOREG=y
@@ -343,6 +344,7 @@  CONFIG_RCAR_GEN3_THERMAL=y
 CONFIG_QCOM_TSENS=y
 CONFIG_ROCKCHIP_THERMAL=m
 CONFIG_TEGRA_BPMP_THERMAL=m
+CONFIG_UNIPHIER_THERMAL=y
 CONFIG_WATCHDOG=y
 CONFIG_S3C2410_WATCHDOG=y
 CONFIG_MESON_GXBB_WATCHDOG=m