From patchwork Fri Mar 30 15:58:12 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sinan Kaya X-Patchwork-Id: 10318095 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 7D7D360467 for ; Fri, 30 Mar 2018 15:59:48 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 6ACFC2A5A1 for ; Fri, 30 Mar 2018 15:59:48 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 5C71C2A5A5; Fri, 30 Mar 2018 15:59:48 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id CFDD52A5A1 for ; Fri, 30 Mar 2018 15:59:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:To :From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=68eMkMtBQnYmYFh23qv6/4xoDl8pMuZBCaAKH3R7FVk=; b=Z3jH1qiJrwtatg 8vRP/pnQdvNxF3mIn9g3AFpAsUmqP7ES34cpbiraLRaS2SukqwIuj/NwPe4wWaszZBwnay6Uep6LL cuGW/Fsi9gmitf6Rm8jkRmvsWVfAJiyXyi/LdTlpc34UJqwVAeUPNjl21//SqSaHh/GglduqojU7i Xg7lXYQkH5GO9AzO1tRa+vmdh0GZnaIggzGhPCpXx9iuspj3c44/d9ju1Xb8xoXZFWL+bbhhamhou YIoFNAJvNVAODLOD6tR1LgPVelbDnB0XH5ahnWGLDAD+yzmBVZ3tM1g8lJwUs3wArLum5OJFZjBsk HRPOaPNBblySBgGknuDg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1f1wRI-0001HI-6Q; Fri, 30 Mar 2018 15:59:40 +0000 Received: from smtp.codeaurora.org ([198.145.29.96]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1f1wQA-0000yU-8j for linux-arm-kernel@lists.infradead.org; Fri, 30 Mar 2018 15:58:31 +0000 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id 6E9D160C55; Fri, 30 Mar 2018 15:58:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1522425499; bh=9P3nmIOtsheOIvw61tn3P+ezfFe0jYnK4uggoR11Q5o=; h=From:To:Cc:Subject:Date:From; b=CjJOM5X2Mzibt33NQ481IVBnskJsV1ySdFZHKps1JS+hv/t86hoU74q21p2gpg6Pm nFIPP7mO8poB9Xg2ErBuPb/roG7Jjt9I60ej//njpQSMttGlFtzKlOYqpRlxVX+n+y KB4Yj6kf/p0atkBeEzAAvGOGfFo8D/I+mxnR6GM4= Received: from drakthul.qualcomm.com (global_nat1_iad_fw.qualcomm.com [129.46.232.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: okaya@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id 1566060588; Fri, 30 Mar 2018 15:58:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1522425498; bh=9P3nmIOtsheOIvw61tn3P+ezfFe0jYnK4uggoR11Q5o=; h=From:To:Cc:Subject:Date:From; b=C6Dri34gKNggOrohnocdHIE5EDBGg8b2OhKMueJiKkY9n5VT2IwuaTriNxR0dKqmc ClxsId7bJHiVcRUqsdhUx0lv0aRjbriRrKDq3NaK+8dDU/WUjwMGpyyWPwqRk3bsU4 6HzgNpz7ZCkHBG/8UUHoIcGMxsbgp/sAns8ioeFA= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 1566060588 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=okaya@codeaurora.org From: Sinan Kaya To: arnd@arndb.de, timur@codeaurora.org, sulrich@codeaurora.org Subject: [PATCH v2 1/2] io: prevent compiler reordering on the default writeX() implementation Date: Fri, 30 Mar 2018 11:58:12 -0400 Message-Id: <1522425494-2916-1-git-send-email-okaya@codeaurora.org> X-Mailer: git-send-email 2.7.4 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20180330_085830_331741_64ABFB3D X-CRM114-Status: UNSURE ( 9.46 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Sinan Kaya , linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-arch@vger.kernel.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP The default implementation of mapping writeX() to __raw_writeX() is wrong. writeX() has stronger ordering semantics. Compiler is allowed to reorder __raw_writeX(). In the abscence of a write barrier or when using a strongly ordered architecture, writeX() should at least have a compiler barrier in it to prevent commpiler from clobbering the execution order. Signed-off-by: Sinan Kaya --- include/asm-generic/io.h | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/include/asm-generic/io.h b/include/asm-generic/io.h index b4531e3..e8c2078 100644 --- a/include/asm-generic/io.h +++ b/include/asm-generic/io.h @@ -144,6 +144,7 @@ static inline u64 readq(const volatile void __iomem *addr) #define writeb writeb static inline void writeb(u8 value, volatile void __iomem *addr) { + barrier(); __raw_writeb(value, addr); } #endif @@ -152,6 +153,7 @@ static inline void writeb(u8 value, volatile void __iomem *addr) #define writew writew static inline void writew(u16 value, volatile void __iomem *addr) { + barrier(); __raw_writew(cpu_to_le16(value), addr); } #endif @@ -160,6 +162,7 @@ static inline void writew(u16 value, volatile void __iomem *addr) #define writel writel static inline void writel(u32 value, volatile void __iomem *addr) { + barrier(); __raw_writel(__cpu_to_le32(value), addr); } #endif @@ -169,6 +172,7 @@ static inline void writel(u32 value, volatile void __iomem *addr) #define writeq writeq static inline void writeq(u64 value, volatile void __iomem *addr) { + barrier(); __raw_writeq(__cpu_to_le64(value), addr); } #endif