From patchwork Thu Apr 5 13:09:11 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sinan Kaya X-Patchwork-Id: 10324569 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id BD5D66032A for ; Thu, 5 Apr 2018 13:12:34 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id AC327287E3 for ; Thu, 5 Apr 2018 13:12:34 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id A0A3128E2E; Thu, 5 Apr 2018 13:12:34 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 1AA79287E3 for ; Thu, 5 Apr 2018 13:12:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=GKgW9zxQ9J22lkTi3ylz+jQKPcE8zaSa9tN0+ZjNDwE=; b=E9HZOFFL7f7Ak/ VAF+VaOrR9v1Sr01+zJtO+Bw+pvo2pWUuCzXab2Hgq6iZ80R0LTPXoNz/QIqf/dSZQvy6xLTQDGec 7A5f/RqzjaJnZQmFpPuophiwafy1pVEbYfxIVsuMlrRLXYRoF/xOpYIj54pWnw31zODmmC311RmB1 G41f5uN/81keL959OzlVX3NrHvXv7ywuR3AO5KBgz7VUVjOfRexZkOf92VA4mMgr0IKUecDzgfa7o TqHt+JfDbiCo8xq7t46aYlAwdpNdDzyMe9I0Tg0U6cQNcVWosFDLMOadAhHcgKMJ9a3I13lg5herr 5+g66Xw55IFvBIynF2ww==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1f44gh-0001Ge-0f; Thu, 05 Apr 2018 13:12:23 +0000 Received: from smtp.codeaurora.org ([198.145.29.96]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1f44dt-0006hq-MF for linux-arm-kernel@lists.infradead.org; Thu, 05 Apr 2018 13:09:38 +0000 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id 0812260850; Thu, 5 Apr 2018 13:09:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1522933762; bh=+crQGMXEwwwX2bGXKvbDTgbn+xO2jSSPpWdf/VU+llQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=IVmYXhaENCSJ6VoV91ZlrmEP6RmogiBlqzdbZWabwF2pgco+3qJjQeCNWL6hNY3jt 7r4QrFa+OAERGsKP9JLJfB2/TZSR1OmIALbe9DUmwuCYgEHFAf7O1IOdlOll0+S/fq +Z5Dm7VwQ/6zytmmVk5CraDApJ2qI6B3awxb0uvA= Received: from drakthul.qualcomm.com (global_nat1_iad_fw.qualcomm.com [129.46.232.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: okaya@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id BEE746076C; Thu, 5 Apr 2018 13:09:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1522933761; bh=+crQGMXEwwwX2bGXKvbDTgbn+xO2jSSPpWdf/VU+llQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=YjEGAswfg64UiGzunC3YWaUiFyEczCACRZQNk5dseh+ipQC/N8PfrTJH1ZhqTAbdM LtUeR9CFKbupCtIEJKgD8X0CpexNQMsVvoRcc5GJNeFA8pRMJvbtOy0JzWrDQPux4g 1vUp0szXPVmtFukvofHoC1iHERaLluxjGP51eBbI= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org BEE746076C Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=okaya@codeaurora.org From: Sinan Kaya To: arnd@arndb.de, timur@codeaurora.org, sulrich@codeaurora.org Subject: [PATCH v4 3/5] io: define stronger ordering for the default writeX() implementation Date: Thu, 5 Apr 2018 09:09:11 -0400 Message-Id: <1522933753-19589-3-git-send-email-okaya@codeaurora.org> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1522933753-19589-1-git-send-email-okaya@codeaurora.org> References: <1522933753-19589-1-git-send-email-okaya@codeaurora.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20180405_060929_801882_931767F7 X-CRM114-Status: GOOD ( 10.06 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Sinan Kaya , linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-arch@vger.kernel.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP The default implementation of mapping writeX() to __raw_writeX() is wrong. writeX() has stronger ordering semantics. Compiler is allowed to reorder memory writes against __raw_writeX(). Use the previously defined __io_aw() and __io_bw() macros to harden code generation according to architecture support. Signed-off-by: Sinan Kaya --- include/asm-generic/io.h | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/include/asm-generic/io.h b/include/asm-generic/io.h index d27e8af..964725e 100644 --- a/include/asm-generic/io.h +++ b/include/asm-generic/io.h @@ -208,7 +208,9 @@ static inline u64 readq(const volatile void __iomem *addr) #define writeb writeb static inline void writeb(u8 value, volatile void __iomem *addr) { + __io_bw(); __raw_writeb(value, addr); + __io_aw(); } #endif @@ -216,7 +218,9 @@ static inline void writeb(u8 value, volatile void __iomem *addr) #define writew writew static inline void writew(u16 value, volatile void __iomem *addr) { + __io_bw(); __raw_writew(cpu_to_le16(value), addr); + __io_aw(); } #endif @@ -224,7 +228,9 @@ static inline void writew(u16 value, volatile void __iomem *addr) #define writel writel static inline void writel(u32 value, volatile void __iomem *addr) { + __io_bw(); __raw_writel(__cpu_to_le32(value), addr); + __io_aw(); } #endif @@ -233,7 +239,9 @@ static inline void writel(u32 value, volatile void __iomem *addr) #define writeq writeq static inline void writeq(u64 value, volatile void __iomem *addr) { + __io_bw(); __raw_writeq(__cpu_to_le64(value), addr); + __io_aw(); } #endif #endif /* CONFIG_64BIT */