From patchwork Sun May 6 10:30:53 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sinan Kaya X-Patchwork-Id: 10382719 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 4ABC860318 for ; Sun, 6 May 2018 10:31:38 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 3CD8E28B88 for ; Sun, 6 May 2018 10:31:38 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 3087128C5E; Sun, 6 May 2018 10:31:38 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.9 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id F215428B88 for ; Sun, 6 May 2018 10:31:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:To :From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=cpYbZSR5Th91mTNhLb5YeVy64nSD1vORroPvf183ICg=; b=PcAdIseEl986j+ Qy/4ObVCB+HYFXo4+EnBR4nawDrPq4w+xSJO1vBrf8ILqVSt8zETFKVrH32dquA8+8sOpFAzilM7B h2eke5aCli6XAH81db5xM/lylwGAbQvebn8FMjqvGd6Ym0dVtuaaBoZqPzZzMIpVf02oZIpKdDyHb OIeti/tl+0Fuh6mPdtqp8mFORHv67giBu7i74kUaaOlHVrkvK34AJKylaxrGBGO5B0NpZwNg/4Lkz ccKjvBJg4jQFedn9gml7FHujf2DmwU5rDxcNAXN5/hCY6KziTLlvAxM/kxLUuIV1BCU8Nq2EGYDZO 9GMCvvFZcKA2MVYWlLCw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1fFGwz-0007yD-GB; Sun, 06 May 2018 10:31:29 +0000 Received: from smtp.codeaurora.org ([198.145.29.96]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1fFGwu-0007wl-DH for linux-arm-kernel@lists.infradead.org; Sun, 06 May 2018 10:31:26 +0000 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id EB8B460C55; Sun, 6 May 2018 10:31:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1525602672; bh=HQjLOiwr98SWRuB6iJ3kU6nBPEixQtJ84/+eu4jPXEE=; h=From:To:Cc:Subject:Date:From; b=P44nICoUbUojXtFOwY0GiVmwI8XTak+Tnn8aD4EFTn5VeOSlIpQFVtM6lvCXTPlb5 6kClJAB6GconfwdKinJ7BvtgKDZ7NoFpEdQ1KXlQM8nye3Cg2KMIIXQ6Vk2MyhqU3x bmjCu8o5R6H4+LwOv7RBXZS3V4NTVHRNPBwCEzmw= Received: from drakthul.qualcomm.com (global_nat1_iad_fw.qualcomm.com [129.46.232.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: okaya@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id BC556601A8; Sun, 6 May 2018 10:31:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1525602672; bh=HQjLOiwr98SWRuB6iJ3kU6nBPEixQtJ84/+eu4jPXEE=; h=From:To:Cc:Subject:Date:From; b=P44nICoUbUojXtFOwY0GiVmwI8XTak+Tnn8aD4EFTn5VeOSlIpQFVtM6lvCXTPlb5 6kClJAB6GconfwdKinJ7BvtgKDZ7NoFpEdQ1KXlQM8nye3Cg2KMIIXQ6Vk2MyhqU3x bmjCu8o5R6H4+LwOv7RBXZS3V4NTVHRNPBwCEzmw= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org BC556601A8 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=okaya@codeaurora.org From: Sinan Kaya To: linux-pci@vger.kernel.org, timur@codeaurora.org, sulrich@codeaurora.org Subject: [PATCH] PCI: pciehp: Add quirk for QDF2400 Command Completed erratum Date: Sun, 6 May 2018 06:30:53 -0400 Message-Id: <1525602662-1873-1-git-send-email-okaya@codeaurora.org> X-Mailer: git-send-email 2.7.4 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20180506_033124_484405_65F1AA1F X-CRM114-Status: GOOD ( 11.34 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Keith Busch , Kees Cook , linux-arm-msm@vger.kernel.org, open list , stable@vger.kernel.org, Sinan Kaya , Lukas Wunner , Greg Kroah-Hartman , Bjorn Helgaas , Mika Westerberg , Markus Elfring , linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP The QDF2400 controller does not set the Command Completed bit unless writes to the Slot Command register change "Control" bits. Command Completed is never set for writes that only change software notification "Enable" bits. This results in timeouts like this: pciehp 0000:00:00.0:pcie004: Timeout on hotplug command 0x1038 Cc: stable@vger.kernel.org Signed-off-by: Sinan Kaya Reviewed-by: Mika Westerberg --- drivers/pci/hotplug/pciehp_hpc.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/drivers/pci/hotplug/pciehp_hpc.c b/drivers/pci/hotplug/pciehp_hpc.c index e70eba5..974a8f1 100644 --- a/drivers/pci/hotplug/pciehp_hpc.c +++ b/drivers/pci/hotplug/pciehp_hpc.c @@ -914,3 +914,9 @@ static void quirk_cmd_compl(struct pci_dev *pdev) } DECLARE_PCI_FIXUP_CLASS_EARLY(PCI_VENDOR_ID_INTEL, PCI_ANY_ID, PCI_CLASS_BRIDGE_PCI, 8, quirk_cmd_compl); + +DECLARE_PCI_FIXUP_CLASS_EARLY(0x17cb, 0x400, + PCI_CLASS_BRIDGE_PCI, 8, quirk_cmd_compl); + +DECLARE_PCI_FIXUP_CLASS_EARLY(0x17cb, 0x401, + PCI_CLASS_BRIDGE_PCI, 8, quirk_cmd_compl);