From patchwork Mon Jun 25 17:05:46 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andy Gross X-Patchwork-Id: 10487021 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 854066023A for ; Mon, 25 Jun 2018 17:15:48 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 70B0A2858E for ; Mon, 25 Jun 2018 17:15:48 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 6548928591; Mon, 25 Jun 2018 17:15:48 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.9 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 1B57E2858E for ; Mon, 25 Jun 2018 17:15:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To: References:List-Owner; bh=ief0KJPyw9Rc7+UJMH50/tSJYyVuh7DAxfrPewcZKII=; b=QQu 9iyB84HcgAA76mNuQJt+dJGJbrq7bySEgv5GGRzG8zdJLjN1rqcvXCMV38LWqIm7+Qee77vBqWkgR H5WY0oKiAcElJ4RnlAzws0j+wCFCSNyF5uZG2AZzNtIrj2IiGD2UmHCPLMseIU6Vrg7UHoGpFvbvb bfTTPvRtC6y9fHN+YcKKZYaiRdhJX4aIbc+KBoLlJjbFE77Wg6fhJ1tDqipIABxvt+ga/fTWIMqFk 8QaDXcQg/W7Mpw0PRSSmib8b+86L8hrpoesfu1Sb55NdRJ4T5VrWMlhjABqVnFP+6b4o8eAr8dxZQ 5NwRHIOdCSOn2x2GsNF1MLsQE5vi1vg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1fXV5S-0005Fd-6G; Mon, 25 Jun 2018 17:15:34 +0000 Received: from mail-oi0-x243.google.com ([2607:f8b0:4003:c06::243]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1fXUwO-0006l0-TM for linux-arm-kernel@lists.infradead.org; Mon, 25 Jun 2018 17:07:03 +0000 Received: by mail-oi0-x243.google.com with SMTP id 18-v6so3691891oiq.6 for ; Mon, 25 Jun 2018 10:06:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id; bh=vS/Rkz1ezzwRYGtrUcXOFOjNKWKGX/LOIhUbBcIy8+8=; b=CVLGxjuucFstKOluLBUxaFh3LeGlKWpheoF7AR9yutlieIBI33iBrKil03Z4JamNuV 0UdumWkoESoKpTAr0fYSwYKEJWN3yZklAX7bB0RxocPzPCWfN1MnEX+199KLyCj3MppQ ENfnJLuAw+hW4IiOmob2DxlsxPOjQ0Z6xtjRU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=vS/Rkz1ezzwRYGtrUcXOFOjNKWKGX/LOIhUbBcIy8+8=; b=KLrboQftfWAmUcLwGcoHxfmp0NJV+GF29nO6FSmjqIJ0ZY8nOGH4Yw2TNHo6W/iXTa y/MhgDSvy1QEwX13PGMIolXrcdEet7xyG+iF3JQANLLCeRlVk6A/PXyKzhqa/52FzKMZ cCtpSdAIRDSNZ3t7JFAl6SmHzmw/T6xNWeuFde1IBRi15b7NnI2FiOt7q+RHS7TYMn1c MZaza89FXkZL8VZOaylNHXNK95lMfIM8hAf0RDVjaPmk/WUDw9myhj4D7SwXRAzxRoO7 FzTiuqUKcPnKl9CEDDQrwJT4TBZMhbNPSVdIQcF/aIxlFME5jtJMpORCAISVexcdo/0l yrYg== X-Gm-Message-State: APt69E1d9qVH3LNg0LnuRIzpFmjg/ZMwf2uVj7UAqueZCFoJYT1zbHx+ Rb52lFjQHMHOkFi5VDt1LmE1Bw== X-Google-Smtp-Source: ADUXVKLvANAmIp7OxYcC++rFcq7UHAodMMWsufyUq/lj4aU+y1EYvfkg8t8I0R2MiVJYNGEd/KERdQ== X-Received: by 2002:aca:dd83:: with SMTP id u125-v6mr7692575oig.39.1529946360930; Mon, 25 Jun 2018 10:06:00 -0700 (PDT) Received: from localhost ([2600:1700:141:4960:88f5:ab30:e569:4ad6]) by smtp.gmail.com with ESMTPSA id t204-v6sm8333778oig.24.2018.06.25.10.05.59 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 25 Jun 2018 10:05:59 -0700 (PDT) From: Andy Gross To: linux-arm-msm@vger.kernel.org Subject: [PATCH 1/2] soc: qcom: cmd-db: Fix incorrect errno checks Date: Mon, 25 Jun 2018 12:05:46 -0500 Message-Id: <1529946347-12740-1-git-send-email-andy.gross@linaro.org> X-Mailer: git-send-email 2.7.4 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20180625_100612_950498_FB48ABBB X-CRM114-Status: GOOD ( 12.51 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Arnd Bergmann , Stephen Boyd , Bjorn Andersson , mahesh sivasubramanian , Andy Gross , Linus Torvalds , linux-arm-kernel@lists.infradead.org MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP This patch fixes a couple of checks for errno that should have been checking for ret < 0. Signed-off-by: Andy Gross Reviewed-by: Bjorn Andersson --- drivers/soc/qcom/cmd-db.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/soc/qcom/cmd-db.c b/drivers/soc/qcom/cmd-db.c index a6f6462..deb2b90 100644 --- a/drivers/soc/qcom/cmd-db.c +++ b/drivers/soc/qcom/cmd-db.c @@ -121,7 +121,7 @@ rsc_offset(struct rsc_hdr *hdr, struct entry_header *ent) /** * cmd_db_ready - Indicates if command DB is available * - * Return: 0 on success, errno otherwise + * Return: 0 on success, -errno otherwise */ int cmd_db_ready(void) { @@ -143,7 +143,7 @@ static int cmd_db_get_header(const char *id, struct entry_header *eh, u8 query[8]; ret = cmd_db_ready(); - if (ret) + if (ret < 0) return ret; if (!eh || !rh) @@ -202,7 +202,7 @@ EXPORT_SYMBOL(cmd_db_read_addr); * @data: Data buffer to copy returned aux data to. Returns size on NULL * @len: Caller provides size of data buffer passed in. * - * Return: size of data on success, errno otherwise + * Return: size of data on success, -errno otherwise */ int cmd_db_read_aux_data(const char *id, u8 *data, size_t len) { @@ -215,7 +215,7 @@ int cmd_db_read_aux_data(const char *id, u8 *data, size_t len) return -EINVAL; ret = cmd_db_get_header(id, &ent, &rsc_hdr); - if (ret) + if (ret < 0) return ret; ent_len = le16_to_cpu(ent.len);