From patchwork Mon Jun 25 17:05:47 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Andy Gross X-Patchwork-Id: 10487023 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 03D736038C for ; Mon, 25 Jun 2018 17:17:36 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id E1F5A2858F for ; Mon, 25 Jun 2018 17:17:35 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id D67DA2858E; Mon, 25 Jun 2018 17:17:35 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.9 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 54A862858E for ; Mon, 25 Jun 2018 17:17:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=9jWXUrZ+FT7BzF7f4SV/OaOZHb7LuuPyTyTJSpCjiKI=; b=WqfkFWncR+WrP5 MfzoG6vXaAqLNklBH5RCTBALLEYcEES/s8HeL5CYxXV1Pdp29hBVMvYMJEFFyr9gFv95f9Kgk27t3 +fRIxcLB8Zo01eLxH0F7Z7xHKSTnENCX7A3IcTEG1noyrPVjKOex7UhN8HUg+XVUjUYBjmUO1WeQC nABycC4Sr1z/47VIDwLp7sa8RwiaVMeeXRE3EQ6uz+yj4oqTd8uDw6dRyjY3rcyGt50REkBrK9wq1 u+c1ZZngtTCaxdI1Qf8uPGA8tDRDzEL0NGwsElSpVOuZv+2XAa+2G6Ro+Q7y0uCmmSpI6PkCkaozF dxQltjY7nntV6pQteWWQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1fXV7G-0006xF-FP; Mon, 25 Jun 2018 17:17:26 +0000 Received: from mail-ot0-x241.google.com ([2607:f8b0:4003:c0f::241]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1fXUwV-0006np-MN for linux-arm-kernel@lists.infradead.org; Mon, 25 Jun 2018 17:07:11 +0000 Received: by mail-ot0-x241.google.com with SMTP id w13-v6so15839536ote.11 for ; Mon, 25 Jun 2018 10:06:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=+ol+wIMDDYu7e+V4lYapWAJa5L3g/Qmnqf/iFLZIOIM=; b=ioKp+NLawQukvJIRNPAFBoJRd045XkfC82U9I9NPgY78EtRO0TnWXVAVNOxuYbpggL 9RIuU2rSg4xFCi2tYdaxMq/qjhGbp2i1C1aY1dGn8dtXd7wSrCm/kQ/NmWCUpqe4GkRg kunAfaIOK8Xnu5KQzqct4kWuvo9bXczOVSkmQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=+ol+wIMDDYu7e+V4lYapWAJa5L3g/Qmnqf/iFLZIOIM=; b=HyMZUboGNqgA6TNQpE+h+lfGaDL1rDi/GmYR66h9pLqewoZsciAULzy1leyb8s12t0 5j/FsN8mK+LKNhux/Xkp5hIwlv/r5w9z6WUpVhtECTXOJaR0TRNl6YMzr7tF/YkIyuSH LArdEKrwx50lVGWIbEUGVrEulaOjLv1OrTzyG9PXwmpxcCoGZu7Ayc0pu/4eyE1x+0yl 3ofDZP9VI99vRhTqCYmPOF2/dNzszoZsAM1wmZELQCoYpfhTE0pIG5MK57WpgGBuEyi4 4vmbEJanuk4xLPn+9JTWQdqtolcrrBOtRJ6cha9NtA9arjNAJNqXRawRdgnuaHDoHwZ3 3BDA== X-Gm-Message-State: APt69E35Dljo37TvSxCDkC6RrgrBHRtL/Tw2najwFLgknNs9xqtkmRZn dL0+8b2HgJZy66ZUyDkaF+em3w== X-Google-Smtp-Source: ADUXVKIZ/v6aebewQ/Wx/WayLKpdnjlPoTqxaFW7DrtGcS6QfeHlmf6ANf1Bfqn0uIFogk3x2uBTyw== X-Received: by 2002:a9d:241:: with SMTP id 59-v6mr8543216otb.71.1529946368565; Mon, 25 Jun 2018 10:06:08 -0700 (PDT) Received: from localhost ([2600:1700:141:4960:88f5:ab30:e569:4ad6]) by smtp.gmail.com with ESMTPSA id t4-v6sm16740553otd.40.2018.06.25.10.06.07 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 25 Jun 2018 10:06:08 -0700 (PDT) From: Andy Gross To: linux-arm-msm@vger.kernel.org Subject: [PATCH 2/2] soc: qcom: cmd-db: Fix compiler warnings Date: Mon, 25 Jun 2018 12:05:47 -0500 Message-Id: <1529946347-12740-2-git-send-email-andy.gross@linaro.org> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1529946347-12740-1-git-send-email-andy.gross@linaro.org> References: <1529946347-12740-1-git-send-email-andy.gross@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20180625_100619_744736_F5011568 X-CRM114-Status: GOOD ( 10.84 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Arnd Bergmann , Stephen Boyd , Bjorn Andersson , mahesh sivasubramanian , Andy Gross , Linus Torvalds , linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP This patch adds initialization of the entry_header structs to avoid compiler warnings like the following: CC drivers/soc/qcom/cmd-db.o drivers/soc/qcom/cmd-db.c: In function ‘cmd_db_read_addr’: drivers/soc/qcom/cmd-db.c:194:21: warning: ‘ent.addr’ may be used uninitialized in this function [-Wmaybe-uninitialized] return ret < 0 ? 0 : le32_to_cpu(ent.addr); drivers/soc/qcom/cmd-db.c: In function ‘cmd_db_read_aux_data_len’: drivers/soc/qcom/cmd-db.c:247:38: warning: ‘ent.len’ may be used uninitialized in this function [-Wmaybe-uninitialized] return ret < 0 ? 0 : le16_to_cpu(ent.len); ^ drivers/soc/qcom/cmd-db.c: In function ‘cmd_db_read_slave_id’: drivers/soc/qcom/cmd-db.c:269:7: warning: ‘ent.addr’ may be used uninitialized in this function [-Wmaybe-uninitialized] addr = le32_to_cpu(ent.addr); drivers/soc/qcom/cmd-db.c: In function ‘cmd_db_read_aux_data’: drivers/soc/qcom/cmd-db.c:221:10: warning: ‘ent.len’ may be used uninitialized in this function [-Wmaybe-uninitialized] ent_len = le16_to_cpu(ent.len); drivers/soc/qcom/cmd-db.c:226:15: warning: ‘*((void *)&rsc_hdr+4)’ may be used uninitialized in this function [-Wmaybe-uninitialized] memcpy(data, rsc_offset(&rsc_hdr, &ent), len); ^~~~~~~~~~~~~~~~~~~~~~~~~~ drivers/soc/qcom/cmd-db.c:226:15: warning: ‘*((void *)&ent+22)’ may be used uninitialized in this function [-Wmaybe-uninitialized] Signed-off-by: Andy Gross --- drivers/soc/qcom/cmd-db.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/soc/qcom/cmd-db.c b/drivers/soc/qcom/cmd-db.c index deb2b90..1007e79 100644 --- a/drivers/soc/qcom/cmd-db.c +++ b/drivers/soc/qcom/cmd-db.c @@ -186,7 +186,7 @@ static int cmd_db_get_header(const char *id, struct entry_header *eh, u32 cmd_db_read_addr(const char *id) { int ret; - struct entry_header ent; + struct entry_header ent = {}; struct rsc_hdr rsc_hdr; ret = cmd_db_get_header(id, &ent, &rsc_hdr); @@ -207,7 +207,7 @@ EXPORT_SYMBOL(cmd_db_read_addr); int cmd_db_read_aux_data(const char *id, u8 *data, size_t len) { int ret; - struct entry_header ent; + struct entry_header ent = {}; struct rsc_hdr rsc_hdr; u16 ent_len; @@ -239,7 +239,7 @@ EXPORT_SYMBOL(cmd_db_read_aux_data); size_t cmd_db_read_aux_data_len(const char *id) { int ret; - struct entry_header ent; + struct entry_header ent = {}; struct rsc_hdr rsc_hdr; ret = cmd_db_get_header(id, &ent, &rsc_hdr); @@ -258,7 +258,7 @@ EXPORT_SYMBOL(cmd_db_read_aux_data_len); enum cmd_db_hw_type cmd_db_read_slave_id(const char *id) { int ret; - struct entry_header ent; + struct entry_header ent = {}; struct rsc_hdr rsc_hdr; u32 addr;