| Message ID | 1532630184-29450-2-git-send-email-arun.parameswaran@broadcom.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Add clock config and pm support to bcm iProc mdio mux | expand |
On Thu, Jul 26, 2018 at 11:36:18AM -0700, Arun Parameswaran wrote: > Modify the base address passed to the Broadcom iProc MDIO mux driver > to point to the start of the block's register address space. > > Fixes: ce8d5dbfd64f ("Add DT binding doc for Broadcom MDIO bus multiplexer") Hi Arun Fixes generally means something explodes, throws an Opps, userspace does the wrong thing. Documentation/process/stable-kernel-rules.rst says: - It must fix a real bug that bothers people (not a, "This could be a problem..." type thing). Please explain how this is a real problem and what people it bothers. I also don't see any attempt to keep backwards compatibility with older device tree blobs. Is it intentional you will break such old blobs? Thanks Andrew > Signed-off-by: Arun Parameswaran <arun.parameswaran@broadcom.com> > --- > Documentation/devicetree/bindings/net/brcm,mdio-mux-iproc.txt | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/net/brcm,mdio-mux-iproc.txt b/Documentation/devicetree/bindings/net/brcm,mdio-mux-iproc.txt > index dfe287a..dc8aa68 100644 > --- a/Documentation/devicetree/bindings/net/brcm,mdio-mux-iproc.txt > +++ b/Documentation/devicetree/bindings/net/brcm,mdio-mux-iproc.txt > @@ -18,9 +18,9 @@ at- Documentation/devicetree/bindings/net/mdio-mux.txt > > > for example: > - mdio_mux_iproc: mdio-mux@6602023c { > + mdio_mux_iproc: mdio-mux@66020000 { > compatible = "brcm,mdio-mux-iproc"; > - reg = <0x6602023c 0x14>; > + reg = <0x66020000 0x250>; > #address-cells = <1>; > #size-cells = <0>; > > -- > 1.9.1 >
Hi Andrew On 18-07-26 12:01 PM, Andrew Lunn wrote: > On Thu, Jul 26, 2018 at 11:36:18AM -0700, Arun Parameswaran wrote: >> Modify the base address passed to the Broadcom iProc MDIO mux driver >> to point to the start of the block's register address space. >> >> Fixes: ce8d5dbfd64f ("Add DT binding doc for Broadcom MDIO bus multiplexer") > > Hi Arun > > Fixes generally means something explodes, throws an Opps, userspace > does the wrong thing. Documentation/process/stable-kernel-rules.rst > says: > > - It must fix a real bug that bothers people (not a, "This could be a > problem..." type thing). > > Please explain how this is a real problem and what people it bothers. > It is only relevant when we need to modify the registers which are not currently accessible. I will remove the 'fixes' and use the 'net-next' repo for the change set. > I also don't see any attempt to keep backwards compatibility with > older device tree blobs. Is it intentional you will break such old > blobs? > I will modify the patch to keep backward compatibility like you suggested in the other patch. Thanks Arun > Thanks > Andrew > > >> Signed-off-by: Arun Parameswaran <arun.parameswaran@broadcom.com> >> --- >> Documentation/devicetree/bindings/net/brcm,mdio-mux-iproc.txt | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/Documentation/devicetree/bindings/net/brcm,mdio-mux-iproc.txt b/Documentation/devicetree/bindings/net/brcm,mdio-mux-iproc.txt >> index dfe287a..dc8aa68 100644 >> --- a/Documentation/devicetree/bindings/net/brcm,mdio-mux-iproc.txt >> +++ b/Documentation/devicetree/bindings/net/brcm,mdio-mux-iproc.txt >> @@ -18,9 +18,9 @@ at- Documentation/devicetree/bindings/net/mdio-mux.txt >> >> >> for example: >> - mdio_mux_iproc: mdio-mux@6602023c { >> + mdio_mux_iproc: mdio-mux@66020000 { >> compatible = "brcm,mdio-mux-iproc"; >> - reg = <0x6602023c 0x14>; >> + reg = <0x66020000 0x250>; >> #address-cells = <1>; >> #size-cells = <0>; >> >> -- >> 1.9.1 >>
diff --git a/Documentation/devicetree/bindings/net/brcm,mdio-mux-iproc.txt b/Documentation/devicetree/bindings/net/brcm,mdio-mux-iproc.txt index dfe287a..dc8aa68 100644 --- a/Documentation/devicetree/bindings/net/brcm,mdio-mux-iproc.txt +++ b/Documentation/devicetree/bindings/net/brcm,mdio-mux-iproc.txt @@ -18,9 +18,9 @@ at- Documentation/devicetree/bindings/net/mdio-mux.txt for example: - mdio_mux_iproc: mdio-mux@6602023c { + mdio_mux_iproc: mdio-mux@66020000 { compatible = "brcm,mdio-mux-iproc"; - reg = <0x6602023c 0x14>; + reg = <0x66020000 0x250>; #address-cells = <1>; #size-cells = <0>;
Modify the base address passed to the Broadcom iProc MDIO mux driver to point to the start of the block's register address space. Fixes: ce8d5dbfd64f ("Add DT binding doc for Broadcom MDIO bus multiplexer") Signed-off-by: Arun Parameswaran <arun.parameswaran@broadcom.com> --- Documentation/devicetree/bindings/net/brcm,mdio-mux-iproc.txt | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)