From patchwork Wed Oct 31 14:43:08 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Aisheng Dong X-Patchwork-Id: 10662817 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id BF17D13A4 for ; Wed, 31 Oct 2018 14:44:08 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id ABABF294EA for ; Wed, 31 Oct 2018 14:44:08 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 9E830295EB; Wed, 31 Oct 2018 14:44:08 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.9 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 6FF92294EA for ; Wed, 31 Oct 2018 14:44:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:In-Reply-To:References: Message-ID:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Kvaf5PbwDHu0BXjBttckOoP1agFi/wzLIghyi9BONUQ=; b=WZeZA19Za68fv0 xRolwMxIq81ZpqRdFuRPPSnYkixSdivGtacyMynmCEroMxzpHDf3RqqqsULxwOBSsb6sm4EczTsot ijzCBO9OCoEB2Mn33EB66fGTwwOw7iYzEL8TWPuGUZTca8Hd1c2luysEdxGdrznjXk6ZL+3inPCyA h3gnUNCexSwk3t+knR5Q06S6+ObjSyIx0OJ9FSdDXyfr2kyQCXdnC4zKQPrtfb4Nagg1sszN/B02r wQnLoHZCESxavZ841nDoQ4DVVeO/OKZObw/ZxvWCqEOtlo1Em2G2AsENWxvzy9L57Ce/KI/N3A3xR o4CDDzMeVnIolSrbHdXg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1gHriz-0007A7-DZ; Wed, 31 Oct 2018 14:44:01 +0000 Received: from mail-eopbgr50075.outbound.protection.outlook.com ([40.107.5.75] helo=EUR03-VE1-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1gHriO-000664-4Z for linux-arm-kernel@lists.infradead.org; Wed, 31 Oct 2018 14:43:26 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ZN4sieQCwosGKPOMQODlhKuvpSjWE7y6mo10PtMjMYM=; b=gDKyrMnd+JhPED/XH1KkT4Mt5dCBgbTI/5MWym93biMOt+NIRWmi8DZsTDjH8/w/PMhIrll9luv+CkDOXzsTsr+PsC73NscSFfWbnbW5OEo3UJFP969K3Wbxb9PkX/qDWFTCU4AGb1OPwM/9Q2AnK+vTZVrJ6T9ydUg0eQnquSc= Received: from AM0PR04MB4211.eurprd04.prod.outlook.com (52.134.126.21) by AM0PR04MB4052.eurprd04.prod.outlook.com (52.134.125.22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1294.21; Wed, 31 Oct 2018 14:43:09 +0000 Received: from AM0PR04MB4211.eurprd04.prod.outlook.com ([fe80::797a:f972:9281:6d10]) by AM0PR04MB4211.eurprd04.prod.outlook.com ([fe80::797a:f972:9281:6d10%2]) with mapi id 15.20.1273.028; Wed, 31 Oct 2018 14:43:09 +0000 From: "A.s. Dong" To: "linux-arm-kernel@lists.infradead.org" Subject: [PATCH V3 04/10] gpio: vf610: add optional clock support Thread-Topic: [PATCH V3 04/10] gpio: vf610: add optional clock support Thread-Index: AQHUcSgKotZRX/Ai70yIZ2JJm3n/0A== Date: Wed, 31 Oct 2018 14:43:08 +0000 Message-ID: <1540996688-23681-5-git-send-email-aisheng.dong@nxp.com> References: <1540996688-23681-1-git-send-email-aisheng.dong@nxp.com> In-Reply-To: <1540996688-23681-1-git-send-email-aisheng.dong@nxp.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: git-send-email 2.7.4 x-clientproxiedby: HK0PR03CA0016.apcprd03.prod.outlook.com (2603:1096:203:2e::28) To AM0PR04MB4211.eurprd04.prod.outlook.com (2603:10a6:208:66::21) authentication-results: spf=none (sender IP is ) smtp.mailfrom=aisheng.dong@nxp.com; x-ms-exchange-messagesentrepresentingtype: 1 x-originating-ip: [119.31.174.66] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; AM0PR04MB4052; 6:v9vQ8D9rZXC8l+cx6/2FdmbxXVmTE0uYUGyc1Fi/Kst+fLyw74QFQWI3H1D+ZRXaULkbgZ4U8gxXUdHLUqzIamiAk6yHOKuiPy4ylD4xeBKbVIfC1woHx/N+2zPA2ozD7baEeSWNMtHoA5g78KfPaMtuaePHe953urc+netPGQUZq4whJ1VygQZ6oC/+/PILwLaeBX3xsj6/QMevb08fE9ouFt6LjnhrirkvIBtv5b5FDzyz1ryr7AzFtZgJqvbmK49UGWQjagl+UWZ5SD9yuzGx5nZvTp5lgwMiwwjzZnywQx4dnujttsl8YE1a+QFpG7h+gddJCHnzJjk7eBiGcqce95U9FcS8uev1je1wA+Vn9/lYbPO787lB2ah75lqi1COhfLQK+VusfNCa+y3oWWxBUVT3SqgnIqFBhS+iXH9dCMaJcpnJVuRrLwcaHPP+ESIbFzy49J2kLC4TEcDPtA==; 5:63bGyBupQvrYU8KnAluFWvLkYHgvQBOERX+Nd7qv7dJRzYpL5zO5X+b69YbAAMx93ZlfooXiovj5W35R3LJ1Q3dGuDpiNRDfMJEaPrwhqSZccWxpuCT7L5Bk1zL/sR6f0BkFjwlquJlhH9tP3PO5nXKJE+zQsTjnYRXMX3q06II=; 7:ufyY4W7zahAcOmzpOkhg7dpcRlSjHx7VnFva8dlIQcnzkWB/7nOB+RVxPqcoziPc45NQdi7335iTe74Nq8jQPZk0yIGrYsBM6OBqe4YkjGBcGXwFpR0tMhKo4eei34KBPkJ7WfbVPQr8ffFLQbKdhA== x-ms-office365-filtering-correlation-id: 28a41d9c-ae13-4910-2e3b-08d63f3f2cbe x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989299)(5600074)(711020)(4618075)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(2017052603328)(7153060)(7193020); SRVR:AM0PR04MB4052; x-ms-traffictypediagnostic: AM0PR04MB4052: x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(9452136761055)(185117386973197); x-ms-exchange-senderadcheck: 1 x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(93006095)(93001095)(3231382)(944501410)(52105095)(10201501046)(3002001)(6055026)(148016)(149066)(150057)(6041310)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123560045)(20161123564045)(20161123558120)(20161123562045)(201708071742011)(7699051)(76991095); SRVR:AM0PR04MB4052; BCL:0; PCL:0; RULEID:; SRVR:AM0PR04MB4052; x-forefront-prvs: 084285FC5C x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(396003)(376002)(366004)(346002)(39860400002)(136003)(189003)(199004)(11346002)(99286004)(26005)(316002)(305945005)(66066001)(2900100001)(386003)(6506007)(7736002)(102836004)(86362001)(2616005)(36756003)(476003)(71190400001)(71200400001)(446003)(6116002)(186003)(97736004)(76176011)(54906003)(52116002)(3846002)(5250100002)(486006)(2501003)(2906002)(50226002)(8936002)(106356001)(8676002)(14454004)(81156014)(81166006)(39060400002)(68736007)(6512007)(6436002)(6486002)(105586002)(6916009)(2351001)(4326008)(478600001)(53936002)(5660300001)(256004)(25786009)(5640700003); DIR:OUT; SFP:1101; SCL:1; SRVR:AM0PR04MB4052; H:AM0PR04MB4211.eurprd04.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: iCRzzdZWZ302FuBMV6RJZfDv7Vxyz7t4I6pz83xJMLYzBE/NjHh1mRxSEFF9a35Adk4D47XFoUqxI/EPj4UQCiKwmAEp7draPTVcUBMWHa4jiij/k/vt+WF2sFcx2odOAlacFj82Ae7cAXkFgxImAERaE9VPsAXJrxNBPCqULYa13KNcbhV4qoTUC6VG0E0nJ1g0u6q05leoUQLMdzcZmtmyjuUHc60Kb2laSGEDS07mHcUJ0A5Do9iCZDPaHAfuXJ+mSRIBA+5o5GADJwlFsvm6QF3HDMI6Aa6nTnSFnmgKvcsZdcO6lFMlK83MOOW3qteWiqdlB8ModlTE02y8YAqnY2UkmHyzErKBUMFIkkg= spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 28a41d9c-ae13-4910-2e3b-08d63f3f2cbe X-MS-Exchange-CrossTenant-originalarrivaltime: 31 Oct 2018 14:43:09.0007 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB4052 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20181031_074324_418356_9FB91527 X-CRM114-Status: GOOD ( 14.58 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "A.s. Dong" , "dongas86@gmail.com" , Linus Walleij , "linux@armlinux.org.uk" , Stefan Agner , "linux-gpio@vger.kernel.org" , "robh+dt@kernel.org" , dl-linux-imx , "kernel@pengutronix.de" , Fabio Estevam , "shawnguo@kernel.org" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP Some SoCs need the gpio clock to be enabled before accessing HW registers. This patch add the optional clock handling. Cc: Linus Walleij Cc: Stefan Agner Cc: Shawn Guo Cc: linux-gpio@vger.kernel.org Signed-off-by: Dong Aisheng --- v2->v3: * error checking updated according to Russell's suggestion: ptr == ERR_PTR(-EPROBE_DEFER) * clock independently checking v1->v2: * new patch --- drivers/gpio/gpio-vf610.c | 24 ++++++++++++++++++++++++ 1 file changed, 24 insertions(+) diff --git a/drivers/gpio/gpio-vf610.c b/drivers/gpio/gpio-vf610.c index d4ad6d0..02fb7d8 100644 --- a/drivers/gpio/gpio-vf610.c +++ b/drivers/gpio/gpio-vf610.c @@ -16,6 +16,7 @@ */ #include +#include #include #include #include @@ -256,6 +257,7 @@ static int vf610_gpio_probe(struct platform_device *pdev) { struct device *dev = &pdev->dev; struct device_node *np = dev->of_node; + struct clk *clk_gpio, *clk_port; struct vf610_gpio_port *port; struct resource *iores; struct gpio_chip *gc; @@ -280,6 +282,28 @@ static int vf610_gpio_probe(struct platform_device *pdev) if (port->irq < 0) return port->irq; + clk_port = devm_clk_get(&pdev->dev, "port"); + if (clk_port == ERR_PTR(-EPROBE_DEFER)) + return -EPROBE_DEFER; + + clk_gpio = devm_clk_get(&pdev->dev, "gpio"); + if (clk_gpio == ERR_PTR(-EPROBE_DEFER)) + return -EPROBE_DEFER; + + if (!IS_ERR_OR_NULL(clk_port)) { + ret = clk_prepare_enable(clk_port); + if (ret) + return ret; + } + + if (!IS_ERR_OR_NULL(clk_gpio)) { + ret = clk_prepare_enable(clk_gpio); + if (ret) { + clk_disable_unprepare(clk_port); + return ret; + } + } + gc = &port->gc; gc->of_node = np; gc->parent = dev;