| Message ID | 1541093567-29205-1-git-send-email-martin@kaiser.cx (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | ARM: dts: i.MX25: add the clocks for the EPIT blocks | expand |
Hi Martin, On 11/01/2018 07:32 PM, Martin Kaiser wrote: > The i.MX25 contains two EPIT (Enhanced Periodic Interrupt Timer) > function blocks. Add their ipg and per clocks to the device tree. > > Signed-off-by: Martin Kaiser <martin@kaiser.cx> the change is obviously correct. Reviewed-by: Vladimir Zapolskiy <vz@mleia.com> -- Best wishes, Vladimir
On Thu, Nov 01, 2018 at 06:32:47PM +0100, Martin Kaiser wrote: > The i.MX25 contains two EPIT (Enhanced Periodic Interrupt Timer) > function blocks. Add their ipg and per clocks to the device tree. > > Signed-off-by: Martin Kaiser <martin@kaiser.cx> Are these EPIT devices actually used in upstream kernel, or just somewhere else? Shawn > --- > > I tried to make this similar to gpt1 and gpt2. > > arch/arm/boot/dts/imx25.dtsi | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/arch/arm/boot/dts/imx25.dtsi b/arch/arm/boot/dts/imx25.dtsi > index b25309d26ea5..e80101847aff 100644 > --- a/arch/arm/boot/dts/imx25.dtsi > +++ b/arch/arm/boot/dts/imx25.dtsi > @@ -388,12 +388,16 @@ > epit1: timer@53f94000 { > compatible = "fsl,imx25-epit"; > reg = <0x53f94000 0x4000>; > + clocks = <&clks 83>, <&clks 43>; > + clock-names = "ipg", "per"; > interrupts = <28>; > }; > > epit2: timer@53f98000 { > compatible = "fsl,imx25-epit"; > reg = <0x53f98000 0x4000>; > + clocks = <&clks 84>, <&clks 43>; > + clock-names = "ipg", "per"; > interrupts = <27>; > }; > > -- > 2.1.4 > > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Adding Clément. On 11/04/2018 04:46 PM, Shawn Guo wrote: > On Thu, Nov 01, 2018 at 06:32:47PM +0100, Martin Kaiser wrote: >> The i.MX25 contains two EPIT (Enhanced Periodic Interrupt Timer) >> function blocks. Add their ipg and per clocks to the device tree. >> >> Signed-off-by: Martin Kaiser <martin@kaiser.cx> > > Are these EPIT devices actually used in upstream kernel, or just > somewhere else? Clément wrote a good driver, which has already passed a series of reviews, but this clocks add-on is actually missing. Clément, can you please add clock-names property and the corresponding functional change to your driver? Thank you in advance. -- Best wishes, Vladimir >> --- >> >> I tried to make this similar to gpt1 and gpt2. >> >> arch/arm/boot/dts/imx25.dtsi | 4 ++++ >> 1 file changed, 4 insertions(+) >> >> diff --git a/arch/arm/boot/dts/imx25.dtsi b/arch/arm/boot/dts/imx25.dtsi >> index b25309d26ea5..e80101847aff 100644 >> --- a/arch/arm/boot/dts/imx25.dtsi >> +++ b/arch/arm/boot/dts/imx25.dtsi >> @@ -388,12 +388,16 @@ >> epit1: timer@53f94000 { >> compatible = "fsl,imx25-epit"; >> reg = <0x53f94000 0x4000>; >> + clocks = <&clks 83>, <&clks 43>; >> + clock-names = "ipg", "per"; >> interrupts = <28>; >> }; >> >> epit2: timer@53f98000 { >> compatible = "fsl,imx25-epit"; >> reg = <0x53f98000 0x4000>; >> + clocks = <&clks 84>, <&clks 43>; >> + clock-names = "ipg", "per"; >> interrupts = <27>; >> }; >> >> -- >> 2.1.4 >> >> >> _______________________________________________ >> linux-arm-kernel mailing list >> linux-arm-kernel@lists.infradead.org >> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Hi, Thus wrote Shawn Guo (shawnguo@kernel.org): > On Thu, Nov 01, 2018 at 06:32:47PM +0100, Martin Kaiser wrote: > > The i.MX25 contains two EPIT (Enhanced Periodic Interrupt Timer) > > function blocks. Add their ipg and per clocks to the device tree. > > Signed-off-by: Martin Kaiser <martin@kaiser.cx> > Are these EPIT devices actually used in upstream kernel, or just > somewhere else? Until I saw Vladimir's mail this morning, I wasn't aware of any mainline driver that's using the EPIT devices. I found that the clocks are missing when I tried to use EPIT with a company-internal driver that's not suitable for mainline integration. Still, I think that merging this patch does no harm. If the EPIT devices are present in the DT, we should add all resources they're using. Thanks & best regards, Martin
Hi, On Mon, 5 Nov 2018 at 09:58, Vladimir Zapolskiy <vladimir_zapolskiy@mentor.com> wrote: > > Adding Clément. > > On 11/04/2018 04:46 PM, Shawn Guo wrote: > > On Thu, Nov 01, 2018 at 06:32:47PM +0100, Martin Kaiser wrote: > >> The i.MX25 contains two EPIT (Enhanced Periodic Interrupt Timer) > >> function blocks. Add their ipg and per clocks to the device tree. > >> > >> Signed-off-by: Martin Kaiser <martin@kaiser.cx> > > > > Are these EPIT devices actually used in upstream kernel, or just > > somewhere else? > > Clément wrote a good driver, which has already passed a series of reviews, > but this clocks add-on is actually missing. > > Clément, can you please add clock-names property and the corresponding > functional change to your driver? Thank you in advance. I'm converting it with the new timer-of framework, will check for adding both clocks. New patch should come this week I hope. Regards, Clement> > -- > Best wishes, > Vladimir > > >> --- > >> > >> I tried to make this similar to gpt1 and gpt2. > >> > >> arch/arm/boot/dts/imx25.dtsi | 4 ++++ > >> 1 file changed, 4 insertions(+) > >> > >> diff --git a/arch/arm/boot/dts/imx25.dtsi b/arch/arm/boot/dts/imx25.dtsi > >> index b25309d26ea5..e80101847aff 100644 > >> --- a/arch/arm/boot/dts/imx25.dtsi > >> +++ b/arch/arm/boot/dts/imx25.dtsi > >> @@ -388,12 +388,16 @@ > >> epit1: timer@53f94000 { > >> compatible = "fsl,imx25-epit"; > >> reg = <0x53f94000 0x4000>; > >> + clocks = <&clks 83>, <&clks 43>; > >> + clock-names = "ipg", "per"; > >> interrupts = <28>; > >> }; > >> > >> epit2: timer@53f98000 { > >> compatible = "fsl,imx25-epit"; > >> reg = <0x53f98000 0x4000>; > >> + clocks = <&clks 84>, <&clks 43>; > >> + clock-names = "ipg", "per"; > >> interrupts = <27>; > >> }; > >> > >> -- > >> 2.1.4 > >> > >> > >> _______________________________________________ > >> linux-arm-kernel mailing list > >> linux-arm-kernel@lists.infradead.org > >> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
On Mon, Nov 05, 2018 at 10:12:30AM +0100, Martin Kaiser wrote: > Hi, > > Thus wrote Shawn Guo (shawnguo@kernel.org): > > > On Thu, Nov 01, 2018 at 06:32:47PM +0100, Martin Kaiser wrote: > > > The i.MX25 contains two EPIT (Enhanced Periodic Interrupt Timer) > > > function blocks. Add their ipg and per clocks to the device tree. > > > > Signed-off-by: Martin Kaiser <martin@kaiser.cx> > > > Are these EPIT devices actually used in upstream kernel, or just > > somewhere else? > > Until I saw Vladimir's mail this morning, I wasn't aware of any mainline > driver that's using the EPIT devices. I found that the clocks are > missing when I tried to use EPIT with a company-internal driver that's > not suitable for mainline integration. > > Still, I think that merging this patch does no harm. If the EPIT devices > are present in the DT, we should add all resources they're using. Agreed. I will be happy to apply the patch if I can get an ACK from Clément saying this works with his driver in upstreaming. Shawn
Hi Shawn, On Tue, 13 Nov 2018 at 15:42, Shawn Guo <shawnguo@kernel.org> wrote: > > On Mon, Nov 05, 2018 at 10:12:30AM +0100, Martin Kaiser wrote: > > Hi, > > > > Thus wrote Shawn Guo (shawnguo@kernel.org): > > > > > On Thu, Nov 01, 2018 at 06:32:47PM +0100, Martin Kaiser wrote: > > > > The i.MX25 contains two EPIT (Enhanced Periodic Interrupt Timer) > > > > function blocks. Add their ipg and per clocks to the device tree. > > > > > > Signed-off-by: Martin Kaiser <martin@kaiser.cx> Acked-by: Clément Péron <peron.clem@gmail.com> > > > > > Are these EPIT devices actually used in upstream kernel, or just > > > somewhere else? > > > > Until I saw Vladimir's mail this morning, I wasn't aware of any mainline > > driver that's using the EPIT devices. I found that the clocks are > > missing when I tried to use EPIT with a company-internal driver that's > > not suitable for mainline integration. > > > > Still, I think that merging this patch does no harm. If the EPIT devices > > are present in the DT, we should add all resources they're using. > > Agreed. I will be happy to apply the patch if I can get an ACK from > Clément saying this works with his driver in upstreaming. I have paused the dev of this driver for now, but this is fine for me. Regards, Clement > > Shawn
On Thu, Nov 01, 2018 at 06:32:47PM +0100, Martin Kaiser wrote: > The i.MX25 contains two EPIT (Enhanced Periodic Interrupt Timer) > function blocks. Add their ipg and per clocks to the device tree. > > Signed-off-by: Martin Kaiser <martin@kaiser.cx> Applied, thanks.
diff --git a/arch/arm/boot/dts/imx25.dtsi b/arch/arm/boot/dts/imx25.dtsi index b25309d26ea5..e80101847aff 100644 --- a/arch/arm/boot/dts/imx25.dtsi +++ b/arch/arm/boot/dts/imx25.dtsi @@ -388,12 +388,16 @@ epit1: timer@53f94000 { compatible = "fsl,imx25-epit"; reg = <0x53f94000 0x4000>; + clocks = <&clks 83>, <&clks 43>; + clock-names = "ipg", "per"; interrupts = <28>; }; epit2: timer@53f98000 { compatible = "fsl,imx25-epit"; reg = <0x53f98000 0x4000>; + clocks = <&clks 84>, <&clks 43>; + clock-names = "ipg", "per"; interrupts = <27>; };
The i.MX25 contains two EPIT (Enhanced Periodic Interrupt Timer) function blocks. Add their ipg and per clocks to the device tree. Signed-off-by: Martin Kaiser <martin@kaiser.cx> --- I tried to make this similar to gpt1 and gpt2. arch/arm/boot/dts/imx25.dtsi | 4 ++++ 1 file changed, 4 insertions(+)