From patchwork Tue Nov 20 14:15:19 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrew Murray X-Patchwork-Id: 10690575 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id E9CCD13AD for ; Tue, 20 Nov 2018 15:56:33 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id D86292A9AE for ; Tue, 20 Nov 2018 15:56:33 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id CCD992A9F3; Tue, 20 Nov 2018 15:56:33 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,RCVD_IN_DNSWL_LOW autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 5CE752A9AE for ; Tue, 20 Nov 2018 15:56:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:References: In-Reply-To:Message-Id:Date:Subject:To:From:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=Wz496ALM6XrOT12XT7OkS0t7Tq+JaU4w1gu6xO4l9lU=; b=cG1q8+6LNkHQjDLxy5/o9SpjK6 rv/cDOcP6byY7U6LfbTjXwjYXHL+GjbBm49ruJz+LCsSMOke80aXMWVBgBHFb7poFtgrB/XPHAKxL /BCFvvXIsbn9Wv7jIS2VYY2TEiWlBNQfvk6ml82ceyDqh53m9QH4de/njJi8TRes6gz/sdL/hgXQr tf2Tian+SRnb2H2cUbd8cgitAiG0u246y5pMli8ahrTzvI2pAfDMps3zbonuVDS6CvwFQaECFTOR5 Q0ctIbqooX0HDJdtpJWkT2Jhd95cURkbpu/ZAp3B044GI/OAEqX2pW+1ws/JvGWE8B/TiuRQ/SLns UwqQ5Akw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1gP8O7-0006pz-IM; Tue, 20 Nov 2018 15:56:31 +0000 Received: from merlin.infradead.org ([205.233.59.134]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1gP8Fu-0003nl-K1 for linux-arm-kernel@bombadil.infradead.org; Tue, 20 Nov 2018 15:48:02 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=merlin.20170209; h=References:In-Reply-To:Message-Id:Date: Subject:Cc:To:From:Sender:Reply-To:MIME-Version:Content-Type: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=mSJ+L2M5CGIWfPSRwqmMWy7lavszJ/0KgBEBYE4JlP4=; b=GHrt/ByxSlWLcSzEfrVl4Oagb UsG83b5IFQtTChzQdjYHeY5mvVmL1v/OYQQ7nERgkcTBpiCeEBsQBiB85jc0g3EsPAogjIbu9NMQw oiFkPEAskvpYfjAuTzphHy3bHT4JfWhTRw6ueT+HvN9JXVlS/Ysct7QbmDFQKL0ozHTDr83jbYfsy 4zj4CqQJa1+jmA2o4HojM9u/+ZSu1Cf0PWX+W44wpZDDlAwbsMg9Orajiwhvo2NHdHaOB4+ZrH1N3 zqeKD1QyTpGMAGfRHht6QN9PGvYiZMuTrnOcrrUiTzHb7eq88hPCKdKqIcxPYE5hrmybg/XKSmAlL JH2JyOG2w==; Received: from foss.arm.com ([217.140.101.70]) by merlin.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1gP6of-0008T5-Uz for linux-arm-kernel@lists.infradead.org; Tue, 20 Nov 2018 14:15:50 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 3E8EB15AB; Tue, 20 Nov 2018 06:15:40 -0800 (PST) Received: from e119886-lin.cambridge.arm.com (unknown [10.37.6.11]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 48EBA3F5A0; Tue, 20 Nov 2018 06:15:38 -0800 (PST) From: Andrew Murray To: Christoffer Dall , Marc Zyngier , Catalin Marinas , Will Deacon , Mark Rutland Subject: [PATCH v2 1/4] arm64: arm_pmu: remove unnecessary isb instruction Date: Tue, 20 Nov 2018 14:15:19 +0000 Message-Id: <1542723322-42536-2-git-send-email-andrew.murray@arm.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1542723322-42536-1-git-send-email-andrew.murray@arm.com> References: <1542723322-42536-1-git-send-email-andrew.murray@arm.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20181120_091550_077837_42CC957A X-CRM114-Status: GOOD ( 12.96 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Julien Thierry , kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org, Suzuki K Poulose MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP The armv8pmu_enable_event_counter function issues an isb instruction after enabling a pair of counters - this doesn't provide any value and is inconsistent with the armv8pmu_disable_event_counter. In any case armv8pmu_enable_event_counter is always called with the PMU stopped. Starting the PMU with armv8pmu_start results in an isb instruction being issued. Let's remove the unnecessary isb instruction. Signed-off-by: Andrew Murray Acked-by: Mark Rutland --- arch/arm64/kernel/perf_event.c | 1 - 1 file changed, 1 deletion(-) diff --git a/arch/arm64/kernel/perf_event.c b/arch/arm64/kernel/perf_event.c index 8e38d52..de564ae 100644 --- a/arch/arm64/kernel/perf_event.c +++ b/arch/arm64/kernel/perf_event.c @@ -652,7 +652,6 @@ static inline void armv8pmu_enable_event_counter(struct perf_event *event) armv8pmu_enable_counter(idx); if (armv8pmu_event_is_chained(event)) armv8pmu_enable_counter(idx - 1); - isb(); } static inline int armv8pmu_disable_counter(int idx)