| Message ID | 1543862228-3863-1-git-send-email-stefan.wahren@i2se.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | ARM: dts: bcm2837: Fix polarity of wifi reset GPIOs | expand |
Stefan Wahren <stefan.wahren@i2se.com> writes: > The commit b1b8f45b3130 ("ARM: dts: bcm2837: Add missing GPIOs of Expander") > introduced a wifi power sequence. Unfortunately the polarity of the reset > GPIOs were wrong and broke the wifi support on Raspberry Pi 3 B and > later in 3 B+. This wasn't discovered before since the power sequence > takes only effect in case the relevant MMC driver is compiled as a module. > > Fixes: b1b8f45b3130 ("ARM: dts: bcm2837: Add missing GPIOs of Expander") > Cc: stable@vger.kernel.org > Reported-by: Matthias Lueschner <lueschem@gmail.com> > Link: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=911443 > Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com> > --- > > Hi, i like to have this included in 4.20 if possible. Reviewed-by: Eric Anholt <eric@anholt.net> Florian, would you be able to pick this directly to a -fixes branch?
On Mon, 3 Dec 2018 19:37:08 +0100, Stefan Wahren <stefan.wahren@i2se.com> wrote: > The commit b1b8f45b3130 ("ARM: dts: bcm2837: Add missing GPIOs of Expander") > introduced a wifi power sequence. Unfortunately the polarity of the reset > GPIOs were wrong and broke the wifi support on Raspberry Pi 3 B and > later in 3 B+. This wasn't discovered before since the power sequence > takes only effect in case the relevant MMC driver is compiled as a module. > > Fixes: b1b8f45b3130 ("ARM: dts: bcm2837: Add missing GPIOs of Expander") > Cc: stable@vger.kernel.org > Reported-by: Matthias Lueschner <lueschem@gmail.com> > Link: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=911443 > Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com> > --- Applied to devicetree/fixes, thanks! -- Florian
diff --git a/arch/arm/boot/dts/bcm2837-rpi-3-b-plus.dts b/arch/arm/boot/dts/bcm2837-rpi-3-b-plus.dts index 4adb85e..9376224 100644 --- a/arch/arm/boot/dts/bcm2837-rpi-3-b-plus.dts +++ b/arch/arm/boot/dts/bcm2837-rpi-3-b-plus.dts @@ -31,7 +31,7 @@ wifi_pwrseq: wifi-pwrseq { compatible = "mmc-pwrseq-simple"; - reset-gpios = <&expgpio 1 GPIO_ACTIVE_HIGH>; + reset-gpios = <&expgpio 1 GPIO_ACTIVE_LOW>; }; }; diff --git a/arch/arm/boot/dts/bcm2837-rpi-3-b.dts b/arch/arm/boot/dts/bcm2837-rpi-3-b.dts index c318bcb..89e6fd5 100644 --- a/arch/arm/boot/dts/bcm2837-rpi-3-b.dts +++ b/arch/arm/boot/dts/bcm2837-rpi-3-b.dts @@ -26,7 +26,7 @@ wifi_pwrseq: wifi-pwrseq { compatible = "mmc-pwrseq-simple"; - reset-gpios = <&expgpio 1 GPIO_ACTIVE_HIGH>; + reset-gpios = <&expgpio 1 GPIO_ACTIVE_LOW>; }; };
The commit b1b8f45b3130 ("ARM: dts: bcm2837: Add missing GPIOs of Expander") introduced a wifi power sequence. Unfortunately the polarity of the reset GPIOs were wrong and broke the wifi support on Raspberry Pi 3 B and later in 3 B+. This wasn't discovered before since the power sequence takes only effect in case the relevant MMC driver is compiled as a module. Fixes: b1b8f45b3130 ("ARM: dts: bcm2837: Add missing GPIOs of Expander") Cc: stable@vger.kernel.org Reported-by: Matthias Lueschner <lueschem@gmail.com> Link: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=911443 Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com> --- Hi, i like to have this included in 4.20 if possible. Stefan arch/arm/boot/dts/bcm2837-rpi-3-b-plus.dts | 2 +- arch/arm/boot/dts/bcm2837-rpi-3-b.dts | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)