From patchwork Fri Mar 29 13:23:28 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Zenghui Yu X-Patchwork-Id: 10877061 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 47D891708 for ; Fri, 29 Mar 2019 13:25:02 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 2488D28E1A for ; Fri, 29 Mar 2019 13:25:02 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 17B0528EA2; Fri, 29 Mar 2019 13:25:02 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id E2A5928E1A for ; Fri, 29 Mar 2019 13:24:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:Subject:To :From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=3xbZYfDiOI3OIqGFY2+h79deBwODN+C9DarhBfr5vIs=; b=B8wdZXpkTeZC/x ufXNyiO6eB4QCBSDmsdY54hf3NYp/9MW2fR62NWvNpzcfLuHj+o4Yh3OV6LD0zqYJxy/iBWO0H0iK MIu38Qf25GwRwNeMB6PXl/A5RDVhZMGKq7twHSBY4EQZcaElOBJYWLhDUiNpihEGDsHeG/s6A3JGX V5rKORF4G+9xaSanujt3B2lCD3ZhXGOrNpbs8o2X2/GRRVfBXl8ZC3RHsaOm0sVbRYifqn06txdax 01iD6dMA2Xt3OAAw1EJBRvZMV0hD1XJZPL8gr1y+yJTqHlC8ZGvnR1Vo1prkkelc4yf22gvMzWB92 6p4Ij/c95s3NL3QC7cLQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1h9rV9-0007pV-AK; Fri, 29 Mar 2019 13:24:55 +0000 Received: from szxga06-in.huawei.com ([45.249.212.32] helo=huawei.com) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1h9rV4-0007oT-Tm for linux-arm-kernel@lists.infradead.org; Fri, 29 Mar 2019 13:24:52 +0000 Received: from DGGEMS413-HUB.china.huawei.com (unknown [172.30.72.60]) by Forcepoint Email with ESMTP id 45325F1F2600378F1DE8; Fri, 29 Mar 2019 21:24:39 +0800 (CST) Received: from HGHY2Y004646261.china.huawei.com (10.184.12.158) by DGGEMS413-HUB.china.huawei.com (10.3.19.213) with Microsoft SMTP Server id 14.3.408.0; Fri, 29 Mar 2019 21:24:31 +0800 From: Zenghui Yu To: , , Subject: [RFC PATCH] irqchip/gic-v3: Make gic_handle_irq() notrace Date: Fri, 29 Mar 2019 13:23:28 +0000 Message-ID: <1553865808-30604-1-git-send-email-yuzenghui@huawei.com> X-Mailer: git-send-email 2.6.4.windows.1 MIME-Version: 1.0 X-Originating-IP: [10.184.12.158] X-CFilter-Loop: Reflected X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190329_062451_137049_13BC58A2 X-CRM114-Status: GOOD ( 11.83 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mark.rutland@arm.com, suzuki.poulose@arm.com, catalin.marinas@arm.com, will.deacon@arm.com, linux@armlinux.org.uk, linux-kernel@vger.kernel.org, mingo@redhat.com, james.morse@arm.com, Zenghui Yu , wanghaibin.wang@huawei.com, linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP Enable pseudo NMI together with function_graph tracer, will lead the system to a hang. This is easy to reproduce, 1) Set "irqchip.gicv3_pseudo_nmi=1" on the kernel command line 2) echo function_graph > /sys/kernel/debug/tracing/current_tracer This patch (RFC) set gic_handle_irq() as notrace and it seems works fine now. But I have no idea about what the issue is exactly, and you can regard this patch as a report then :) Can someone give a look at it and provide some explanations ? Thanks! Cc: Julien Thierry Cc: Steven Rostedt Signed-off-by: Zenghui Yu --- drivers/irqchip/irq-gic-v3.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/irqchip/irq-gic-v3.c b/drivers/irqchip/irq-gic-v3.c index 15e55d3..8d0c25f 100644 --- a/drivers/irqchip/irq-gic-v3.c +++ b/drivers/irqchip/irq-gic-v3.c @@ -487,7 +487,7 @@ static inline void gic_handle_nmi(u32 irqnr, struct pt_regs *regs) gic_deactivate_unhandled(irqnr); } -static asmlinkage void __exception_irq_entry gic_handle_irq(struct pt_regs *regs) +static asmlinkage notrace void __exception_irq_entry gic_handle_irq(struct pt_regs *regs) { u32 irqnr;