| Message ID | 1557732606-14662-1-git-send-email-amelie.delaunay@st.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | pinctrl: stmfx: Fix comparison of unsigned expression warnings | expand |
On Mon, 13 May 2019, Amelie Delaunay wrote: > This patch fixes the following warnings: > > drivers/pinctrl/pinctrl-stmfx.c:225:5-8: WARNING: Unsigned expression > compared with zero: dir < 0 > drivers/pinctrl/pinctrl-stmfx.c:231:5-9: WARNING: Unsigned expression > compared with zero: pupd < 0 > drivers/pinctrl/pinctrl-stmfx.c:228:5-9: WARNING: Unsigned expression > compared with zero: type < 0 > > Fixes: 1490d9f841b1 ("pinctrl: Add STMFX GPIO expander Pinctrl/GPIO driver") > Reported-by: kbuild test robot <lkp@intel.com> > Reported-by: Julia Lawall <julia.lawall@lip6.fr> > Signed-off-by: Amelie Delaunay <amelie.delaunay@st.com> > --- > drivers/pinctrl/pinctrl-stmfx.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Already fixed up and pushed. > diff --git a/drivers/pinctrl/pinctrl-stmfx.c b/drivers/pinctrl/pinctrl-stmfx.c > index bcd8126..3bd5d6f 100644 > --- a/drivers/pinctrl/pinctrl-stmfx.c > +++ b/drivers/pinctrl/pinctrl-stmfx.c > @@ -213,7 +213,7 @@ static int stmfx_pinconf_get(struct pinctrl_dev *pctldev, > struct stmfx_pinctrl *pctl = pinctrl_dev_get_drvdata(pctldev); > u32 param = pinconf_to_config_param(*config); > struct pinctrl_gpio_range *range; > - u32 dir, type, pupd; > + int dir, type, pupd; > u32 arg = 0; > int ret; >
On Mon, 13 May 2019, Amelie Delaunay wrote: > This patch fixes the following warnings: > > drivers/pinctrl/pinctrl-stmfx.c:225:5-8: WARNING: Unsigned expression > compared with zero: dir < 0 > drivers/pinctrl/pinctrl-stmfx.c:231:5-9: WARNING: Unsigned expression > compared with zero: pupd < 0 > drivers/pinctrl/pinctrl-stmfx.c:228:5-9: WARNING: Unsigned expression > compared with zero: type < 0 > > Fixes: 1490d9f841b1 ("pinctrl: Add STMFX GPIO expander Pinctrl/GPIO driver") > Reported-by: kbuild test robot <lkp@intel.com> > Reported-by: Julia Lawall <julia.lawall@lip6.fr> > Signed-off-by: Amelie Delaunay <amelie.delaunay@st.com> Acked-by: Julia Lawall <julia.lawall@lip6.fr> > --- > drivers/pinctrl/pinctrl-stmfx.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/pinctrl/pinctrl-stmfx.c b/drivers/pinctrl/pinctrl-stmfx.c > index bcd8126..3bd5d6f 100644 > --- a/drivers/pinctrl/pinctrl-stmfx.c > +++ b/drivers/pinctrl/pinctrl-stmfx.c > @@ -213,7 +213,7 @@ static int stmfx_pinconf_get(struct pinctrl_dev *pctldev, > struct stmfx_pinctrl *pctl = pinctrl_dev_get_drvdata(pctldev); > u32 param = pinconf_to_config_param(*config); > struct pinctrl_gpio_range *range; > - u32 dir, type, pupd; > + int dir, type, pupd; > u32 arg = 0; > int ret; > > -- > 2.7.4 > >
diff --git a/drivers/pinctrl/pinctrl-stmfx.c b/drivers/pinctrl/pinctrl-stmfx.c index bcd8126..3bd5d6f 100644 --- a/drivers/pinctrl/pinctrl-stmfx.c +++ b/drivers/pinctrl/pinctrl-stmfx.c @@ -213,7 +213,7 @@ static int stmfx_pinconf_get(struct pinctrl_dev *pctldev, struct stmfx_pinctrl *pctl = pinctrl_dev_get_drvdata(pctldev); u32 param = pinconf_to_config_param(*config); struct pinctrl_gpio_range *range; - u32 dir, type, pupd; + int dir, type, pupd; u32 arg = 0; int ret;
This patch fixes the following warnings: drivers/pinctrl/pinctrl-stmfx.c:225:5-8: WARNING: Unsigned expression compared with zero: dir < 0 drivers/pinctrl/pinctrl-stmfx.c:231:5-9: WARNING: Unsigned expression compared with zero: pupd < 0 drivers/pinctrl/pinctrl-stmfx.c:228:5-9: WARNING: Unsigned expression compared with zero: type < 0 Fixes: 1490d9f841b1 ("pinctrl: Add STMFX GPIO expander Pinctrl/GPIO driver") Reported-by: kbuild test robot <lkp@intel.com> Reported-by: Julia Lawall <julia.lawall@lip6.fr> Signed-off-by: Amelie Delaunay <amelie.delaunay@st.com> --- drivers/pinctrl/pinctrl-stmfx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)