| Message ID | 1562082426-14876-3-git-send-email-olivier.moysan@st.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | drm/bridge: sii902x: fix audio mclk management | expand |
On 02/07/2019 18:47, Olivier Moysan wrote: > As stated in SiL9022/24 datasheet, master clock is not required for I2S. > Make mclk property optional in DT bindings. > > Fixes: 3f18021f43a3 ("dt-bindings: display: sii902x: Add HDMI audio bindings") > > Signed-off-by: Olivier Moysan <olivier.moysan@st.com> Looking the specs again it looks like the mclk is requred for sii9020, but not for sii9022 and sii9024. So I guess it is fine to accept the configurations without the mclk. Reviewed-by: Jyri Sarha <jsarha@ti.com> > --- > Documentation/devicetree/bindings/display/bridge/sii902x.txt | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/Documentation/devicetree/bindings/display/bridge/sii902x.txt b/Documentation/devicetree/bindings/display/bridge/sii902x.txt > index 2df44b7d3821..6e14e087c0d0 100644 > --- a/Documentation/devicetree/bindings/display/bridge/sii902x.txt > +++ b/Documentation/devicetree/bindings/display/bridge/sii902x.txt > @@ -26,9 +26,8 @@ Optional properties: > - clocks: phandle and clock specifier for each clock listed in > the clock-names property > - clock-names: "mclk" > - Describes SII902x MCLK input. MCLK is used to produce > - HDMI audio CTS values. This property is required if > - "#sound-dai-cells"-property is present. This property follows > + Describes SII902x MCLK input. MCLK can be used to produce > + HDMI audio CTS values. This property follows > Documentation/devicetree/bindings/clock/clock-bindings.txt > consumer binding. > >
Hi Olivier, and many thanks for your patch. I have double checked in the sil9022/24 datasheet and you are right: "As an option, the original MCLK signal used to strobe the I2S signals out from the sourcing chip can be used. If the internal PLL is used, then an external MCLK input is not required." So, even if #sound-dai-cells is there, this is not mandatory to have MCLK. Reviewed-by: Philippe Cornu <philippe.cornu@st.com> Philippe :-) On 7/2/19 5:47 PM, Olivier Moysan wrote: > As stated in SiL9022/24 datasheet, master clock is not required for I2S. > Make mclk property optional in DT bindings. > > Fixes: 3f18021f43a3 ("dt-bindings: display: sii902x: Add HDMI audio bindings") > > Signed-off-by: Olivier Moysan <olivier.moysan@st.com> > --- > Documentation/devicetree/bindings/display/bridge/sii902x.txt | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/Documentation/devicetree/bindings/display/bridge/sii902x.txt b/Documentation/devicetree/bindings/display/bridge/sii902x.txt > index 2df44b7d3821..6e14e087c0d0 100644 > --- a/Documentation/devicetree/bindings/display/bridge/sii902x.txt > +++ b/Documentation/devicetree/bindings/display/bridge/sii902x.txt > @@ -26,9 +26,8 @@ Optional properties: > - clocks: phandle and clock specifier for each clock listed in > the clock-names property > - clock-names: "mclk" > - Describes SII902x MCLK input. MCLK is used to produce > - HDMI audio CTS values. This property is required if > - "#sound-dai-cells"-property is present. This property follows > + Describes SII902x MCLK input. MCLK can be used to produce > + HDMI audio CTS values. This property follows > Documentation/devicetree/bindings/clock/clock-bindings.txt > consumer binding. > >
On 02.07.2019 17:47, Olivier Moysan wrote: > As stated in SiL9022/24 datasheet, master clock is not required for I2S. > Make mclk property optional in DT bindings. > > Fixes: 3f18021f43a3 ("dt-bindings: display: sii902x: Add HDMI audio bindings") > > Signed-off-by: Olivier Moysan <olivier.moysan@st.com> > --- > Documentation/devicetree/bindings/display/bridge/sii902x.txt | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/Documentation/devicetree/bindings/display/bridge/sii902x.txt b/Documentation/devicetree/bindings/display/bridge/sii902x.txt > index 2df44b7d3821..6e14e087c0d0 100644 > --- a/Documentation/devicetree/bindings/display/bridge/sii902x.txt > +++ b/Documentation/devicetree/bindings/display/bridge/sii902x.txt > @@ -26,9 +26,8 @@ Optional properties: > - clocks: phandle and clock specifier for each clock listed in > the clock-names property > - clock-names: "mclk" > - Describes SII902x MCLK input. MCLK is used to produce > - HDMI audio CTS values. This property is required if > - "#sound-dai-cells"-property is present. This property follows > + Describes SII902x MCLK input. MCLK can be used to produce > + HDMI audio CTS values. This property follows > Documentation/devicetree/bindings/clock/clock-bindings.txt > consumer binding. > Acked-by: Andrzej Hajda <a.hajda@samsung.com> -- Regards Andrzej
diff --git a/Documentation/devicetree/bindings/display/bridge/sii902x.txt b/Documentation/devicetree/bindings/display/bridge/sii902x.txt index 2df44b7d3821..6e14e087c0d0 100644 --- a/Documentation/devicetree/bindings/display/bridge/sii902x.txt +++ b/Documentation/devicetree/bindings/display/bridge/sii902x.txt @@ -26,9 +26,8 @@ Optional properties: - clocks: phandle and clock specifier for each clock listed in the clock-names property - clock-names: "mclk" - Describes SII902x MCLK input. MCLK is used to produce - HDMI audio CTS values. This property is required if - "#sound-dai-cells"-property is present. This property follows + Describes SII902x MCLK input. MCLK can be used to produce + HDMI audio CTS values. This property follows Documentation/devicetree/bindings/clock/clock-bindings.txt consumer binding.
As stated in SiL9022/24 datasheet, master clock is not required for I2S. Make mclk property optional in DT bindings. Fixes: 3f18021f43a3 ("dt-bindings: display: sii902x: Add HDMI audio bindings") Signed-off-by: Olivier Moysan <olivier.moysan@st.com> --- Documentation/devicetree/bindings/display/bridge/sii902x.txt | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)