From patchwork Thu Jul 25 08:16:05 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Masami Hiramatsu (Google)" X-Patchwork-Id: 11058201 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 249AC14DB for ; Thu, 25 Jul 2019 08:17:16 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 0F67F287E2 for ; Thu, 25 Jul 2019 08:17:16 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id F0258287FE; Thu, 25 Jul 2019 08:17:15 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 83EDF287E2 for ; Thu, 25 Jul 2019 08:17:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=lGYxf4mEaw1hGj6Wq4w70s7PquFZngseIZr1WWzvtT4=; b=o82Zvd+p0W4/qg H83SEqF6sQp8tunFiOwEe1G7y1Qn69vKvllTdXG18Sm1DfBo733Rd6T0CXFHDFUtCg7pfVKqHrwCe 8RywwSKgmYxPBSFKAg9OLVorITM3489zP+944vpiDvm/R2D3FuJrjtf33agoo3aVd4ZgmU62kKnnN a/nPAbekiVwzh12MvCS1dYocbtbyM3t7z+AzhJ159XyhbJXY401OcZzqHZCSWshoy/qAq2GqfkRV2 zVsIlfQaog+Oc3Dn2UK7RdVu6Srj/PTIxHp+oiQFH2fYluUFZIdcxjouxsbor8zh+dnCrqmbJ2N7Z zG9Cjw9sZ5WPSAAt+EgQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hqYw6-0004MX-71; Thu, 25 Jul 2019 08:17:14 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hqYv3-0003vw-QM for linux-arm-kernel@lists.infradead.org; Thu, 25 Jul 2019 08:16:11 +0000 Received: from localhost.localdomain (NE2965lan1.rev.em-net.ne.jp [210.141.244.193]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 7EE7E22CB8; Thu, 25 Jul 2019 08:16:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1564042569; bh=lpvJdO31en1wcj0t6J2VjwvDEWvWEgYER3oV5jINp3k=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=yCBi3i5GNbP+BcE7uzuOnYI8PH4hvoK5Lt/RiP2fH/9Deft2CUfD/wr6auPp71Z1i h1CxJs+S620wwqO1qPW3WJnCdi5LsmUJdPlB8dG7e76rgNhdplMD0xTPuwbK1JuvaL dADXYfUpDnu80TGFFkfpwas36rIkqVTBS6sFk/XQ= From: Masami Hiramatsu To: Catalin Marinas , Will Deacon Subject: [PATCH v3 2/4] arm64: unwind: Prohibit probing on return_address() Date: Thu, 25 Jul 2019 17:16:05 +0900 Message-Id: <156404256479.2020.11810441013424601533.stgit@devnote2> X-Mailer: git-send-email 2.20.1 In-Reply-To: <156404254387.2020.886452004489353899.stgit@devnote2> References: <156404254387.2020.886452004489353899.stgit@devnote2> User-Agent: StGit/0.17.1-dirty MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190725_011610_183447_6DC39D6E X-CRM114-Status: GOOD ( 12.07 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Dan Rue , Daniel Diaz , Anders Roxell , Naresh Kamboju , linux-kernel@vger.kernel.org, Matt Hart , linux-arm-kernel@lists.infradead.org, mhiramat@kernel.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP Prohibit probing on return_address() and subroutines which is called from return_address(), since the it is invoked from trace_hardirqs_off() which is also kprobe blacklisted. Reported-by: Naresh Kamboju Signed-off-by: Masami Hiramatsu --- Changes in v3: - Fix to use NOKPROBE_SYMBOL() for save_return_addr instead of nokprobe_inline. --- arch/arm64/kernel/return_address.c | 3 +++ arch/arm64/kernel/stacktrace.c | 3 +++ 2 files changed, 6 insertions(+) diff --git a/arch/arm64/kernel/return_address.c b/arch/arm64/kernel/return_address.c index b21cba90f82d..491184a9f081 100644 --- a/arch/arm64/kernel/return_address.c +++ b/arch/arm64/kernel/return_address.c @@ -8,6 +8,7 @@ #include #include +#include #include #include @@ -29,6 +30,7 @@ static int save_return_addr(struct stackframe *frame, void *d) return 0; } } +NOKPROBE_SYMBOL(save_return_addr); void *return_address(unsigned int level) { @@ -52,3 +54,4 @@ void *return_address(unsigned int level) return NULL; } EXPORT_SYMBOL_GPL(return_address); +NOKPROBE_SYMBOL(return_address); diff --git a/arch/arm64/kernel/stacktrace.c b/arch/arm64/kernel/stacktrace.c index 62d395151abe..cd7dab54d17b 100644 --- a/arch/arm64/kernel/stacktrace.c +++ b/arch/arm64/kernel/stacktrace.c @@ -7,6 +7,7 @@ #include #include #include +#include #include #include #include @@ -73,6 +74,7 @@ int notrace unwind_frame(struct task_struct *tsk, struct stackframe *frame) return 0; } +NOKPROBE_SYMBOL(unwind_frame); void notrace walk_stackframe(struct task_struct *tsk, struct stackframe *frame, int (*fn)(struct stackframe *, void *), void *data) @@ -87,6 +89,7 @@ void notrace walk_stackframe(struct task_struct *tsk, struct stackframe *frame, break; } } +NOKPROBE_SYMBOL(walk_stackframe); #ifdef CONFIG_STACKTRACE struct stack_trace_data {