| Message ID | 1568096664-13252-1-git-send-email-tanmay@marvell.com (mailing list archive) |
|---|---|
| State | Mainlined |
| Commit | 0373d90639ef45c419d14131c3037436b05c4243 |
| Headers | show |
| Series | [v2] coresight: etm4x: Add support for ThunderX2 | expand |
On Tue, Sep 10, 2019 at 06:25:02AM +0000, Tanmay Vilas Kumar Jagdale wrote: > Add ETMv4 periperhal ID for Marvell's ThunderX2 chip. > This chip contains ETMv4.1 version. > > Signed-off-by: Tanmay Jagdale <tanmay@marvell.com> mpoirier@xps15:~/work/coresight/kernel-maint$ ./scripts/checkpatch.pl 0001-coresight-etm4x-Add-support-for-ThunderX2.patch WARNING: Missing Signed-off-by: line by nominal patch author 'Tanmay Vilas Kumar Jagdale <tanmay@marvell.com>' total: 0 errors, 1 warnings, 7 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. 0001-coresight-etm4x-Add-support-for-ThunderX2.patch has style problems, please review. NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS > --- > Changes since v1: > - Updated commit message. > - Use UCI to identify ETMv4. > - Remove addition of ETMv4.1 version checks. > > drivers/hwtracing/coresight/coresight-etm4x.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/hwtracing/coresight/coresight-etm4x.c b/drivers/hwtracing/coresight/coresight-etm4x.c > index a128b5063f46..47839b4a8bc0 100644 > --- a/drivers/hwtracing/coresight/coresight-etm4x.c > +++ b/drivers/hwtracing/coresight/coresight-etm4x.c > @@ -1211,6 +1211,7 @@ static const struct amba_id etm4_ids[] = { > CS_AMBA_UCI_ID(0x000f0211, uci_id_etm4),/* Qualcomm Kryo */ > CS_AMBA_ID(0x000bb802), /* Qualcomm Kryo 385 Cortex-A55 */ > CS_AMBA_ID(0x000bb803), /* Qualcomm Kryo 385 Cortex-A75 */ > + CS_AMBA_UCI_ID(0x000cc0af, uci_id_etm4),/* Marvell ThunderX2 */ > {}, > }; > > -- > 2.17.1 >
Hi Tanmay, On 16/09/2019 20:58, Mathieu Poirier wrote: > On Tue, Sep 10, 2019 at 06:25:02AM +0000, Tanmay Vilas Kumar Jagdale wrote: >> Add ETMv4 periperhal ID for Marvell's ThunderX2 chip. >> This chip contains ETMv4.1 version. >> >> Signed-off-by: Tanmay Jagdale <tanmay@marvell.com> > > mpoirier@xps15:~/work/coresight/kernel-maint$ ./scripts/checkpatch.pl 0001-coresight-etm4x-Add-support-for-ThunderX2.patch > WARNING: Missing Signed-off-by: line by nominal patch author 'Tanmay Vilas Kumar Jagdale <tanmay@marvell.com>' > To translate that message a bit more, "Signed-off-by:" is kind of a legal declaration. So, please use your full legal name. Cheers Suzuki
diff --git a/drivers/hwtracing/coresight/coresight-etm4x.c b/drivers/hwtracing/coresight/coresight-etm4x.c index a128b5063f46..47839b4a8bc0 100644 --- a/drivers/hwtracing/coresight/coresight-etm4x.c +++ b/drivers/hwtracing/coresight/coresight-etm4x.c @@ -1211,6 +1211,7 @@ static const struct amba_id etm4_ids[] = { CS_AMBA_UCI_ID(0x000f0211, uci_id_etm4),/* Qualcomm Kryo */ CS_AMBA_ID(0x000bb802), /* Qualcomm Kryo 385 Cortex-A55 */ CS_AMBA_ID(0x000bb803), /* Qualcomm Kryo 385 Cortex-A75 */ + CS_AMBA_UCI_ID(0x000cc0af, uci_id_etm4),/* Marvell ThunderX2 */ {}, };
Add ETMv4 periperhal ID for Marvell's ThunderX2 chip. This chip contains ETMv4.1 version. Signed-off-by: Tanmay Jagdale <tanmay@marvell.com> --- Changes since v1: - Updated commit message. - Use UCI to identify ETMv4. - Remove addition of ETMv4.1 version checks. drivers/hwtracing/coresight/coresight-etm4x.c | 1 + 1 file changed, 1 insertion(+)