Message ID | 1576221873-28738-1-git-send-email-krzk@kernel.org (mailing list archive) |
---|---|
State | Mainlined |
Commit | 225a2ec19aac426ef29f0e4accfc890c87d38bdc |
Headers | show |
Series | pinctrl: samsung: Fix missing OF and GPIOLIB dependency on S3C24xx and S3C64xx | expand |
On Fri, Dec 13, 2019 at 8:24 AM Krzysztof Kozlowski <krzk@kernel.org> wrote: > All Samsung pinctrl drivers select common part - PINCTRL_SAMSUNG which uses > both OF and GPIOLIB inside. However only Exynos drivers depend on these, > therefore after enabling COMPILE_TEST, on x86_64 build of S3C64xx driver > failed: > > drivers/pinctrl/samsung/pinctrl-samsung.c: In function ‘samsung_gpiolib_register’: > drivers/pinctrl/samsung/pinctrl-samsung.c:969:5: error: ‘struct gpio_chip’ has no member named ‘of_node’ > gc->of_node = bank->of_node; > ^ > > Rework the dependencies so all Samsung drivers and common > PINCTRL_SAMSUNG part depend on OF_GPIO (which is default yes if GPIOLIB > and OF are enabled). > > Reported-by: Chen Zhou <chenzhou10@huawei.com> > Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org> What should this be applied on? It doesn't apply to my fixes branch which is close to v5.5-rc1. Please rebase and resend if this was not based on that. Should this have a Fixes: tag? Yours, Linus Walleij
On Fri, Dec 13, 2019 at 08:24:33AM +0100, Krzysztof Kozlowski wrote: > All Samsung pinctrl drivers select common part - PINCTRL_SAMSUNG which uses > both OF and GPIOLIB inside. However only Exynos drivers depend on these, > therefore after enabling COMPILE_TEST, on x86_64 build of S3C64xx driver > failed: > > drivers/pinctrl/samsung/pinctrl-samsung.c: In function ‘samsung_gpiolib_register’: > drivers/pinctrl/samsung/pinctrl-samsung.c:969:5: error: ‘struct gpio_chip’ has no member named ‘of_node’ > gc->of_node = bank->of_node; > ^ > > Rework the dependencies so all Samsung drivers and common > PINCTRL_SAMSUNG part depend on OF_GPIO (which is default yes if GPIOLIB > and OF are enabled). > > Reported-by: Chen Zhou <chenzhou10@huawei.com> > Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org> > --- > drivers/pinctrl/samsung/Kconfig | 6 ++++-- Applied. Best regards, Krzysztof
diff --git a/drivers/pinctrl/samsung/Kconfig b/drivers/pinctrl/samsung/Kconfig index 779c0e9eca3f..dfd805e76862 100644 --- a/drivers/pinctrl/samsung/Kconfig +++ b/drivers/pinctrl/samsung/Kconfig @@ -4,12 +4,13 @@ # config PINCTRL_SAMSUNG bool + depends on OF_GPIO select PINMUX select PINCONF config PINCTRL_EXYNOS bool "Pinctrl common driver part for Samsung Exynos SoCs" - depends on OF && GPIOLIB + depends on OF_GPIO depends on ARCH_EXYNOS || ARCH_S5PV210 || COMPILE_TEST select PINCTRL_SAMSUNG select PINCTRL_EXYNOS_ARM if ARM && (ARCH_EXYNOS || ARCH_S5PV210) @@ -25,11 +26,12 @@ config PINCTRL_EXYNOS_ARM64 config PINCTRL_S3C24XX bool "Samsung S3C24XX SoC pinctrl driver" - depends on OF + depends on OF_GPIO depends on ARCH_S3C24XX || COMPILE_TEST select PINCTRL_SAMSUNG config PINCTRL_S3C64XX bool "Samsung S3C64XX SoC pinctrl driver" + depends on OF_GPIO depends on ARCH_S3C64XX || COMPILE_TEST select PINCTRL_SAMSUNG
All Samsung pinctrl drivers select common part - PINCTRL_SAMSUNG which uses both OF and GPIOLIB inside. However only Exynos drivers depend on these, therefore after enabling COMPILE_TEST, on x86_64 build of S3C64xx driver failed: drivers/pinctrl/samsung/pinctrl-samsung.c: In function ‘samsung_gpiolib_register’: drivers/pinctrl/samsung/pinctrl-samsung.c:969:5: error: ‘struct gpio_chip’ has no member named ‘of_node’ gc->of_node = bank->of_node; ^ Rework the dependencies so all Samsung drivers and common PINCTRL_SAMSUNG part depend on OF_GPIO (which is default yes if GPIOLIB and OF are enabled). Reported-by: Chen Zhou <chenzhou10@huawei.com> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org> --- drivers/pinctrl/samsung/Kconfig | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-)