diff mbox series

media: platform: stm32: don't print an error on probe deferral

Message ID 1579602169-7484-1-git-send-email-yannick.fertre@st.com (mailing list archive)
State Mainlined
Commit a5e72cfa6a75361da69bfb9177ddf7ef7303c1e3
Headers show
Series media: platform: stm32: don't print an error on probe deferral | expand

Commit Message

Yannick FERTRE Jan. 21, 2020, 10:22 a.m. UTC
From: Etienne Carriere <etienne.carriere@st.com>

Change stm32-cec driver to not print an error message when the
device probe operation is deferred.

Signed-off-by: Etienne Carriere <etienne.carriere@st.com>
---
 drivers/media/platform/stm32/stm32-cec.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

Comments

Philippe CORNU Jan. 23, 2020, 9:53 a.m. UTC | #1
Dears Yannick & Etienne,
Thank you for your patch,

Reviewed-by: Philippe Cornu <philippe.cornu@st.com>

Philippe :-)

On 1/21/20 11:22 AM, Yannick Fertre wrote:
> From: Etienne Carriere <etienne.carriere@st.com>
> 
> Change stm32-cec driver to not print an error message when the
> device probe operation is deferred.
> 
> Signed-off-by: Etienne Carriere <etienne.carriere@st.com>
> ---
>   drivers/media/platform/stm32/stm32-cec.c | 4 +++-
>   1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/media/platform/stm32/stm32-cec.c b/drivers/media/platform/stm32/stm32-cec.c
> index 8a86b2c..9c137f1 100644
> --- a/drivers/media/platform/stm32/stm32-cec.c
> +++ b/drivers/media/platform/stm32/stm32-cec.c
> @@ -291,7 +291,9 @@ static int stm32_cec_probe(struct platform_device *pdev)
>   
>   	cec->clk_cec = devm_clk_get(&pdev->dev, "cec");
>   	if (IS_ERR(cec->clk_cec)) {
> -		dev_err(&pdev->dev, "Cannot get cec clock\n");
> +		if (PTR_ERR(cec->clk_cec) != -EPROBE_DEFER)
> +			dev_err(&pdev->dev, "Cannot get cec clock\n");
> +
>   		return PTR_ERR(cec->clk_cec);
>   	}
>   
>
diff mbox series

Patch

diff --git a/drivers/media/platform/stm32/stm32-cec.c b/drivers/media/platform/stm32/stm32-cec.c
index 8a86b2c..9c137f1 100644
--- a/drivers/media/platform/stm32/stm32-cec.c
+++ b/drivers/media/platform/stm32/stm32-cec.c
@@ -291,7 +291,9 @@  static int stm32_cec_probe(struct platform_device *pdev)
 
 	cec->clk_cec = devm_clk_get(&pdev->dev, "cec");
 	if (IS_ERR(cec->clk_cec)) {
-		dev_err(&pdev->dev, "Cannot get cec clock\n");
+		if (PTR_ERR(cec->clk_cec) != -EPROBE_DEFER)
+			dev_err(&pdev->dev, "Cannot get cec clock\n");
+
 		return PTR_ERR(cec->clk_cec);
 	}