From patchwork Tue Mar 10 11:31:51 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Robin Gong X-Patchwork-Id: 11428385 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 8645C921 for ; Tue, 10 Mar 2020 03:31:46 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 32CFF208E4 for ; Tue, 10 Mar 2020 03:31:46 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="MnK0/4P5"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=nxp.com header.i=@nxp.com header.b="CxEx0t9D" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 32CFF208E4 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=nxp.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=TV+BUCIeOyj3PZIVb7fItyk/qonnD795sLsnMNuNDz8=; b=MnK0/4P5R2fCyx s5hm6IaT0hX4JvcAbpQyhKiDlnGHvuJV+v0vJolHROF7d+ONVbjU4cbADYWVI95+dwOki4X9niiK4 XhiRhGcmFV2NqhVY3NW8S1Fl+UK6+cvmoDsvQQWV//5Q+7J9c+nEEta7uxDkuFseUFgDas/PY10Lx d/tMEa4HRZ8qRyRb2lFjanrohpZmlLXktgYbyZ6+jjaKPFRlI5mPoZjcv7RqENJhWy853iufTvLzj aGhRnVBme5UBXRoyy9qIaSaMiClZwy+ezVYOix8KxitUs7wJxgCC9uO3VnYlm4a/rvj0rMvl8DtW+ jNCccrofuHe9E2ntVQUw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jBVcG-0002Af-3a; Tue, 10 Mar 2020 03:31:36 +0000 Received: from mail-am6eur05on2053.outbound.protection.outlook.com ([40.107.22.53] helo=EUR05-AM6-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jBVbV-0000Fx-8W for linux-arm-kernel@lists.infradead.org; Tue, 10 Mar 2020 03:30:51 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Oi+EhBj5NzRCGsfPZZogz/RLi3vqpLxL6SzObAuamkGUgxKMqKtxlSUb1cpzDANKJDO4ArBVyFldIxmxCPjw0wrP1hP1vkLTDgzqvvCXNCffgfSBBTbLufAQywippBm3TumUZjiIBbFmRiFKC9ZC3qOb6X4ZNEtgWfVWW5R3ogA0a+K3QxrZoDRdzIh5E0DA26oNmtQN52DltUHg0EkLF+KXAJvS6Qt70LUclNlGLPtl6OJq6XaUFODHFIx2+QlvQyJycnq/84Tk3fi6XpPCAFI9Hb1p4rpl9gmmmaNMXXSfZ3GOA0RxTnE1GzrzNUCfcESUPFo+8wYiT3jKF0lu2A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=98+ZGiqA7mJBWYCJHE3+e27bEEc4CJ1c7Ivsg0bvtK4=; b=NTcm3SdpLwNu1v9r6GtRYV6At/U39w+VEfDyEyQFsRDxyytx4qvTFVJMHTkQ6i7zxGoAcwbvJeNYGbz+KIpEphR34Esjqe1zCjMvSS3rn4SgG9Mh3teMkNjG5m2Xxwl6o9QK19u/DraRpHD6BeXRpe8rlvvtVHV/4TmPxMnSkOtinpGrZksF+Qu7umO1TdPw2JheiRXlsAPbX3e2IxTrF7n+0TXZgHChWHSZ14L1+lhRykKxMIMJcpYNpibDLn3Bs96WAuZL7gLRq9VfHA7PrQPZdvgq8/kgATq7iOlVmIWke+t5WZhiW9VXZ2kwTEF/e2LIdzUKWPb2Wpp7IDOAcA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=98+ZGiqA7mJBWYCJHE3+e27bEEc4CJ1c7Ivsg0bvtK4=; b=CxEx0t9DDUxda8KunWyGxVE49IBA6x+6pRSFNKPwccmt0Hdz1LnfdgjiHx2fDBfGn6FXUL05ifCH6BOic/01ExQjAPvKFnIW+1BlR3eunSoWI6asLOT6HVrNmEV9ndhGO9K5+gidpuZhvw6+TnNXhImahB4s+OS0K7pV9pBmGFk= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=yibin.gong@nxp.com; Received: from VE1PR04MB6638.eurprd04.prod.outlook.com (20.179.232.15) by VE1PR04MB6621.eurprd04.prod.outlook.com (20.179.234.213) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2793.17; Tue, 10 Mar 2020 03:30:46 +0000 Received: from VE1PR04MB6638.eurprd04.prod.outlook.com ([fe80::490:6caa:24b:4a31]) by VE1PR04MB6638.eurprd04.prod.outlook.com ([fe80::490:6caa:24b:4a31%6]) with mapi id 15.20.2793.013; Tue, 10 Mar 2020 03:30:46 +0000 From: Robin Gong To: s.hauer@pengutronix.de, vkoul@kernel.org, shawnguo@kernel.org, u.kleine-koenig@pengutronix.de, broonie@kernel.org, robh+dt@kernel.org, festevam@gmail.com, dan.j.williams@intel.com, mark.rutland@arm.com, catalin.marinas@arm.com, will.deacon@arm.com, l.stach@pengutronix.de, martin.fuzzey@flowbird.group Subject: [RESEND v6 02/13] Revert "ARM: dts: imx6: Use correct SDMA script for SPI cores" Date: Tue, 10 Mar 2020 19:31:51 +0800 Message-Id: <1583839922-22699-3-git-send-email-yibin.gong@nxp.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1583839922-22699-1-git-send-email-yibin.gong@nxp.com> References: <1583839922-22699-1-git-send-email-yibin.gong@nxp.com> X-ClientProxiedBy: SG2PR06CA0241.apcprd06.prod.outlook.com (2603:1096:4:ac::25) To VE1PR04MB6638.eurprd04.prod.outlook.com (2603:10a6:803:119::15) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from robin-OptiPlex-790.ap.freescale.net (119.31.174.66) by SG2PR06CA0241.apcprd06.prod.outlook.com (2603:1096:4:ac::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.20.2793.15 via Frontend Transport; Tue, 10 Mar 2020 03:30:41 +0000 X-Mailer: git-send-email 2.7.4 X-Originating-IP: [119.31.174.66] X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: 30fe8fdc-921c-431e-9a7c-08d7c4a36bc2 X-MS-TrafficTypeDiagnostic: VE1PR04MB6621:|VE1PR04MB6621: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:660; X-Forefront-PRVS: 033857D0BD X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(4636009)(136003)(39860400002)(346002)(366004)(376002)(396003)(199004)(189003)(4326008)(8936002)(6666004)(8676002)(81156014)(81166006)(2906002)(5660300002)(2616005)(7416002)(36756003)(66556008)(66946007)(6506007)(52116002)(316002)(956004)(26005)(478600001)(16526019)(186003)(66476007)(86362001)(6486002)(6512007)(921003)(1121003); DIR:OUT; SFP:1101; SCL:1; SRVR:VE1PR04MB6621; H:VE1PR04MB6638.eurprd04.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; Received-SPF: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ywsBdE51bZCpW/+0/Zvx2qRwQiKJ4a6U9lfpijDCn7kaoGYmPX1Mls1w2C7nVpf7DiXCJZQDGCtyRNcrqbRHdR1mOx2/PkunRKi8O4aZo3ZFbm+JYJ8b7QH599UXSbNcGuNB5avohV49I06TKzbeX986TdJ9MhH9nt7UiAJy5dR/OJiBiqdrcBIu06LLWfLdKl4t2uwOCsB508EqQnBt36vA460yX1jSnInU1JQpcSU6S/Z9bZEl0sp8RHu620HrgUAPkkjPrmvzFody9KGUEMiVSl72CT7S3neRHkQeitT0UpjY1A14/bZos9iCBKMcP328PfdXawOeck/kuKWFbFkAstb9j+OCb+iD0dDb53ihVNfJg6gSwnEZjYsuEKsX3uFNTD0xOvD8sSWxgRFsDbW/kOc6zFq634SOmD7p121dzrumG06Q5yV/18ZRvEGaIA0XVuxHu0ih2oqo0B1tOtVptahJ3LGILxq9JdiNhjREu8itEGCSYk3V/HzKejbPhXrDjLc/iJ14VKF6wL3emw9Uq9jo9WvNb0S+Ja4pdgKr0ACQ1dNnDBcAWlfbfA0XtXzSGIaQ22MlH8cLC7qanw== X-MS-Exchange-AntiSpam-MessageData: LCXbIRzOsYpFKIX9SWwMcbVFqADRgGqGUu38izS3iQGZetZhm7WqXU0G/QXzvcpxbH5Qag+zdT7BC5dm/eDEte+iZ1d9pQ5+I3tVpB+Am2PqREOb1VTJ1kQ6YlAn/qUD9UT7xOplSXF/RSQ4ohGvCg== X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 30fe8fdc-921c-431e-9a7c-08d7c4a36bc2 X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Mar 2020 03:30:46.6821 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: QB4KJDvFqgpNU1yQLojGnaOD7MFiY3h7OUTf+CHfIcsTC5OxZQNnBUHdwqtEzVGhj8V7dBukhR5S8Mt0/tOrXw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR04MB6621 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200309_203049_339467_5BB41E9B X-CRM114-Status: GOOD ( 10.29 ) X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.3 on bombadil.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [40.107.22.53 listed in list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record -0.0 SPF_HELO_PASS SPF: HELO matches SPF record 0.0 DATE_IN_FUTURE_06_12 Date: is 6 to 12 hours after Received: date -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.0 MSGID_FROM_MTA_HEADER Message-Id was added by a relay X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org, linux-imx@nxp.com, kernel@pengutronix.de, dmaengine@vger.kernel.org, linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org There are two ways for SDMA accessing SPBA devices: one is SDMA->AIPS ->SPBA(masterA port), another is SDMA->SPBA(masterC port). Please refer to the 'Figure 58-1. i.MX 6Dual/6Quad SPBA connectivity' of i.mx6DQ Reference Manual. SDMA provide the corresponding app_2_mcu/mcu_2_app and shp_2_mcu/mcu_2_shp script for such two options. So both AIPS and SPBA scripts should keep the same behaviour, the issue only caught in AIPS script sounds not solide. The issue is more likely as the ecspi errata ERR009165(http://www.nxp.com/docs/en/errata/IMX6DQCE.pdf): eCSPI: TXFIFO empty flag glitch can cause the current FIFO transfer to be sent twice So revert commit 'dd4b487b32a3' firstly. Signed-off-by: Robin Gong --- arch/arm/boot/dts/imx6qdl.dtsi | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/arch/arm/boot/dts/imx6qdl.dtsi b/arch/arm/boot/dts/imx6qdl.dtsi index 70fb8b5..ff197b5 100644 --- a/arch/arm/boot/dts/imx6qdl.dtsi +++ b/arch/arm/boot/dts/imx6qdl.dtsi @@ -337,7 +337,7 @@ clocks = <&clks IMX6QDL_CLK_ECSPI1>, <&clks IMX6QDL_CLK_ECSPI1>; clock-names = "ipg", "per"; - dmas = <&sdma 3 8 1>, <&sdma 4 8 2>; + dmas = <&sdma 3 7 1>, <&sdma 4 7 2>; dma-names = "rx", "tx"; status = "disabled"; }; @@ -351,7 +351,7 @@ clocks = <&clks IMX6QDL_CLK_ECSPI2>, <&clks IMX6QDL_CLK_ECSPI2>; clock-names = "ipg", "per"; - dmas = <&sdma 5 8 1>, <&sdma 6 8 2>; + dmas = <&sdma 5 7 1>, <&sdma 6 7 2>; dma-names = "rx", "tx"; status = "disabled"; }; @@ -365,7 +365,7 @@ clocks = <&clks IMX6QDL_CLK_ECSPI3>, <&clks IMX6QDL_CLK_ECSPI3>; clock-names = "ipg", "per"; - dmas = <&sdma 7 8 1>, <&sdma 8 8 2>; + dmas = <&sdma 7 7 1>, <&sdma 8 7 2>; dma-names = "rx", "tx"; status = "disabled"; }; @@ -379,7 +379,7 @@ clocks = <&clks IMX6QDL_CLK_ECSPI4>, <&clks IMX6QDL_CLK_ECSPI4>; clock-names = "ipg", "per"; - dmas = <&sdma 9 8 1>, <&sdma 10 8 2>; + dmas = <&sdma 9 7 1>, <&sdma 10 7 2>; dma-names = "rx", "tx"; status = "disabled"; };