| Message ID | 1584061096-23686-7-git-send-email-hayashi.kunihiko@socionext.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Add devicetree features and fixes for UniPhier SoCs | expand |
On Fri, Mar 13, 2020 at 9:58 AM Kunihiko Hayashi <hayashi.kunihiko@socionext.com> wrote: > > Add an aliases property for ethernet to determine device name assignments. There is no call-site of of_alias_get_*() for this device. Why don't you describe the reason correctly? > > Signed-off-by: Kunihiko Hayashi <hayashi.kunihiko@socionext.com> > --- > arch/arm/boot/dts/uniphier-ld6b-ref.dts | 1 + > arch/arm/boot/dts/uniphier-pro4-ace.dts | 1 + > arch/arm/boot/dts/uniphier-pro4-ref.dts | 1 + > arch/arm/boot/dts/uniphier-pro4-sanji.dts | 1 + > arch/arm/boot/dts/uniphier-pxs2-gentil.dts | 1 + > arch/arm/boot/dts/uniphier-pxs2-vodka.dts | 1 + > 6 files changed, 6 insertions(+) > > diff --git a/arch/arm/boot/dts/uniphier-ld6b-ref.dts b/arch/arm/boot/dts/uniphier-ld6b-ref.dts > index 60994b6..079cadc 100644 > --- a/arch/arm/boot/dts/uniphier-ld6b-ref.dts > +++ b/arch/arm/boot/dts/uniphier-ld6b-ref.dts > @@ -29,6 +29,7 @@ > i2c4 = &i2c4; > i2c5 = &i2c5; > i2c6 = &i2c6; > + ethernet0 = ð > }; > > memory@80000000 { > diff --git a/arch/arm/boot/dts/uniphier-pro4-ace.dts b/arch/arm/boot/dts/uniphier-pro4-ace.dts > index 92cc48d..64246fa 100644 > --- a/arch/arm/boot/dts/uniphier-pro4-ace.dts > +++ b/arch/arm/boot/dts/uniphier-pro4-ace.dts > @@ -26,6 +26,7 @@ > i2c3 = &i2c3; > i2c5 = &i2c5; > i2c6 = &i2c6; > + ethernet0 = ð > }; > > memory@80000000 { > diff --git a/arch/arm/boot/dts/uniphier-pro4-ref.dts b/arch/arm/boot/dts/uniphier-pro4-ref.dts > index 854f2eb..181442c 100644 > --- a/arch/arm/boot/dts/uniphier-pro4-ref.dts > +++ b/arch/arm/boot/dts/uniphier-pro4-ref.dts > @@ -29,6 +29,7 @@ > i2c3 = &i2c3; > i2c5 = &i2c5; > i2c6 = &i2c6; > + ethernet0 = ð > }; > > memory@80000000 { > diff --git a/arch/arm/boot/dts/uniphier-pro4-sanji.dts b/arch/arm/boot/dts/uniphier-pro4-sanji.dts > index dda1a2f..5396556 100644 > --- a/arch/arm/boot/dts/uniphier-pro4-sanji.dts > +++ b/arch/arm/boot/dts/uniphier-pro4-sanji.dts > @@ -25,6 +25,7 @@ > i2c3 = &i2c3; > i2c5 = &i2c5; > i2c6 = &i2c6; > + ethernet0 = ð > }; > > memory@80000000 { > diff --git a/arch/arm/boot/dts/uniphier-pxs2-gentil.dts b/arch/arm/boot/dts/uniphier-pxs2-gentil.dts > index e27fd4f..8e9ac57 100644 > --- a/arch/arm/boot/dts/uniphier-pxs2-gentil.dts > +++ b/arch/arm/boot/dts/uniphier-pxs2-gentil.dts > @@ -26,6 +26,7 @@ > i2c4 = &i2c4; > i2c5 = &i2c5; > i2c6 = &i2c6; > + ethernet0 = ð > }; > > memory@80000000 { > diff --git a/arch/arm/boot/dts/uniphier-pxs2-vodka.dts b/arch/arm/boot/dts/uniphier-pxs2-vodka.dts > index 23fe42b..8eacc7b 100644 > --- a/arch/arm/boot/dts/uniphier-pxs2-vodka.dts > +++ b/arch/arm/boot/dts/uniphier-pxs2-vodka.dts > @@ -24,6 +24,7 @@ > i2c4 = &i2c4; > i2c5 = &i2c5; > i2c6 = &i2c6; > + ethernet0 = ð > }; > > memory@80000000 { > -- > 2.7.4 > -- Best Regards Masahiro Yamada
On Mon, 16 Mar 2020 21:31:02 +0900 <masahiroy@kernel.org> wrote: > On Fri, Mar 13, 2020 at 9:58 AM Kunihiko Hayashi > <hayashi.kunihiko@socionext.com> wrote: > > > > Add an aliases property for ethernet to determine device name assignments. > > > There is no call-site of of_alias_get_*() for this device. > > Why don't you describe the reason correctly? I thought that defining aliases automatically assigned the device name, but I found the driver needed to manage the aliases. In case of booting up the kernel from U-boot, the ethernet alias of the devicetree is referred by U-boot, and mac-address in an aliased ethernet node inherits that of U-boot. I'll correctly rewriten the reason next. Thank you, --- Best Regards, Kunihiko Hayashi
diff --git a/arch/arm/boot/dts/uniphier-ld6b-ref.dts b/arch/arm/boot/dts/uniphier-ld6b-ref.dts index 60994b6..079cadc 100644 --- a/arch/arm/boot/dts/uniphier-ld6b-ref.dts +++ b/arch/arm/boot/dts/uniphier-ld6b-ref.dts @@ -29,6 +29,7 @@ i2c4 = &i2c4; i2c5 = &i2c5; i2c6 = &i2c6; + ethernet0 = ð }; memory@80000000 { diff --git a/arch/arm/boot/dts/uniphier-pro4-ace.dts b/arch/arm/boot/dts/uniphier-pro4-ace.dts index 92cc48d..64246fa 100644 --- a/arch/arm/boot/dts/uniphier-pro4-ace.dts +++ b/arch/arm/boot/dts/uniphier-pro4-ace.dts @@ -26,6 +26,7 @@ i2c3 = &i2c3; i2c5 = &i2c5; i2c6 = &i2c6; + ethernet0 = ð }; memory@80000000 { diff --git a/arch/arm/boot/dts/uniphier-pro4-ref.dts b/arch/arm/boot/dts/uniphier-pro4-ref.dts index 854f2eb..181442c 100644 --- a/arch/arm/boot/dts/uniphier-pro4-ref.dts +++ b/arch/arm/boot/dts/uniphier-pro4-ref.dts @@ -29,6 +29,7 @@ i2c3 = &i2c3; i2c5 = &i2c5; i2c6 = &i2c6; + ethernet0 = ð }; memory@80000000 { diff --git a/arch/arm/boot/dts/uniphier-pro4-sanji.dts b/arch/arm/boot/dts/uniphier-pro4-sanji.dts index dda1a2f..5396556 100644 --- a/arch/arm/boot/dts/uniphier-pro4-sanji.dts +++ b/arch/arm/boot/dts/uniphier-pro4-sanji.dts @@ -25,6 +25,7 @@ i2c3 = &i2c3; i2c5 = &i2c5; i2c6 = &i2c6; + ethernet0 = ð }; memory@80000000 { diff --git a/arch/arm/boot/dts/uniphier-pxs2-gentil.dts b/arch/arm/boot/dts/uniphier-pxs2-gentil.dts index e27fd4f..8e9ac57 100644 --- a/arch/arm/boot/dts/uniphier-pxs2-gentil.dts +++ b/arch/arm/boot/dts/uniphier-pxs2-gentil.dts @@ -26,6 +26,7 @@ i2c4 = &i2c4; i2c5 = &i2c5; i2c6 = &i2c6; + ethernet0 = ð }; memory@80000000 { diff --git a/arch/arm/boot/dts/uniphier-pxs2-vodka.dts b/arch/arm/boot/dts/uniphier-pxs2-vodka.dts index 23fe42b..8eacc7b 100644 --- a/arch/arm/boot/dts/uniphier-pxs2-vodka.dts +++ b/arch/arm/boot/dts/uniphier-pxs2-vodka.dts @@ -24,6 +24,7 @@ i2c4 = &i2c4; i2c5 = &i2c5; i2c6 = &i2c6; + ethernet0 = ð }; memory@80000000 {
Add an aliases property for ethernet to determine device name assignments. Signed-off-by: Kunihiko Hayashi <hayashi.kunihiko@socionext.com> --- arch/arm/boot/dts/uniphier-ld6b-ref.dts | 1 + arch/arm/boot/dts/uniphier-pro4-ace.dts | 1 + arch/arm/boot/dts/uniphier-pro4-ref.dts | 1 + arch/arm/boot/dts/uniphier-pro4-sanji.dts | 1 + arch/arm/boot/dts/uniphier-pxs2-gentil.dts | 1 + arch/arm/boot/dts/uniphier-pxs2-vodka.dts | 1 + 6 files changed, 6 insertions(+)