| Message ID | 1590070674-23027-2-git-send-email-yibin.gong@nxp.com (mailing list archive) |
|---|---|
| State | Mainlined |
| Commit | cfb12c8952f617df58d73d24161e539a035d82b0 |
| Headers | show |
| Series | [v2,1/2] arm64: dts: imx8mm-evk: correct ldo1/ldo2 voltage range | expand |
> From: Robin Gong <yibin.gong@nxp.com> > Sent: Thursday, May 21, 2020 10:18 PM > > Correct ldo1 voltage range from wrong high group(3.0v~3.3v) to low group > (1.6v~1.9v) because the ldo1 should be 1.8v. Actually, two voltage groups have > been supported at bd718x7-regulator driver, hence, just corrrect the voltage > range to 1.6v~3.3v. For ldo2@0.8v, correct voltage range too. > Otherwise, ldo1 would be kept @3.0v and ldo2@0.9v which violate i.mx8mn > datasheet as the below warning log in kernel: > > [ 0.995524] LDO1: Bringing 1800000uV into 3000000-3000000uV > [ 0.999196] LDO2: Bringing 800000uV into 900000-900000uV > > Signed-off-by: Robin Gong <yibin.gong@nxp.com> Reviewed-by: Dong Aisheng <aisheng.dong@nxp.com> Regards Aisheng
Hi Robin, On Thu, May 21, 2020 at 3:17 AM Robin Gong <yibin.gong@nxp.com> wrote: > > Correct ldo1 voltage range from wrong high group(3.0v~3.3v) to low group Please use capital letter V for Volt. > (1.6v~1.9v) because the ldo1 should be 1.8v. Actually, two voltage groups > have been supported at bd718x7-regulator driver, hence, just corrrect the > voltage range to 1.6v~3.3v. For ldo2@0.8v, correct voltage range too. > Otherwise, ldo1 would be kept @3.0v and ldo2@0.9v which violate i.mx8mn > datasheet as the below warning log in kernel: > > [ 0.995524] LDO1: Bringing 1800000uV into 3000000-3000000uV > [ 0.999196] LDO2: Bringing 800000uV into 900000-900000uV > > Signed-off-by: Robin Gong <yibin.gong@nxp.com> You should add a Fixes tag and Cc stable on this one. Thanks
On 2020/05/22 Fabio Estevam <festevam@gmail.com> wrote: > Hi Robin, > > On Thu, May 21, 2020 at 3:17 AM Robin Gong <yibin.gong@nxp.com> wrote: > > > > Correct ldo1 voltage range from wrong high group(3.0v~3.3v) to low > > group > > Please use capital letter V for Volt. > > > (1.6v~1.9v) because the ldo1 should be 1.8v. Actually, two voltage > > groups have been supported at bd718x7-regulator driver, hence, just > > corrrect the voltage range to 1.6v~3.3v. For ldo2@0.8v, correct voltage range > too. > > Otherwise, ldo1 would be kept @3.0v and ldo2@0.9v which violate > > i.mx8mn datasheet as the below warning log in kernel: > > > > [ 0.995524] LDO1: Bringing 1800000uV into 3000000-3000000uV > > [ 0.999196] LDO2: Bringing 800000uV into 900000-900000uV > > > > Signed-off-by: Robin Gong <yibin.gong@nxp.com> > > You should add a Fixes tag and Cc stable on this one. Okay, will address your comments in v3, thanks.
diff --git a/arch/arm64/boot/dts/freescale/imx8mn-ddr4-evk.dts b/arch/arm64/boot/dts/freescale/imx8mn-ddr4-evk.dts index d07e0e6..a1e5483 100644 --- a/arch/arm64/boot/dts/freescale/imx8mn-ddr4-evk.dts +++ b/arch/arm64/boot/dts/freescale/imx8mn-ddr4-evk.dts @@ -113,7 +113,7 @@ ldo1_reg: LDO1 { regulator-name = "LDO1"; - regulator-min-microvolt = <3000000>; + regulator-min-microvolt = <1600000>; regulator-max-microvolt = <3300000>; regulator-boot-on; regulator-always-on; @@ -121,7 +121,7 @@ ldo2_reg: LDO2 { regulator-name = "LDO2"; - regulator-min-microvolt = <900000>; + regulator-min-microvolt = <800000>; regulator-max-microvolt = <900000>; regulator-boot-on; regulator-always-on;
Correct ldo1 voltage range from wrong high group(3.0v~3.3v) to low group (1.6v~1.9v) because the ldo1 should be 1.8v. Actually, two voltage groups have been supported at bd718x7-regulator driver, hence, just corrrect the voltage range to 1.6v~3.3v. For ldo2@0.8v, correct voltage range too. Otherwise, ldo1 would be kept @3.0v and ldo2@0.9v which violate i.mx8mn datasheet as the below warning log in kernel: [ 0.995524] LDO1: Bringing 1800000uV into 3000000-3000000uV [ 0.999196] LDO2: Bringing 800000uV into 900000-900000uV Signed-off-by: Robin Gong <yibin.gong@nxp.com> --- arch/arm64/boot/dts/freescale/imx8mn-ddr4-evk.dts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)