| Message ID | 1592362007-7120-1-git-send-email-macpaul.lin@mediatek.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [v2] usb: gadget: u_serial: improve performance for large data | expand |
On Wed, Jun 17, 2020 at 10:46:47AM +0800, Macpaul Lin wrote: > Nowadays some embedded systems use VCOM to transfer large log and data. > Take LTE MODEM as an example, during the long debugging stage, large > log and data were transfer through VCOM when doing field try or in > operator's lab. Here we suggest slightly increase the transfer buffer > in u_serial.c for performance improving. > > Signed-off-by: Macpaul Lin <macpaul.lin@mediatek.com> > --- > drivers/usb/gadget/function/u_serial.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) What changed from v1? Always put that below the --- line as the documentation asks for. v3?
On Wed, 2020-06-17 at 07:14 +0200, Greg Kroah-Hartman wrote: > On Wed, Jun 17, 2020 at 10:46:47AM +0800, Macpaul Lin wrote: > > Nowadays some embedded systems use VCOM to transfer large log and data. > > Take LTE MODEM as an example, during the long debugging stage, large > > log and data were transfer through VCOM when doing field try or in > > operator's lab. Here we suggest slightly increase the transfer buffer > > in u_serial.c for performance improving. > > > > Signed-off-by: Macpaul Lin <macpaul.lin@mediatek.com> > > --- > > drivers/usb/gadget/function/u_serial.c | 5 +++-- > > 1 file changed, 3 insertions(+), 2 deletions(-) > > What changed from v1? Always put that below the --- line as the > documentation asks for. > > v3? Sorry, I just forget to add change log, I'll send v3 later. Thanks! BR, Macpaul Lin
diff --git a/drivers/usb/gadget/function/u_serial.c b/drivers/usb/gadget/function/u_serial.c index 3cfc6e2..d7912a9 100644 --- a/drivers/usb/gadget/function/u_serial.c +++ b/drivers/usb/gadget/function/u_serial.c @@ -80,6 +80,7 @@ #define QUEUE_SIZE 16 #define WRITE_BUF_SIZE 8192 /* TX only */ #define GS_CONSOLE_BUF_SIZE 8192 +#define REQ_BUF_SIZE 4096 /* console info */ struct gs_console { @@ -247,7 +248,7 @@ static int gs_start_tx(struct gs_port *port) break; req = list_entry(pool->next, struct usb_request, list); - len = gs_send_packet(port, req->buf, in->maxpacket); + len = gs_send_packet(port, req->buf, REQ_BUF_SIZE); if (len == 0) { wake_up_interruptible(&port->drain_wait); break; @@ -514,7 +515,7 @@ static int gs_alloc_requests(struct usb_ep *ep, struct list_head *head, * be as speedy as we might otherwise be. */ for (i = 0; i < n; i++) { - req = gs_alloc_req(ep, ep->maxpacket, GFP_ATOMIC); + req = gs_alloc_req(ep, REQ_BUF_SIZE, GFP_ATOMIC); if (!req) return list_empty(head) ? -ENOMEM : 0; req->complete = fn;
Nowadays some embedded systems use VCOM to transfer large log and data. Take LTE MODEM as an example, during the long debugging stage, large log and data were transfer through VCOM when doing field try or in operator's lab. Here we suggest slightly increase the transfer buffer in u_serial.c for performance improving. Signed-off-by: Macpaul Lin <macpaul.lin@mediatek.com> --- drivers/usb/gadget/function/u_serial.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)