From patchwork Fri Jul 24 18:51:17 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Robin Gong X-Patchwork-Id: 11682913 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id C682F912 for ; Fri, 24 Jul 2020 10:40:10 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9C12E20748 for ; Fri, 24 Jul 2020 10:40:10 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="pHMRHev2"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=nxp.com header.i=@nxp.com header.b="ftEdCj7u" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9C12E20748 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=nxp.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=DhSpVICnTqvI371VMLSUJLcvkI8IaLvUspf4dbhc7ZM=; b=pHMRHev2kyA1FQjKe+kaG6L9C 5wBaJB3gWrtt+CqalzJSqTRM9o5DP0uk38gu6rfxIMeIRUQU5ARLeTCb31yYU5KIA05B1puu+vz1z KCjFTugXMnOphIMYqD5MEhdpa052mPNGLWECPbCNiwHcE67p9PSiUNMad32i3AWEeQvugAHszOtJy jFuVCEjI+cGKU/ytX4RR7OODPkFpL1bnzTdLUgfnjD6/lcDU9/8e+XkP0aYMly35MJDJ5Xhy4A2oB /eGaBhcnKbrCYSU9IteQ4L5tybgkpqcM8ylRGaNVaJB0jwJJZVsz0b0YgOs/8XnPmmgrya3Kat8fr fLcMvsupw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jyv5H-0005z1-Ve; Fri, 24 Jul 2020 10:37:48 +0000 Received: from mail-eopbgr80075.outbound.protection.outlook.com ([40.107.8.75] helo=EUR04-VI1-obe.outbound.protection.outlook.com) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jyv55-0005ue-A2 for linux-arm-kernel@lists.infradead.org; Fri, 24 Jul 2020 10:37:36 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GB6jWf5dSlX5Q+I9i9iMRSxBfSTOM3hehfhdcHsQtX1PSP4pDgLqi/bxuJow9auinb3ses77l+VKFNH2VJ1wlueU5a8Z+eRU6J8j+0V2VAMFQWtx/AL65aHV7Sf0qqLhTllVSELx+5khF0NS985dFgdhWryQ+j4hjwRgjlBKrYtzpzbAUdDT8+H7ErwzTFOhvME3IbAcqhQLDn9LLd0oytWUZynD0cnTq9BMJ97kNnJCrVtnbgyG4YUA762taFZuL9rICOy2elyWBVXSEfn0pd2fgziU3CWb6EMdz7VuU0tAD6lVBKccz+CVRjnduyOfaR9tcsaftKPOSHlOcbv9iA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=IN1fRToEmGvcd3mguKJujHggzOr4K2gVkDIrU6mwPNY=; b=NbO+JuOa1/ZPMEdExc3ayL1+TLBkW3nMXWT8gqzNwV2mBsqwQkeogLqhmzuleH3NMIlf8GNW6h+qZK+I27Awiul/fEvh4jVoDjujvQ93ncL41XgakDURg8rUYT0uVW0/imFGyGPje6kEejRF1TRsKpBLL6LxB9sTe98VhWU5t02Q8CrYwYK/2u4NT9T/xJKk+X3xgIr0oERz3fGaPxZD5pXf+rAVjXwUTeoqsZrJkZ9ORxaHmGokYQjgz2nJZ09dAdxdAD8fGXgUlL1yoZ4krNTzlRsZuu78vzf0CIdw7GkpGAAVsnD6L/KFzPD9UOiUQOgD0j4XGV4D15yoAXPoGg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=IN1fRToEmGvcd3mguKJujHggzOr4K2gVkDIrU6mwPNY=; b=ftEdCj7uEd2I1p/eXpinN7idfVX6IfBIi90lFKF7zAFezZEu2b5svheLha3GTZGKXhDvIf3W5+VFXJ92kus8G4BczyIHPdb8/IFynWcDCr6SX5aKlnQg7KsMWlW6Eu35Kw+e72VnRzHOXs+NY13scB3PJF+BT89B6d4q8nqcvzU= Authentication-Results: arm.com; dkim=none (message not signed) header.d=none;arm.com; dmarc=none action=none header.from=nxp.com; Received: from VE1PR04MB6638.eurprd04.prod.outlook.com (2603:10a6:803:119::15) by VI1PR0402MB3710.eurprd04.prod.outlook.com (2603:10a6:803:25::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3216.24; Fri, 24 Jul 2020 10:37:33 +0000 Received: from VE1PR04MB6638.eurprd04.prod.outlook.com ([fe80::5cc4:23a5:ca17:da7d]) by VE1PR04MB6638.eurprd04.prod.outlook.com ([fe80::5cc4:23a5:ca17:da7d%6]) with mapi id 15.20.3195.028; Fri, 24 Jul 2020 10:37:33 +0000 From: Robin Gong To: mark.rutland@arm.com, broonie@kernel.org, robh+dt@kernel.org, catalin.marinas@arm.com, vkoul@kernel.org, will.deacon@arm.com, shawnguo@kernel.org, festevam@gmail.com, s.hauer@pengutronix.de, martin.fuzzey@flowbird.group, u.kleine-koenig@pengutronix.de, dan.j.williams@intel.com, matthias.schiffer@ew.tq-group.com, frieder.schrempf@kontron.de Subject: [PATCH v11 04/12] dmaengine: imx-sdma: remove duplicated sdma_load_context Date: Sat, 25 Jul 2020 02:51:17 +0800 Message-Id: <1595616685-9987-5-git-send-email-yibin.gong@nxp.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1595616685-9987-1-git-send-email-yibin.gong@nxp.com> References: <1595616685-9987-1-git-send-email-yibin.gong@nxp.com> X-ClientProxiedBy: SG2PR02CA0046.apcprd02.prod.outlook.com (2603:1096:3:18::34) To VE1PR04MB6638.eurprd04.prod.outlook.com (2603:10a6:803:119::15) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from robin-OptiPlex-790.ap.freescale.net (119.31.174.67) by SG2PR02CA0046.apcprd02.prod.outlook.com (2603:1096:3:18::34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.20.3216.20 via Frontend Transport; Fri, 24 Jul 2020 10:37:27 +0000 X-Mailer: git-send-email 2.7.4 X-Originating-IP: [119.31.174.67] X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: 98dd6f75-e829-4579-8adc-08d82fbd9283 X-MS-TrafficTypeDiagnostic: VI1PR0402MB3710: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:1923; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 7ppS25ZMcLl7lltffqimFBngXQvu7EZYUqcCWScHq16Qx6ysRBUYETkAPcb6g5VV06rQABTMYfG/DQNnkut3hGhy38iLornrluiKJYzKi9G89V8wTtZnzDQOO89FWJ2fT+jWw0qkkwmKFFpeb3CHnqtH+hoBiwUnw5UyErbalqNvsuc/AdySMIabWV0q3F9ea0sUHs7vrTBmAGq3GrUa5YyiybZn5byY3nYSO56JWReedfLxH+y1Rp+xYkXdJYeQWUgrxFGSebcDxBBg+v/lXvHq3Se0sYapyD4o/2uSv/v5EMjNmCad7yfcYZJRHdi4TpgWHwnUCw1Y6YHl441nV6esiymh7m3BiEKU/uqZ0txi3hRrCojwp0IqvfkcC3D2 X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VE1PR04MB6638.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(376002)(396003)(346002)(39860400002)(366004)(136003)(16526019)(186003)(66476007)(2906002)(8936002)(4744005)(83380400001)(66556008)(478600001)(5660300002)(7416002)(52116002)(6512007)(36756003)(316002)(2616005)(6486002)(8676002)(26005)(6666004)(86362001)(4326008)(66946007)(956004)(6506007)(921003); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData: TsVOVuaTviZl4To/WmmEoI6xDhhPmgFv7vV6ShREi2mSf9hEQAagEBAgdsY/MicBJW1+V3qiOOH9v23uwC21q86gdnh/lHifrLCzgJb9ABJ/jT89fh6XhLcQHoyXl0S0emNiSHoe62N6W3uqU4h9i+CcT1tCe3MBFfFMC44Tnj4aY4IdkkgBHbwSuvhk1cTN+w7VFFVxapnk0FBCs3lOEkX8HVZtSEq2mMNuju7gd10ugBejt/b19Xrh++daZnAFgRNOv7xmgx3td8gdMu+L56QNoe4jkXEJzNoiLi9FLL/g9+6bV2nnrInkqzog2pGgaOs+oaAqr+LqydbrbQ6YUlkwq+5YkihYN1gBogFl1Mea92KUU7T5myzyYHdfmfOvcfa/eeCQsyDyxqL+RzxOo5WyUm8pVangA2c/LjAEP+n3Ikxses7geSKkXS32pnwWA/O23ROTNtC+j8yZpu0+2nfIUb4Y3xcy25R6jJvP0Hk= X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 98dd6f75-e829-4579-8adc-08d82fbd9283 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6638.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Jul 2020 10:37:32.9292 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Sh6doN2ZdREhAr74gMU0UeTsAx/Smlck9IobOCqek+hiE6NwhMG3NYa7HcEv1jyhteSI2elkg1Y/m4QL1wEE3Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0402MB3710 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200724_063735_430582_AF6C38C7 X-CRM114-Status: GOOD ( 10.43 ) X-Spam-Score: -0.9 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.9 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at https://www.dnswl.org/, low trust [40.107.8.75 listed in list.dnswl.org] -0.0 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2) [40.107.8.75 listed in wl.mailspike.net] 0.0 DATE_IN_FUTURE_06_12 Date: is 6 to 12 hours after Received: date -0.0 SPF_HELO_PASS SPF: HELO matches SPF record -0.0 SPF_PASS SPF: sender matches SPF record -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain 0.0 MSGID_FROM_MTA_HEADER Message-Id was added by a relay X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org, linux-imx@nxp.com, kernel@pengutronix.de, dmaengine@vger.kernel.org, linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org Since sdma_transfer_init() will do sdma_load_context before any sdma transfer, no need once more in sdma_config_channel(). Signed-off-by: Robin Gong Acked-by: Vinod Koul --- drivers/dma/imx-sdma.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/dma/imx-sdma.c b/drivers/dma/imx-sdma.c index d305b80..5411e01e 100644 --- a/drivers/dma/imx-sdma.c +++ b/drivers/dma/imx-sdma.c @@ -1137,7 +1137,6 @@ static void sdma_set_watermarklevel_for_p2p(struct sdma_channel *sdmac) static int sdma_config_channel(struct dma_chan *chan) { struct sdma_channel *sdmac = to_sdma_chan(chan); - int ret; sdma_disable_channel(chan); @@ -1177,9 +1176,7 @@ static int sdma_config_channel(struct dma_chan *chan) sdmac->watermark_level = 0; /* FIXME: M3_BASE_ADDRESS */ } - ret = sdma_load_context(sdmac); - - return ret; + return 0; } static int sdma_set_channel_priority(struct sdma_channel *sdmac,