From patchwork Tue Aug 11 15:53:43 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Robin Gong X-Patchwork-Id: 11708759 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 93B6F913 for ; Tue, 11 Aug 2020 07:40:30 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6BA8020838 for ; Tue, 11 Aug 2020 07:40:30 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="s9I+WKr0"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=nxp.com header.i=@nxp.com header.b="gx8nj12T" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6BA8020838 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=nxp.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=DhSpVICnTqvI371VMLSUJLcvkI8IaLvUspf4dbhc7ZM=; b=s9I+WKr01tpSP8O6nThpHTcK3 0+MWYlcggUEKdUZG4jZR1+RzJmSejYAP2P67gzea07BJjkY5Re68qAK3Roa9QDArpp4hFucaQsre8 B7T5pn1dgagPoJS3VIXkFf9Yws/aMX+NYr1jLSiVZlfRhwSgiCMTPMs+2kcnXHHjluwHld58x+IGq ErQ8Fcxkfm2y8ClZBhTfLeVnq75zejvM5hADZWthBUazAWVY31s8VhCHtndEYDG+rUDmjaCdh8LFJ wSKFOyMwLJWCWr6r1y5F4ztajyi3sBRtOt7oKE66ep1qtyLFSrBasD4mC+HefSFAvbtzwcPM9yWoP UstgQVC6Q==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1k5OtN-0005We-K2; Tue, 11 Aug 2020 07:40:17 +0000 Received: from mail-eopbgr130053.outbound.protection.outlook.com ([40.107.13.53] helo=EUR01-HE1-obe.outbound.protection.outlook.com) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1k5OtL-0005Vh-7r for linux-arm-kernel@lists.infradead.org; Tue, 11 Aug 2020 07:40:16 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=PgAGv+BR86JLSG4w4Dha8F5omVMDZ2xyYXAafD6LelkXvTwIVzpIIkCCUAMgQ6LP9Zo4PGOPiPEcGSH6I0/D4/HqC4C7OUMnvY8nYxrAgB6rUCtss8pKf54IC8FSowj7iMIQhumrxeh3RLAUMs5cfQO4UOZeTm8UXAxa5aaU/uM/pDQ/Q39o2sRSj7Ua57bLaUxJMaXK5c4xm/4TKzgj1CqMVdgSNNKTIzWKE1IPVWUB+iHnb4IfDvaQEiH/Z50QEVdySVVPNiRVWe3UtimM54mN+vU6Tp1eQvToPJflgASngBNy0x/it4bOfBhfnjEo5N52L0mXSAlso0TEhR9Bng== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=IN1fRToEmGvcd3mguKJujHggzOr4K2gVkDIrU6mwPNY=; b=glNNGssq8AOkYxRYmMj1s+uQ7hL/dVgRjv0ssMI1sLoYzmlYmvElhldQxFgohl2O6gu83wvNGNCbDxDxmnllNIf+q6FwG9nsxotkxeaoFAXKEURZvXDT+mhkuHt2PzQfjKE1xzREeVYM3vJ06HfEP5dmB4nmuhTR1xOQMsZISJj3JjDy3wGSthcEK27AefA5CMiTZiootOSDH1k1uCNAOlS32Z3MZONSBbDyy54DVfWTrnWZEYz08WPhdZiObVHdqWfBOvZehxvEIaaVdCMo/KeIrBEmI97deGkwMZ1Q5XTzX3EQZfvVAzeZB6IoheSXhI1prr68XPq2V4v/QlikKg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=IN1fRToEmGvcd3mguKJujHggzOr4K2gVkDIrU6mwPNY=; b=gx8nj12TUk72xuqJVzKEPBDsfHECZjBmKVh1ntjHGDJNtlyysBOhgVbT/RoXSD0tcPfIfHuMXU6bkJhB0EVx3vioIyKNEYejh15/xAWAIKgXKesjfJrU9T7ZCgRGyEluxFOMQuB7MqdAHREmalO7JWbxMCG4WWfz0A0vTtdgrlE= Authentication-Results: arm.com; dkim=none (message not signed) header.d=none;arm.com; dmarc=none action=none header.from=nxp.com; Received: from AM6PR04MB6630.eurprd04.prod.outlook.com (2603:10a6:20b:f4::33) by AM6PR0402MB3464.eurprd04.prod.outlook.com (2603:10a6:209:12::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3261.16; Tue, 11 Aug 2020 07:40:11 +0000 Received: from AM6PR04MB6630.eurprd04.prod.outlook.com ([fe80::c9b8:4020:7705:e3dd]) by AM6PR04MB6630.eurprd04.prod.outlook.com ([fe80::c9b8:4020:7705:e3dd%7]) with mapi id 15.20.3261.025; Tue, 11 Aug 2020 07:40:11 +0000 From: Robin Gong To: mark.rutland@arm.com, broonie@kernel.org, robh+dt@kernel.org, catalin.marinas@arm.com, vkoul@kernel.org, will.deacon@arm.com, shawnguo@kernel.org, festevam@gmail.com, s.hauer@pengutronix.de, martin.fuzzey@flowbird.group, u.kleine-koenig@pengutronix.de, dan.j.williams@intel.com, matthias.schiffer@ew.tq-group.com, frieder.schrempf@kontron.de, r.schwebel@pengutronix.de Subject: [PATCH v12 04/12] dmaengine: imx-sdma: remove duplicated sdma_load_context Date: Tue, 11 Aug 2020 23:53:43 +0800 Message-Id: <1597161231-32303-5-git-send-email-yibin.gong@nxp.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1597161231-32303-1-git-send-email-yibin.gong@nxp.com> References: <1597161231-32303-1-git-send-email-yibin.gong@nxp.com> X-ClientProxiedBy: SG2P153CA0014.APCP153.PROD.OUTLOOK.COM (2603:1096::24) To AM6PR04MB6630.eurprd04.prod.outlook.com (2603:10a6:20b:f4::33) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from robin-OptiPlex-790.ap.freescale.net (119.31.174.67) by SG2P153CA0014.APCP153.PROD.OUTLOOK.COM (2603:1096::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.20.3305.2 via Frontend Transport; Tue, 11 Aug 2020 07:40:04 +0000 X-Mailer: git-send-email 2.7.4 X-Originating-IP: [119.31.174.67] X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: 1d04907a-23c8-4539-3a9a-08d83dc9c6c4 X-MS-TrafficTypeDiagnostic: AM6PR0402MB3464: X-LD-Processed: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635,ExtAddr X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:1923; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Id2RyEoHTTDmzhQANEz+Iy/JI4pvtPjBn9RDI8KFw3R0pGnSk9dIPen4yRwkknn9GdqaTomWSZPmajtjsw+4q282p9BjrNnhxCOtzVUoQ9oVo2pYfU4giyBBcXzvMoB/yv39Kolx5OtZhF4h0kqIfPm3X9Iwfy/lyVrIIwR7v6RKM5n/jWeXuZ2xL1Alzd5hBtSKkNsLe7liur4oS4GN3RD9fCNt7hUTRrQIZWKu3bwhRZ7T/YS9U6CyCG9ZXG1Zmjnz+kzlewTjLyEop0mvyu99H+ZJBU3FUTqKtLerqHo3nA20nVc08e0hmsPXsyhh/RR4Kh2qfAwR0R4y/0DlCBVjPOpgD2bb/b9Lv8dPsO6FaFcumVMfvOTIdDjeF5Ad X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AM6PR04MB6630.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(376002)(396003)(136003)(366004)(39860400002)(346002)(4326008)(5660300002)(52116002)(66476007)(66556008)(86362001)(956004)(66946007)(6486002)(2616005)(7416002)(316002)(36756003)(186003)(2906002)(8676002)(6506007)(6666004)(6512007)(8936002)(26005)(478600001)(83380400001)(4744005)(16526019)(921003); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData: Bq1j8zHdILiNv03h+mTYEkmbHK7T9YH5y8A95eFFx3lBD5K2WB2exXJYhQxCmEZcVrRZLhJTJ6ABwfMW2hzYQZ5Fa8bKnGE4NzYYyGSUIo0dD1I1VDU9I8BS9dtoIUAKgsBV07z0dvof2mLd+DKW35yuJYrUWl1T1nTfIIfuna4qIxjNQ8tliMAH71tzHJOUHnGnKM6xqNX7eeo9KfUzx6anaNv7VN+Pu5ALVWXuQXq+f+XKxdcFOkvGFLxhEXREr3vURJsLvJ0/XGGyt7e+W7vBfMi5JpFV56ZS3kXF/6Pk/VdGDlKty5SQUfMje0rJ4fPGiyTbMeS73onwc7+YQHhPFJBQTqyf2ICkl1EYzYOz45gXi8ZmyVQ2wTBkEHvxbFCs0SYKaVBE2dOBbpQZAbNE1bu0bxUbrt724uyAuV5x8FgyC0OD0J4JbMAMsjb/8NuwTG4HubmUNXIAbDN0Bah0GAK5TMhOUHKo4Eva+aAx4edw5FPYic+JFaTQOH8mPgI4yie6Xmf2FyXRU9FgpwmZgy+i0xjGU7kaQa0PVZVMlEnDePzYdaTGk+16m9J+HHRP2612tYJjfJlmldCi7xoX5erN2Ctiur9BvTXAGr9qRQTJsQ3i2CEmB6wj2tPSTD4mbZMYZgjaY7/uIz+xNQ== X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1d04907a-23c8-4539-3a9a-08d83dc9c6c4 X-MS-Exchange-CrossTenant-AuthSource: AM6PR04MB6630.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Aug 2020 07:40:11.2390 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: TSrxAgY2uThdyUnio+zbtcHGpL5TmvAl6YQ3oOGtBnBP0VJSZpozeR51so3q7Y3s1wSqIc3X3VNjslt6BgA4Qw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR0402MB3464 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200811_034015_317132_5C7F1BD7 X-CRM114-Status: GOOD ( 12.43 ) X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [40.107.13.53 listed in list.dnswl.org] -0.0 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2) [40.107.13.53 listed in wl.mailspike.net] 0.0 DATE_IN_FUTURE_06_12 Date: is 6 to 12 hours after Received: date -0.0 SPF_HELO_PASS SPF: HELO matches SPF record -0.0 SPF_PASS SPF: sender matches SPF record -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.0 MSGID_FROM_MTA_HEADER Message-Id was added by a relay X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org, linux-imx@nxp.com, kernel@pengutronix.de, dmaengine@vger.kernel.org, linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org Since sdma_transfer_init() will do sdma_load_context before any sdma transfer, no need once more in sdma_config_channel(). Signed-off-by: Robin Gong Acked-by: Vinod Koul Tested-by: Richard Leitner --- drivers/dma/imx-sdma.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/dma/imx-sdma.c b/drivers/dma/imx-sdma.c index d305b80..5411e01e 100644 --- a/drivers/dma/imx-sdma.c +++ b/drivers/dma/imx-sdma.c @@ -1137,7 +1137,6 @@ static void sdma_set_watermarklevel_for_p2p(struct sdma_channel *sdmac) static int sdma_config_channel(struct dma_chan *chan) { struct sdma_channel *sdmac = to_sdma_chan(chan); - int ret; sdma_disable_channel(chan); @@ -1177,9 +1176,7 @@ static int sdma_config_channel(struct dma_chan *chan) sdmac->watermark_level = 0; /* FIXME: M3_BASE_ADDRESS */ } - ret = sdma_load_context(sdmac); - - return ret; + return 0; } static int sdma_set_channel_priority(struct sdma_channel *sdmac,