| Message ID | 1599059610-7570-2-git-send-email-meenakshi.aggarwal@nxp.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [1/2] dt-bindings: arm64: add compatible for LX2162A QDS Board | expand |
On Wed, Sep 02, 2020 at 08:43:30PM +0530, meenakshi.aggarwal@nxp.com wrote: > From: Meenakshi Aggarwal <meenakshi.aggarwal@nxp.com> > > Add device tree support for LX2162AQDS board. > LX2162A has same die as of LX2160A with different packaging. > > Signed-off-by: Ioana Ciornei <ioana.ciornei@nxp.com> > Signed-off-by: Kuldeep Singh <kuldeep.singh@nxp.com> > Signed-off-by: Meenakshi Aggarwal <meenakshi.aggarwal@nxp.com> > --- > arch/arm64/boot/dts/freescale/Makefile | 1 + > arch/arm64/boot/dts/freescale/fsl-lx2162a-qds.dts | 336 ++++++++++++++++++++++ > 2 files changed, 337 insertions(+) > create mode 100644 arch/arm64/boot/dts/freescale/fsl-lx2162a-qds.dts > > diff --git a/arch/arm64/boot/dts/freescale/Makefile b/arch/arm64/boot/dts/freescale/Makefile > index a39f0a1..ab9fbd3 100644 > --- a/arch/arm64/boot/dts/freescale/Makefile > +++ b/arch/arm64/boot/dts/freescale/Makefile > @@ -27,6 +27,7 @@ dtb-$(CONFIG_ARCH_LAYERSCAPE) += fsl-lx2160a-clearfog-cx.dtb > dtb-$(CONFIG_ARCH_LAYERSCAPE) += fsl-lx2160a-honeycomb.dtb > dtb-$(CONFIG_ARCH_LAYERSCAPE) += fsl-lx2160a-qds.dtb > dtb-$(CONFIG_ARCH_LAYERSCAPE) += fsl-lx2160a-rdb.dtb > +dtb-$(CONFIG_ARCH_LAYERSCAPE) += fsl-lx2162a-qds.dtb > > dtb-$(CONFIG_ARCH_MXC) += imx8mm-evk.dtb > dtb-$(CONFIG_ARCH_MXC) += imx8mn-evk.dtb > diff --git a/arch/arm64/boot/dts/freescale/fsl-lx2162a-qds.dts b/arch/arm64/boot/dts/freescale/fsl-lx2162a-qds.dts > new file mode 100644 > index 0000000..a81c6a4 > --- /dev/null > +++ b/arch/arm64/boot/dts/freescale/fsl-lx2162a-qds.dts > @@ -0,0 +1,336 @@ > +// SPDX-License-Identifier: (GPL-2.0 OR MIT) > +// > +// Device Tree file for LX2162AQDS > +// > +// Copyright 2020 NXP > + > +/dts-v1/; > + > +#include "fsl-lx2160a.dtsi" > + > +/ { > + model = "NXP Layerscape LX2162AQDS"; > + compatible = "nxp,lx2162a-qds", "fsl,lx2160a"; > + > + aliases { > + crypto = &crypto; > + serial0 = &uart0; > + }; > + > + chosen { > + stdout-path = "serial0:115200n8"; > + }; > + > + sb_3v3: regulator-sb3v3 { > + compatible = "regulator-fixed"; > + regulator-name = "MC34717-3.3VSB"; > + regulator-min-microvolt = <3300000>; > + regulator-max-microvolt = <3300000>; > + regulator-boot-on; > + regulator-always-on; I do not see any point to have regulator-boot-on or regulator-always-on for a regulator that doesn't have on/off control. > + }; > + > + mdio-mux-1 { > + compatible = "mdio-mux-multiplexer"; > + mux-controls = <&mux 0>; > + mdio-parent-bus = <&emdio1>; > + #address-cells=<1>; > + #size-cells = <0>; > + > + mdio@0 { /* On-board RTL8211F PHY #1 RGMII1*/ > + reg = <0x00>; > + #address-cells = <1>; > + #size-cells = <0>; > + > + rgmii_phy1: ethernet-phy@1 { > + compatible = "ethernet-phy-id001c.c916"; > + reg = <0x1>; > + eee-broken-1000t; > + }; > + }; > + > + mdio@8 { /* On-board RTL8211F PHY #2 RGMII2*/ Missing one space before closing comment. Shawn > + reg = <0x8>; > + #address-cells = <1>; > + #size-cells = <0>; > + > + rgmii_phy2: ethernet-phy@2 { > + compatible = "ethernet-phy-id001c.c916"; > + reg = <0x2>; > + eee-broken-1000t; > + }; > + }; > + > + mdio@18 { /* Slot #1 */ > + reg = <0x18>; > + #address-cells = <1>; > + #size-cells = <0>; > + }; > + > + mdio@19 { /* Slot #2 */ > + reg = <0x19>; > + #address-cells = <1>; > + #size-cells = <0>; > + }; > + > + mdio@1a { /* Slot #3 */ > + reg = <0x1a>; > + #address-cells = <1>; > + #size-cells = <0>; > + }; > + > + mdio@1b { /* Slot #4 */ > + reg = <0x1b>; > + #address-cells = <1>; > + #size-cells = <0>; > + }; > + > + mdio@1c { /* Slot #5 */ > + reg = <0x1c>; > + #address-cells = <1>; > + #size-cells = <0>; > + }; > + > + mdio@1d { /* Slot #6 */ > + reg = <0x1d>; > + #address-cells = <1>; > + #size-cells = <0>; > + }; > + > + mdio@1e { /* Slot #7 */ > + reg = <0x1e>; > + #address-cells = <1>; > + #size-cells = <0>; > + }; > + > + mdio@1f { /* Slot #8 */ > + reg = <0x1f>; > + #address-cells = <1>; > + #size-cells = <0>; > + }; > + }; > + > + mdio-mux-2 { > + compatible = "mdio-mux-multiplexer"; > + mux-controls = <&mux 1>; > + mdio-parent-bus = <&emdio2>; > + #address-cells=<1>; > + #size-cells = <0>; > + > + mdio@0 { /* Slot #1 (secondary EMI) */ > + reg = <0x00>; > + #address-cells = <1>; > + #size-cells = <0>; > + }; > + > + mdio@1 { /* Slot #2 (secondary EMI) */ > + reg = <0x01>; > + #address-cells = <1>; > + #size-cells = <0>; > + }; > + > + mdio@2 { /* Slot #3 (secondary EMI) */ > + reg = <0x02>; > + #address-cells = <1>; > + #size-cells = <0>; > + }; > + > + mdio@3 { /* Slot #4 (secondary EMI) */ > + reg = <0x03>; > + #address-cells = <1>; > + #size-cells = <0>; > + }; > + > + mdio@4 { /* Slot #5 (secondary EMI) */ > + reg = <0x04>; > + #address-cells = <1>; > + #size-cells = <0>; > + }; > + > + mdio@5 { /* Slot #6 (secondary EMI) */ > + reg = <0x05>; > + #address-cells = <1>; > + #size-cells = <0>; > + }; > + > + mdio@6 { /* Slot #7 (secondary EMI) */ > + reg = <0x06>; > + #address-cells = <1>; > + #size-cells = <0>; > + }; > + > + mdio@7 { /* Slot #8 (secondary EMI) */ > + reg = <0x07>; > + #address-cells = <1>; > + #size-cells = <0>; > + }; > + }; > +}; > + > +&crypto { > + status = "okay"; > +}; > + > +&dpmac17 { > + phy-handle = <&rgmii_phy1>; > + phy-connection-type = "rgmii-id"; > +}; > + > +&dpmac18 { > + phy-handle = <&rgmii_phy2>; > + phy-connection-type = "rgmii-id"; > +}; > + > +&dspi0 { > + status = "okay"; > + > + dflash0: flash@0 { > + #address-cells = <1>; > + #size-cells = <1>; > + compatible = "jedec,spi-nor"; > + reg = <0>; > + spi-max-frequency = <1000000>; > + }; > +}; > + > +&dspi1 { > + status = "okay"; > + > + dflash1: flash@0 { > + #address-cells = <1>; > + #size-cells = <1>; > + compatible = "jedec,spi-nor"; > + reg = <0>; > + spi-max-frequency = <1000000>; > + }; > +}; > + > +&dspi2 { > + status = "okay"; > + > + dflash2: flash@0 { > + #address-cells = <1>; > + #size-cells = <1>; > + compatible = "jedec,spi-nor"; > + reg = <0>; > + spi-max-frequency = <1000000>; > + }; > +}; > + > +&emdio1 { > + status = "okay"; > +}; > + > +&emdio2 { > + status = "okay"; > +}; > + > +&esdhc0 { > + status = "okay"; > +}; > + > +&esdhc1 { > + status = "okay"; > +}; > + > +&fspi { > + status = "okay"; > + > + mt35xu512aba0: flash@0 { > + #address-cells = <1>; > + #size-cells = <1>; > + compatible = "jedec,spi-nor"; > + m25p,fast-read; > + spi-max-frequency = <50000000>; > + reg = <0>; > + spi-rx-bus-width = <8>; > + spi-tx-bus-width = <8>; > + }; > +}; > + > +&i2c0 { > + status = "okay"; > + > + fpga@66 { > + compatible = "fsl,lx2160aqds-fpga", "fsl,fpga-qixis-i2c", > + "simple-mfd"; > + reg = <0x66>; > + > + mux: mux-controller { > + compatible = "reg-mux"; > + #mux-control-cells = <1>; > + mux-reg-masks = <0x54 0xf8>, /* 0: reg 0x54, bits 7:3 */ > + <0x54 0x07>; /* 1: reg 0x54, bit 2:0 */ > + }; > + }; > + > + i2c-mux@77 { > + compatible = "nxp,pca9547"; > + reg = <0x77>; > + #address-cells = <1>; > + #size-cells = <0>; > + > + i2c@2 { > + #address-cells = <1>; > + #size-cells = <0>; > + reg = <0x2>; > + > + power-monitor@40 { > + compatible = "ti,ina220"; > + reg = <0x40>; > + shunt-resistor = <500>; > + }; > + > + power-monitor@41 { > + compatible = "ti,ina220"; > + reg = <0x41>; > + shunt-resistor = <1000>; > + }; > + }; > + > + i2c@3 { > + #address-cells = <1>; > + #size-cells = <0>; > + reg = <0x3>; > + > + temperature-sensor@4c { > + compatible = "nxp,sa56004"; > + reg = <0x4c>; > + vcc-supply = <&sb_3v3>; > + }; > + > + rtc@51 { > + compatible = "nxp,pcf2129"; > + reg = <0x51>; > + }; > + }; > + }; > +}; > + > +&sata0 { > + status = "okay"; > +}; > + > +&sata1 { > + status = "okay"; > +}; > + > +&sata2 { > + status = "okay"; > +}; > + > +&sata3 { > + status = "okay"; > +}; > + > +&uart0 { > + status = "okay"; > +}; > + > +&uart1 { > + status = "okay"; > +}; > + > +&usb0 { > + status = "okay"; > +}; > -- > 2.7.4 >
> -----Original Message----- > From: Shawn Guo <shawnguo@kernel.org> > Sent: Saturday, September 5, 2020 1:24 PM > To: Meenakshi Aggarwal <meenakshi.aggarwal@nxp.com> > Cc: robh+dt@kernel.org; Varun Sethi <V.Sethi@nxp.com>; Leo Li > <leoyang.li@nxp.com>; linux-arm-kernel@lists.infradead.org; > devicetree@vger.kernel.org; linux-kernel@vger.kernel.org; Ioana Ciornei > <ioana.ciornei@nxp.com>; Kuldeep Singh <kuldeep.singh@nxp.com> > Subject: Re: [PATCH 2/2] arm64: dts: lx2160a: add device tree for lx2162aqds > board > > On Wed, Sep 02, 2020 at 08:43:30PM +0530, meenakshi.aggarwal@nxp.com > wrote: > > From: Meenakshi Aggarwal <meenakshi.aggarwal@nxp.com> > > > > Add device tree support for LX2162AQDS board. > > LX2162A has same die as of LX2160A with different packaging. > > > > Signed-off-by: Ioana Ciornei <ioana.ciornei@nxp.com> > > Signed-off-by: Kuldeep Singh <kuldeep.singh@nxp.com> > > Signed-off-by: Meenakshi Aggarwal <meenakshi.aggarwal@nxp.com> > > --- > > arch/arm64/boot/dts/freescale/Makefile | 1 + > > arch/arm64/boot/dts/freescale/fsl-lx2162a-qds.dts | 336 > > ++++++++++++++++++++++ > > 2 files changed, 337 insertions(+) > > create mode 100644 arch/arm64/boot/dts/freescale/fsl-lx2162a-qds.dts > > > > diff --git a/arch/arm64/boot/dts/freescale/Makefile > > b/arch/arm64/boot/dts/freescale/Makefile > > index a39f0a1..ab9fbd3 100644 > > --- a/arch/arm64/boot/dts/freescale/Makefile > > +++ b/arch/arm64/boot/dts/freescale/Makefile > > @@ -27,6 +27,7 @@ dtb-$(CONFIG_ARCH_LAYERSCAPE) += > > fsl-lx2160a-clearfog-cx.dtb > > dtb-$(CONFIG_ARCH_LAYERSCAPE) += fsl-lx2160a-honeycomb.dtb > > dtb-$(CONFIG_ARCH_LAYERSCAPE) += fsl-lx2160a-qds.dtb > > dtb-$(CONFIG_ARCH_LAYERSCAPE) += fsl-lx2160a-rdb.dtb > > +dtb-$(CONFIG_ARCH_LAYERSCAPE) += fsl-lx2162a-qds.dtb > > > > dtb-$(CONFIG_ARCH_MXC) += imx8mm-evk.dtb > > dtb-$(CONFIG_ARCH_MXC) += imx8mn-evk.dtb diff --git > > a/arch/arm64/boot/dts/freescale/fsl-lx2162a-qds.dts > > b/arch/arm64/boot/dts/freescale/fsl-lx2162a-qds.dts > > new file mode 100644 > > index 0000000..a81c6a4 > > --- /dev/null > > +++ b/arch/arm64/boot/dts/freescale/fsl-lx2162a-qds.dts > > @@ -0,0 +1,336 @@ > > +// SPDX-License-Identifier: (GPL-2.0 OR MIT) // // Device Tree file > > +for LX2162AQDS // // Copyright 2020 NXP > > + > > +/dts-v1/; > > + > > +#include "fsl-lx2160a.dtsi" > > + > > +/ { > > + model = "NXP Layerscape LX2162AQDS"; > > + compatible = "nxp,lx2162a-qds", "fsl,lx2160a"; > > + > > + aliases { > > + crypto = &crypto; > > + serial0 = &uart0; > > + }; > > + > > + chosen { > > + stdout-path = "serial0:115200n8"; > > + }; > > + > > + sb_3v3: regulator-sb3v3 { > > + compatible = "regulator-fixed"; > > + regulator-name = "MC34717-3.3VSB"; > > + regulator-min-microvolt = <3300000>; > > + regulator-max-microvolt = <3300000>; > > + regulator-boot-on; > > + regulator-always-on; > > I do not see any point to have regulator-boot-on or regulator-always-on for a > regulator that doesn't have on/off control. [Meenakshi Aggarwal] Properties are added to specify that platform firmware's out of reset configuration enabled the regulator and regulator should never be disabled or change its operative status. Can you help in understanding why these optional properties cannot be used together > > > + }; > > + > > + mdio-mux-1 { > > + compatible = "mdio-mux-multiplexer"; > > + mux-controls = <&mux 0>; > > + mdio-parent-bus = <&emdio1>; > > + #address-cells=<1>; > > + #size-cells = <0>; > > + > > + mdio@0 { /* On-board RTL8211F PHY #1 RGMII1*/ > > + reg = <0x00>; > > + #address-cells = <1>; > > + #size-cells = <0>; > > + > > + rgmii_phy1: ethernet-phy@1 { > > + compatible = "ethernet-phy-id001c.c916"; > > + reg = <0x1>; > > + eee-broken-1000t; > > + }; > > + }; > > + > > + mdio@8 { /* On-board RTL8211F PHY #2 RGMII2*/ > > Missing one space before closing comment. [Meenakshi Aggarwal] will correct in next version > > Shawn > > > + reg = <0x8>; > > + #address-cells = <1>; > > + #size-cells = <0>; > > + > > + rgmii_phy2: ethernet-phy@2 { > > + compatible = "ethernet-phy-id001c.c916"; > > + reg = <0x2>; > > + eee-broken-1000t; > > + }; > > + }; > > + > > + mdio@18 { /* Slot #1 */ > > + reg = <0x18>; > > + #address-cells = <1>; > > + #size-cells = <0>; > > + }; > > + > > + mdio@19 { /* Slot #2 */ > > + reg = <0x19>; > > + #address-cells = <1>; > > + #size-cells = <0>; > > + }; > > + > > + mdio@1a { /* Slot #3 */ > > + reg = <0x1a>; > > + #address-cells = <1>; > > + #size-cells = <0>; > > + }; > > + > > + mdio@1b { /* Slot #4 */ > > + reg = <0x1b>; > > + #address-cells = <1>; > > + #size-cells = <0>; > > + }; > > + > > + mdio@1c { /* Slot #5 */ > > + reg = <0x1c>; > > + #address-cells = <1>; > > + #size-cells = <0>; > > + }; > > + > > + mdio@1d { /* Slot #6 */ > > + reg = <0x1d>; > > + #address-cells = <1>; > > + #size-cells = <0>; > > + }; > > + > > + mdio@1e { /* Slot #7 */ > > + reg = <0x1e>; > > + #address-cells = <1>; > > + #size-cells = <0>; > > + }; > > + > > + mdio@1f { /* Slot #8 */ > > + reg = <0x1f>; > > + #address-cells = <1>; > > + #size-cells = <0>; > > + }; > > + }; > > + > > + mdio-mux-2 { > > + compatible = "mdio-mux-multiplexer"; > > + mux-controls = <&mux 1>; > > + mdio-parent-bus = <&emdio2>; > > + #address-cells=<1>; > > + #size-cells = <0>; > > + > > + mdio@0 { /* Slot #1 (secondary EMI) */ > > + reg = <0x00>; > > + #address-cells = <1>; > > + #size-cells = <0>; > > + }; > > + > > + mdio@1 { /* Slot #2 (secondary EMI) */ > > + reg = <0x01>; > > + #address-cells = <1>; > > + #size-cells = <0>; > > + }; > > + > > + mdio@2 { /* Slot #3 (secondary EMI) */ > > + reg = <0x02>; > > + #address-cells = <1>; > > + #size-cells = <0>; > > + }; > > + > > + mdio@3 { /* Slot #4 (secondary EMI) */ > > + reg = <0x03>; > > + #address-cells = <1>; > > + #size-cells = <0>; > > + }; > > + > > + mdio@4 { /* Slot #5 (secondary EMI) */ > > + reg = <0x04>; > > + #address-cells = <1>; > > + #size-cells = <0>; > > + }; > > + > > + mdio@5 { /* Slot #6 (secondary EMI) */ > > + reg = <0x05>; > > + #address-cells = <1>; > > + #size-cells = <0>; > > + }; > > + > > + mdio@6 { /* Slot #7 (secondary EMI) */ > > + reg = <0x06>; > > + #address-cells = <1>; > > + #size-cells = <0>; > > + }; > > + > > + mdio@7 { /* Slot #8 (secondary EMI) */ > > + reg = <0x07>; > > + #address-cells = <1>; > > + #size-cells = <0>; > > + }; > > + }; > > +}; > > + > > +&crypto { > > + status = "okay"; > > +}; > > + > > +&dpmac17 { > > + phy-handle = <&rgmii_phy1>; > > + phy-connection-type = "rgmii-id"; > > +}; > > + > > +&dpmac18 { > > + phy-handle = <&rgmii_phy2>; > > + phy-connection-type = "rgmii-id"; > > +}; > > + > > +&dspi0 { > > + status = "okay"; > > + > > + dflash0: flash@0 { > > + #address-cells = <1>; > > + #size-cells = <1>; > > + compatible = "jedec,spi-nor"; > > + reg = <0>; > > + spi-max-frequency = <1000000>; > > + }; > > +}; > > + > > +&dspi1 { > > + status = "okay"; > > + > > + dflash1: flash@0 { > > + #address-cells = <1>; > > + #size-cells = <1>; > > + compatible = "jedec,spi-nor"; > > + reg = <0>; > > + spi-max-frequency = <1000000>; > > + }; > > +}; > > + > > +&dspi2 { > > + status = "okay"; > > + > > + dflash2: flash@0 { > > + #address-cells = <1>; > > + #size-cells = <1>; > > + compatible = "jedec,spi-nor"; > > + reg = <0>; > > + spi-max-frequency = <1000000>; > > + }; > > +}; > > + > > +&emdio1 { > > + status = "okay"; > > +}; > > + > > +&emdio2 { > > + status = "okay"; > > +}; > > + > > +&esdhc0 { > > + status = "okay"; > > +}; > > + > > +&esdhc1 { > > + status = "okay"; > > +}; > > + > > +&fspi { > > + status = "okay"; > > + > > + mt35xu512aba0: flash@0 { > > + #address-cells = <1>; > > + #size-cells = <1>; > > + compatible = "jedec,spi-nor"; > > + m25p,fast-read; > > + spi-max-frequency = <50000000>; > > + reg = <0>; > > + spi-rx-bus-width = <8>; > > + spi-tx-bus-width = <8>; > > + }; > > +}; > > + > > +&i2c0 { > > + status = "okay"; > > + > > + fpga@66 { > > + compatible = "fsl,lx2160aqds-fpga", "fsl,fpga-qixis-i2c", > > + "simple-mfd"; > > + reg = <0x66>; > > + > > + mux: mux-controller { > > + compatible = "reg-mux"; > > + #mux-control-cells = <1>; > > + mux-reg-masks = <0x54 0xf8>, /* 0: reg 0x54, bits 7:3 > */ > > + <0x54 0x07>; /* 1: reg 0x54, bit 2:0 */ > > + }; > > + }; > > + > > + i2c-mux@77 { > > + compatible = "nxp,pca9547"; > > + reg = <0x77>; > > + #address-cells = <1>; > > + #size-cells = <0>; > > + > > + i2c@2 { > > + #address-cells = <1>; > > + #size-cells = <0>; > > + reg = <0x2>; > > + > > + power-monitor@40 { > > + compatible = "ti,ina220"; > > + reg = <0x40>; > > + shunt-resistor = <500>; > > + }; > > + > > + power-monitor@41 { > > + compatible = "ti,ina220"; > > + reg = <0x41>; > > + shunt-resistor = <1000>; > > + }; > > + }; > > + > > + i2c@3 { > > + #address-cells = <1>; > > + #size-cells = <0>; > > + reg = <0x3>; > > + > > + temperature-sensor@4c { > > + compatible = "nxp,sa56004"; > > + reg = <0x4c>; > > + vcc-supply = <&sb_3v3>; > > + }; > > + > > + rtc@51 { > > + compatible = "nxp,pcf2129"; > > + reg = <0x51>; > > + }; > > + }; > > + }; > > +}; > > + > > +&sata0 { > > + status = "okay"; > > +}; > > + > > +&sata1 { > > + status = "okay"; > > +}; > > + > > +&sata2 { > > + status = "okay"; > > +}; > > + > > +&sata3 { > > + status = "okay"; > > +}; > > + > > +&uart0 { > > + status = "okay"; > > +}; > > + > > +&uart1 { > > + status = "okay"; > > +}; > > + > > +&usb0 { > > + status = "okay"; > > +}; > > -- > > 2.7.4 > >
On Wed, Sep 09, 2020 at 07:10:12AM +0000, Meenakshi Aggarwal wrote: > > > + sb_3v3: regulator-sb3v3 { > > > + compatible = "regulator-fixed"; > > > + regulator-name = "MC34717-3.3VSB"; > > > + regulator-min-microvolt = <3300000>; > > > + regulator-max-microvolt = <3300000>; > > > + regulator-boot-on; > > > + regulator-always-on; > > > > I do not see any point to have regulator-boot-on or regulator-always-on for a > > regulator that doesn't have on/off control. > [Meenakshi Aggarwal] Properties are added to specify that platform firmware's out of reset configuration enabled the regulator and > regulator should never be disabled or change its operative status. What I was wondering if how this regulator is enabled by firmware, by some GPIO control? In that case, 'gpio' property should be there to describe the GPIO control. > > Can you help in understanding why these optional properties cannot be used together It's totally fine to use these properties together. But if the regulator doesn't have on/off control, neither of them makes sense. Shawn
> -----Original Message----- > From: Shawn Guo <shawnguo@kernel.org> > Sent: Saturday, September 12, 2020 3:19 PM > To: Meenakshi Aggarwal <meenakshi.aggarwal@nxp.com> > Cc: robh+dt@kernel.org; Varun Sethi <V.Sethi@nxp.com>; Leo Li > <leoyang.li@nxp.com>; linux-arm-kernel@lists.infradead.org; > devicetree@vger.kernel.org; linux-kernel@vger.kernel.org; Ioana Ciornei > <ioana.ciornei@nxp.com>; Kuldeep Singh <kuldeep.singh@nxp.com> > Subject: Re: [PATCH 2/2] arm64: dts: lx2160a: add device tree for lx2162aqds > board > > On Wed, Sep 09, 2020 at 07:10:12AM +0000, Meenakshi Aggarwal wrote: > > > > + sb_3v3: regulator-sb3v3 { > > > > + compatible = "regulator-fixed"; > > > > + regulator-name = "MC34717-3.3VSB"; > > > > + regulator-min-microvolt = <3300000>; > > > > + regulator-max-microvolt = <3300000>; > > > > + regulator-boot-on; > > > > + regulator-always-on; > > > > > > I do not see any point to have regulator-boot-on or > > > regulator-always-on for a regulator that doesn't have on/off control. > > [Meenakshi Aggarwal] Properties are added to specify that platform > > firmware's out of reset configuration enabled the regulator and regulator > should never be disabled or change its operative status. > > What I was wondering if how this regulator is enabled by firmware, by some > GPIO control? In that case, 'gpio' property should be there to describe the GPIO > control. > [Meenakshi Aggarwal] Its not controlled by GPIO. Its gets power on with board. > > > > Can you help in understanding why these optional properties cannot be > > used together > > It's totally fine to use these properties together. But if the regulator doesn't > have on/off control, neither of them makes sense. [Meenakshi Aggarwal] As per documentation, we should keep " regulator-always-on " as per description, we Can remove " regulator-boot-on" property from dts. regulator-always-on: description: boolean, regulator should never be disabled . > > Shawn
On Mon, Sep 21, 2020 at 06:00:53AM +0000, Meenakshi Aggarwal wrote: > > > > -----Original Message----- > > From: Shawn Guo <shawnguo@kernel.org> > > Sent: Saturday, September 12, 2020 3:19 PM > > To: Meenakshi Aggarwal <meenakshi.aggarwal@nxp.com> > > Cc: robh+dt@kernel.org; Varun Sethi <V.Sethi@nxp.com>; Leo Li > > <leoyang.li@nxp.com>; linux-arm-kernel@lists.infradead.org; > > devicetree@vger.kernel.org; linux-kernel@vger.kernel.org; Ioana Ciornei > > <ioana.ciornei@nxp.com>; Kuldeep Singh <kuldeep.singh@nxp.com> > > Subject: Re: [PATCH 2/2] arm64: dts: lx2160a: add device tree for lx2162aqds > > board > > > > On Wed, Sep 09, 2020 at 07:10:12AM +0000, Meenakshi Aggarwal wrote: > > > > > + sb_3v3: regulator-sb3v3 { > > > > > + compatible = "regulator-fixed"; > > > > > + regulator-name = "MC34717-3.3VSB"; > > > > > + regulator-min-microvolt = <3300000>; > > > > > + regulator-max-microvolt = <3300000>; > > > > > + regulator-boot-on; > > > > > + regulator-always-on; > > > > > > > > I do not see any point to have regulator-boot-on or > > > > regulator-always-on for a regulator that doesn't have on/off control. > > > [Meenakshi Aggarwal] Properties are added to specify that platform > > > firmware's out of reset configuration enabled the regulator and regulator > > should never be disabled or change its operative status. > > > > What I was wondering if how this regulator is enabled by firmware, by some > > GPIO control? In that case, 'gpio' property should be there to describe the GPIO > > control. > > > [Meenakshi Aggarwal] Its not controlled by GPIO. Its gets power on with board. > > > > > > Can you help in understanding why these optional properties cannot be > > > used together > > > > It's totally fine to use these properties together. But if the regulator doesn't > > have on/off control, neither of them makes sense. > [Meenakshi Aggarwal] As per documentation, we should keep " regulator-always-on " as per description, we > Can remove " regulator-boot-on" property from dts. > > regulator-always-on: > description: boolean, regulator should never be disabled Again, the property is only meaningful for a regulator that can possibly be disabled. Shawn
Ok, I will update the dts with your suggestions. Thanks, Meenakshi > -----Original Message----- > From: Shawn Guo <shawnguo@kernel.org> > Sent: Monday, September 21, 2020 6:33 PM > To: Meenakshi Aggarwal <meenakshi.aggarwal@nxp.com> > Cc: robh+dt@kernel.org; Varun Sethi <V.Sethi@nxp.com>; Leo Li > <leoyang.li@nxp.com>; linux-arm-kernel@lists.infradead.org; > devicetree@vger.kernel.org; linux-kernel@vger.kernel.org; Ioana Ciornei > <ioana.ciornei@nxp.com>; Kuldeep Singh <kuldeep.singh@nxp.com> > Subject: Re: [PATCH 2/2] arm64: dts: lx2160a: add device tree for lx2162aqds > board > > On Mon, Sep 21, 2020 at 06:00:53AM +0000, Meenakshi Aggarwal wrote: > > > > > > > -----Original Message----- > > > From: Shawn Guo <shawnguo@kernel.org> > > > Sent: Saturday, September 12, 2020 3:19 PM > > > To: Meenakshi Aggarwal <meenakshi.aggarwal@nxp.com> > > > Cc: robh+dt@kernel.org; Varun Sethi <V.Sethi@nxp.com>; Leo Li > > > <leoyang.li@nxp.com>; linux-arm-kernel@lists.infradead.org; > > > devicetree@vger.kernel.org; linux-kernel@vger.kernel.org; Ioana > > > Ciornei <ioana.ciornei@nxp.com>; Kuldeep Singh > > > <kuldeep.singh@nxp.com> > > > Subject: Re: [PATCH 2/2] arm64: dts: lx2160a: add device tree for > > > lx2162aqds board > > > > > > On Wed, Sep 09, 2020 at 07:10:12AM +0000, Meenakshi Aggarwal wrote: > > > > > > + sb_3v3: regulator-sb3v3 { > > > > > > + compatible = "regulator-fixed"; > > > > > > + regulator-name = "MC34717-3.3VSB"; > > > > > > + regulator-min-microvolt = <3300000>; > > > > > > + regulator-max-microvolt = <3300000>; > > > > > > + regulator-boot-on; > > > > > > + regulator-always-on; > > > > > > > > > > I do not see any point to have regulator-boot-on or > > > > > regulator-always-on for a regulator that doesn't have on/off control. > > > > [Meenakshi Aggarwal] Properties are added to specify that platform > > > > firmware's out of reset configuration enabled the regulator and > > > > regulator > > > should never be disabled or change its operative status. > > > > > > What I was wondering if how this regulator is enabled by firmware, > > > by some GPIO control? In that case, 'gpio' property should be there > > > to describe the GPIO control. > > > > > [Meenakshi Aggarwal] Its not controlled by GPIO. Its gets power on with board. > > > > > > > > Can you help in understanding why these optional properties cannot > > > > be used together > > > > > > It's totally fine to use these properties together. But if the > > > regulator doesn't have on/off control, neither of them makes sense. > > [Meenakshi Aggarwal] As per documentation, we should keep " > > regulator-always-on " as per description, we Can remove " regulator-boot-on" > property from dts. > > > > regulator-always-on: > > description: boolean, regulator should never be disabled > > Again, the property is only meaningful for a regulator that can possibly be > disabled. > > Shawn
diff --git a/arch/arm64/boot/dts/freescale/Makefile b/arch/arm64/boot/dts/freescale/Makefile index a39f0a1..ab9fbd3 100644 --- a/arch/arm64/boot/dts/freescale/Makefile +++ b/arch/arm64/boot/dts/freescale/Makefile @@ -27,6 +27,7 @@ dtb-$(CONFIG_ARCH_LAYERSCAPE) += fsl-lx2160a-clearfog-cx.dtb dtb-$(CONFIG_ARCH_LAYERSCAPE) += fsl-lx2160a-honeycomb.dtb dtb-$(CONFIG_ARCH_LAYERSCAPE) += fsl-lx2160a-qds.dtb dtb-$(CONFIG_ARCH_LAYERSCAPE) += fsl-lx2160a-rdb.dtb +dtb-$(CONFIG_ARCH_LAYERSCAPE) += fsl-lx2162a-qds.dtb dtb-$(CONFIG_ARCH_MXC) += imx8mm-evk.dtb dtb-$(CONFIG_ARCH_MXC) += imx8mn-evk.dtb diff --git a/arch/arm64/boot/dts/freescale/fsl-lx2162a-qds.dts b/arch/arm64/boot/dts/freescale/fsl-lx2162a-qds.dts new file mode 100644 index 0000000..a81c6a4 --- /dev/null +++ b/arch/arm64/boot/dts/freescale/fsl-lx2162a-qds.dts @@ -0,0 +1,336 @@ +// SPDX-License-Identifier: (GPL-2.0 OR MIT) +// +// Device Tree file for LX2162AQDS +// +// Copyright 2020 NXP + +/dts-v1/; + +#include "fsl-lx2160a.dtsi" + +/ { + model = "NXP Layerscape LX2162AQDS"; + compatible = "nxp,lx2162a-qds", "fsl,lx2160a"; + + aliases { + crypto = &crypto; + serial0 = &uart0; + }; + + chosen { + stdout-path = "serial0:115200n8"; + }; + + sb_3v3: regulator-sb3v3 { + compatible = "regulator-fixed"; + regulator-name = "MC34717-3.3VSB"; + regulator-min-microvolt = <3300000>; + regulator-max-microvolt = <3300000>; + regulator-boot-on; + regulator-always-on; + }; + + mdio-mux-1 { + compatible = "mdio-mux-multiplexer"; + mux-controls = <&mux 0>; + mdio-parent-bus = <&emdio1>; + #address-cells=<1>; + #size-cells = <0>; + + mdio@0 { /* On-board RTL8211F PHY #1 RGMII1*/ + reg = <0x00>; + #address-cells = <1>; + #size-cells = <0>; + + rgmii_phy1: ethernet-phy@1 { + compatible = "ethernet-phy-id001c.c916"; + reg = <0x1>; + eee-broken-1000t; + }; + }; + + mdio@8 { /* On-board RTL8211F PHY #2 RGMII2*/ + reg = <0x8>; + #address-cells = <1>; + #size-cells = <0>; + + rgmii_phy2: ethernet-phy@2 { + compatible = "ethernet-phy-id001c.c916"; + reg = <0x2>; + eee-broken-1000t; + }; + }; + + mdio@18 { /* Slot #1 */ + reg = <0x18>; + #address-cells = <1>; + #size-cells = <0>; + }; + + mdio@19 { /* Slot #2 */ + reg = <0x19>; + #address-cells = <1>; + #size-cells = <0>; + }; + + mdio@1a { /* Slot #3 */ + reg = <0x1a>; + #address-cells = <1>; + #size-cells = <0>; + }; + + mdio@1b { /* Slot #4 */ + reg = <0x1b>; + #address-cells = <1>; + #size-cells = <0>; + }; + + mdio@1c { /* Slot #5 */ + reg = <0x1c>; + #address-cells = <1>; + #size-cells = <0>; + }; + + mdio@1d { /* Slot #6 */ + reg = <0x1d>; + #address-cells = <1>; + #size-cells = <0>; + }; + + mdio@1e { /* Slot #7 */ + reg = <0x1e>; + #address-cells = <1>; + #size-cells = <0>; + }; + + mdio@1f { /* Slot #8 */ + reg = <0x1f>; + #address-cells = <1>; + #size-cells = <0>; + }; + }; + + mdio-mux-2 { + compatible = "mdio-mux-multiplexer"; + mux-controls = <&mux 1>; + mdio-parent-bus = <&emdio2>; + #address-cells=<1>; + #size-cells = <0>; + + mdio@0 { /* Slot #1 (secondary EMI) */ + reg = <0x00>; + #address-cells = <1>; + #size-cells = <0>; + }; + + mdio@1 { /* Slot #2 (secondary EMI) */ + reg = <0x01>; + #address-cells = <1>; + #size-cells = <0>; + }; + + mdio@2 { /* Slot #3 (secondary EMI) */ + reg = <0x02>; + #address-cells = <1>; + #size-cells = <0>; + }; + + mdio@3 { /* Slot #4 (secondary EMI) */ + reg = <0x03>; + #address-cells = <1>; + #size-cells = <0>; + }; + + mdio@4 { /* Slot #5 (secondary EMI) */ + reg = <0x04>; + #address-cells = <1>; + #size-cells = <0>; + }; + + mdio@5 { /* Slot #6 (secondary EMI) */ + reg = <0x05>; + #address-cells = <1>; + #size-cells = <0>; + }; + + mdio@6 { /* Slot #7 (secondary EMI) */ + reg = <0x06>; + #address-cells = <1>; + #size-cells = <0>; + }; + + mdio@7 { /* Slot #8 (secondary EMI) */ + reg = <0x07>; + #address-cells = <1>; + #size-cells = <0>; + }; + }; +}; + +&crypto { + status = "okay"; +}; + +&dpmac17 { + phy-handle = <&rgmii_phy1>; + phy-connection-type = "rgmii-id"; +}; + +&dpmac18 { + phy-handle = <&rgmii_phy2>; + phy-connection-type = "rgmii-id"; +}; + +&dspi0 { + status = "okay"; + + dflash0: flash@0 { + #address-cells = <1>; + #size-cells = <1>; + compatible = "jedec,spi-nor"; + reg = <0>; + spi-max-frequency = <1000000>; + }; +}; + +&dspi1 { + status = "okay"; + + dflash1: flash@0 { + #address-cells = <1>; + #size-cells = <1>; + compatible = "jedec,spi-nor"; + reg = <0>; + spi-max-frequency = <1000000>; + }; +}; + +&dspi2 { + status = "okay"; + + dflash2: flash@0 { + #address-cells = <1>; + #size-cells = <1>; + compatible = "jedec,spi-nor"; + reg = <0>; + spi-max-frequency = <1000000>; + }; +}; + +&emdio1 { + status = "okay"; +}; + +&emdio2 { + status = "okay"; +}; + +&esdhc0 { + status = "okay"; +}; + +&esdhc1 { + status = "okay"; +}; + +&fspi { + status = "okay"; + + mt35xu512aba0: flash@0 { + #address-cells = <1>; + #size-cells = <1>; + compatible = "jedec,spi-nor"; + m25p,fast-read; + spi-max-frequency = <50000000>; + reg = <0>; + spi-rx-bus-width = <8>; + spi-tx-bus-width = <8>; + }; +}; + +&i2c0 { + status = "okay"; + + fpga@66 { + compatible = "fsl,lx2160aqds-fpga", "fsl,fpga-qixis-i2c", + "simple-mfd"; + reg = <0x66>; + + mux: mux-controller { + compatible = "reg-mux"; + #mux-control-cells = <1>; + mux-reg-masks = <0x54 0xf8>, /* 0: reg 0x54, bits 7:3 */ + <0x54 0x07>; /* 1: reg 0x54, bit 2:0 */ + }; + }; + + i2c-mux@77 { + compatible = "nxp,pca9547"; + reg = <0x77>; + #address-cells = <1>; + #size-cells = <0>; + + i2c@2 { + #address-cells = <1>; + #size-cells = <0>; + reg = <0x2>; + + power-monitor@40 { + compatible = "ti,ina220"; + reg = <0x40>; + shunt-resistor = <500>; + }; + + power-monitor@41 { + compatible = "ti,ina220"; + reg = <0x41>; + shunt-resistor = <1000>; + }; + }; + + i2c@3 { + #address-cells = <1>; + #size-cells = <0>; + reg = <0x3>; + + temperature-sensor@4c { + compatible = "nxp,sa56004"; + reg = <0x4c>; + vcc-supply = <&sb_3v3>; + }; + + rtc@51 { + compatible = "nxp,pcf2129"; + reg = <0x51>; + }; + }; + }; +}; + +&sata0 { + status = "okay"; +}; + +&sata1 { + status = "okay"; +}; + +&sata2 { + status = "okay"; +}; + +&sata3 { + status = "okay"; +}; + +&uart0 { + status = "okay"; +}; + +&uart1 { + status = "okay"; +}; + +&usb0 { + status = "okay"; +};