| Message ID | 1615294733-22761-4-git-send-email-aisheng.dong@nxp.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | PM / devfreq: a few small fixes and improvements | expand |
On 21. 3. 9. 오후 9:58, Dong Aisheng wrote: > Fix the wrong set_freq path for userspace governor. > > Signed-off-by: Dong Aisheng <aisheng.dong@nxp.com> > --- > drivers/devfreq/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/devfreq/Kconfig b/drivers/devfreq/Kconfig > index 00704efe6398..20373a893b44 100644 > --- a/drivers/devfreq/Kconfig > +++ b/drivers/devfreq/Kconfig > @@ -62,7 +62,7 @@ config DEVFREQ_GOV_USERSPACE > help > Sets the frequency at the user specified one. > This governor returns the user configured frequency if there > - has been an input to /sys/devices/.../power/devfreq_set_freq. > + has been an input to /sys/devices/.../userspace/set_freq. > Otherwise, the governor does not change the frequency > given at the initialization. > > Looks good. But this patch just fix the information in Kconfig instead of fixing the wrong operation. To clarify the commit message, I'll change the patch title and commit message as following: PM / devfreq: Fix the wrong set_freq path for userspace governor in Kconfig Fix the wrong set_freq path for userspace governor in Kconfig. Signed-off-by: Dong Aisheng <aisheng.dong@nxp.com> Applied it. But, if you have any other objection, please let me know.
On Tue, Mar 9, 2021 at 11:13 PM Chanwoo Choi <cwchoi00@gmail.com> wrote: > > On 21. 3. 9. 오후 9:58, Dong Aisheng wrote: > > Fix the wrong set_freq path for userspace governor. > > > > Signed-off-by: Dong Aisheng <aisheng.dong@nxp.com> > > --- > > drivers/devfreq/Kconfig | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/devfreq/Kconfig b/drivers/devfreq/Kconfig > > index 00704efe6398..20373a893b44 100644 > > --- a/drivers/devfreq/Kconfig > > +++ b/drivers/devfreq/Kconfig > > @@ -62,7 +62,7 @@ config DEVFREQ_GOV_USERSPACE > > help > > Sets the frequency at the user specified one. > > This governor returns the user configured frequency if there > > - has been an input to /sys/devices/.../power/devfreq_set_freq. > > + has been an input to /sys/devices/.../userspace/set_freq. > > Otherwise, the governor does not change the frequency > > given at the initialization. > > > > > > Looks good. But this patch just fix the information in Kconfig > instead of fixing the wrong operation. To clarify the commit message, > I'll change the patch title and commit message as following: Looks like more accurate. Thanks. Regards Aisheng > > PM / devfreq: Fix the wrong set_freq path for userspace governor in > Kconfig > > Fix the wrong set_freq path for userspace governor in Kconfig. > > Signed-off-by: Dong Aisheng <aisheng.dong@nxp.com> > > > Applied it. But, if you have any other objection, please let me know. > > > -- > Best Regards, > Samsung Electronics > Chanwoo Choi
diff --git a/drivers/devfreq/Kconfig b/drivers/devfreq/Kconfig index 00704efe6398..20373a893b44 100644 --- a/drivers/devfreq/Kconfig +++ b/drivers/devfreq/Kconfig @@ -62,7 +62,7 @@ config DEVFREQ_GOV_USERSPACE help Sets the frequency at the user specified one. This governor returns the user configured frequency if there - has been an input to /sys/devices/.../power/devfreq_set_freq. + has been an input to /sys/devices/.../userspace/set_freq. Otherwise, the governor does not change the frequency given at the initialization.
Fix the wrong set_freq path for userspace governor. Signed-off-by: Dong Aisheng <aisheng.dong@nxp.com> --- drivers/devfreq/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)