| Message ID | 1617681598-28165-1-git-send-email-jiapeng.chong@linux.alibaba.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | usb: gadget: aspeed: Remove unnecessary version.h includes | expand |
On Tue, Apr 06, 2021 at 11:59:58AM +0800, Jiapeng Chong wrote: > "make versioncheck" shows: > > ./drivers/usb/gadget/udc/aspeed-vhub/hub.c: 33 linux/version.h not > needed. Then you need to fix the tool, and always test-build patches before you send them out, as this is obviously wrong :(
On 2021/4/6 13:26, Greg KH wrote: > On Tue, Apr 06, 2021 at 11:59:58AM +0800, Jiapeng Chong wrote: >> "make versioncheck" shows: >> >> ./drivers/usb/gadget/udc/aspeed-vhub/hub.c: 33 linux/version.h not >> needed. > > Then you need to fix the tool, and always test-build patches before you > send them out, as this is obviously wrong :( > Sorry for the noise. We'll do more test-build towards patches next time.
diff --git a/drivers/usb/gadget/udc/aspeed-vhub/hub.c b/drivers/usb/gadget/udc/aspeed-vhub/hub.c index 5c7dea5..e5bbc0c 100644 --- a/drivers/usb/gadget/udc/aspeed-vhub/hub.c +++ b/drivers/usb/gadget/udc/aspeed-vhub/hub.c @@ -30,7 +30,6 @@ #include <linux/regmap.h> #include <linux/dma-mapping.h> #include <linux/bcd.h> -#include <linux/version.h> #include <linux/usb.h> #include <linux/usb/hcd.h>
"make versioncheck" shows: ./drivers/usb/gadget/udc/aspeed-vhub/hub.c: 33 linux/version.h not needed. Reported-by: Abaci Robot <abaci@linux.alibaba.com> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com> --- drivers/usb/gadget/udc/aspeed-vhub/hub.c | 1 - 1 file changed, 1 deletion(-)