| Message ID | 1618475753-102123-1-git-send-email-jiapeng.chong@linux.alibaba.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | pwm: mediatek: remove unused function | expand |
On Thu, Apr 15, 2021 at 04:35:53PM +0800, Jiapeng Chong wrote: > Fix the following clang warning: > > drivers/pwm/pwm-mediatek.c:110:19: warning: unused function > 'pwm_mediatek_readl' [-Wunused-function]. > > Reported-by: Abaci Robot <abaci@linux.alibaba.com> > Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com> Looks right, even though I would prefer to see a patch implementing .get_state instead (which probably would make use of this function). Acked-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Best regards Uwe
On Thu, Apr 15, 2021 at 04:35:53PM +0800, Jiapeng Chong wrote: > Fix the following clang warning: > > drivers/pwm/pwm-mediatek.c:110:19: warning: unused function > 'pwm_mediatek_readl' [-Wunused-function]. > > Reported-by: Abaci Robot <abaci@linux.alibaba.com> > Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com> > --- > drivers/pwm/pwm-mediatek.c | 6 ------ > 1 file changed, 6 deletions(-) Applied, thanks. Thierry
diff --git a/drivers/pwm/pwm-mediatek.c b/drivers/pwm/pwm-mediatek.c index fcfc3b1..cae0f48 100644 --- a/drivers/pwm/pwm-mediatek.c +++ b/drivers/pwm/pwm-mediatek.c @@ -107,12 +107,6 @@ static void pwm_mediatek_clk_disable(struct pwm_chip *chip, clk_disable_unprepare(pc->clk_top); } -static inline u32 pwm_mediatek_readl(struct pwm_mediatek_chip *chip, - unsigned int num, unsigned int offset) -{ - return readl(chip->regs + pwm_mediatek_reg_offset[num] + offset); -} - static inline void pwm_mediatek_writel(struct pwm_mediatek_chip *chip, unsigned int num, unsigned int offset, u32 value)
Fix the following clang warning: drivers/pwm/pwm-mediatek.c:110:19: warning: unused function 'pwm_mediatek_readl' [-Wunused-function]. Reported-by: Abaci Robot <abaci@linux.alibaba.com> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com> --- drivers/pwm/pwm-mediatek.c | 6 ------ 1 file changed, 6 deletions(-)