From patchwork Sat May 29 13:02:51 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stefan Wahren X-Patchwork-Id: 12287919 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 97E0BC4708E for ; Sat, 29 May 2021 13:08:49 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 55C7461186 for ; Sat, 29 May 2021 13:08:49 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 55C7461186 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=i2se.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:List-Subscribe:List-Help: List-Post:List-Archive:List-Unsubscribe:List-Id:Message-Id:Date:Subject:Cc:To :From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=8wKX3sgPXSjLKv4NEDeSRkO91eJUThpqQQ/oF2ie2T4=; b=VaLqGCBqgrsS8D +ZOHe0jfHZYq/7belqMcSeUeQuz3iyQ8Okboag71QyObf/NKXzcF0uxmxW5AEGiE1D9+0xHIqXydK yoErtItZ+EQd/qLjyW0EI4qkvFJKQsKDUgS5kcS9t39nWozwbuUQS3g0pAbNpUWZLtvcsBGUsNVne EzWoNyC/ZmOoLhrV56UssMdSAtJyAHNmWQlmYDq1T782cVw0gYOzLPe40Y5C6vdXDCIzzMClLTpO0 C7kVZOn/X2Dh+FmoOICflEQzoTLFoAjP9oNtCTwn/o5rwQdMHWwcADFcmIA9aYDGd3sXjfTSpVFU7 GVupRoamTNCogblcty+A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1lmyd0-005hcV-N2; Sat, 29 May 2021 13:03:46 +0000 Received: from mout.kundenserver.de ([212.227.126.134]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1lmycw-005hXl-8r; Sat, 29 May 2021 13:03:43 +0000 Received: from localhost.localdomain ([37.4.249.151]) by mrelayeu.kundenserver.de (mreue009 [212.227.15.167]) with ESMTPSA (Nemesis) id 1N3bb1-1lMTJL08up-010f3s; Sat, 29 May 2021 15:03:28 +0200 From: Stefan Wahren To: Rob Herring , Nicolas Saenz Julienne Cc: Florian Fainelli , Ray Jui , Scott Branden , bcm-kernel-feedback-list@broadcom.com, devicetree@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, Stefan Wahren , Pavel Hofman Subject: [PATCH] Revert "ARM: dts: bcm283x: increase dwc2's RX FIFO size" Date: Sat, 29 May 2021 15:02:51 +0200 Message-Id: <1622293371-5997-1-git-send-email-stefan.wahren@i2se.com> X-Mailer: git-send-email 2.7.4 X-Provags-ID: V03:K1:meHw8Gf8vKEcAOz19+Okqrwk52JqBmIhEB8v3cgLlcyvyxOzeH3 7r7vCpUtgR3eJH9m7qXApGNFZiFXaR5Rr52R4jnoTSs+5s4ulTfFUvKNcTSQFh9ejR6rI/M zZg/9k+Vop/ZQVsx9WgfxyucSkavAVei2Tx3YtrEYD7WLN5v3CrSfz9D/XCaanIRFrqAiea 8kbYfbshXNnFn8sf8Je1w== X-UI-Out-Filterresults: notjunk:1;V03:K0:vOGgCVuhGHc=:L5LgYq09bOj6OXbk01BGR6 TzYHH+Wxg0CXcDQnCgR1CzW8LiumD8vAzPGYTYm1X5pNCXJn+mxWb+AEQWpze60vVuPF/RIeI 5/9uA6KfK6D/rWmqNtuddcCaw1gVIQPTgNgGvQGfs/33zJphxFhfjvbfG6FZ1ZlNyDDIqztTC 8OtuRfVqDezP4XZYtr7VIvmS/q23DtB+c+q0e06nuX3RKp3tqnDddPeCC/YMoBTvYmC9UEA9g Sz9V7eRTWtsAgqBraiRPVS5T4jVULZSxhb/veAljMGIxLWIjP/RuvPK4wldsJTRNTPkkIEDrv Hy4VtYPv6IyIIa8ihGoYBz8Pui+GmZX498DZZnm6sCus9N5Of9P00IG8b9SegP06Na/A9aPVY z8iu+2+U6hE/B9EGca/2RQxVeXaeO9zrbu4uYfxLr9nn06Aq+U/U1aQi2QCn7NduLytcGXed1 kMx5SnNShORxnYr6QAkIrSXVhpinUqpzl6lVP2KUBz5fWTrETuEifsRrJnzxgFHgwr42XvIop EY+fY1MXdMiLK7Z/qTY6Bc= X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210529_060342_634673_039B2DFB X-CRM114-Status: GOOD ( 10.67 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org This reverts commit 278407a53c3b33fb820332c4d39eb39316c3879a. The original change breaks USB config on Raspberry Pi Zero and Pi 4 B, because it exceeds the total fifo size of 4080. A naive attempt to reduce g-tx-fifo-size doesn't help on Raspberry Pi Zero. So better go back. Fixes: 278407a53c3b ("ARM: dts: bcm283x: increase dwc2's RX FIFO size") Signed-off-by: Stefan Wahren Cc: Pavel Hofman --- arch/arm/boot/dts/bcm283x-rpi-usb-otg.dtsi | 2 +- arch/arm/boot/dts/bcm283x-rpi-usb-peripheral.dtsi | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/arm/boot/dts/bcm283x-rpi-usb-otg.dtsi b/arch/arm/boot/dts/bcm283x-rpi-usb-otg.dtsi index 20322de..e2fd961 100644 --- a/arch/arm/boot/dts/bcm283x-rpi-usb-otg.dtsi +++ b/arch/arm/boot/dts/bcm283x-rpi-usb-otg.dtsi @@ -1,7 +1,7 @@ // SPDX-License-Identifier: GPL-2.0 &usb { dr_mode = "otg"; - g-rx-fifo-size = <558>; + g-rx-fifo-size = <256>; g-np-tx-fifo-size = <32>; /* * According to dwc2 the sum of all device EP diff --git a/arch/arm/boot/dts/bcm283x-rpi-usb-peripheral.dtsi b/arch/arm/boot/dts/bcm283x-rpi-usb-peripheral.dtsi index 1409d1b..0ff0e9e 100644 --- a/arch/arm/boot/dts/bcm283x-rpi-usb-peripheral.dtsi +++ b/arch/arm/boot/dts/bcm283x-rpi-usb-peripheral.dtsi @@ -1,7 +1,7 @@ // SPDX-License-Identifier: GPL-2.0 &usb { dr_mode = "peripheral"; - g-rx-fifo-size = <558>; + g-rx-fifo-size = <256>; g-np-tx-fifo-size = <32>; g-tx-fifo-size = <256 256 512 512 512 768 768>; };