diff mbox series

[1/3] dt-bindings: fsl: scu: Add i.MX8QM rtc binding

Message ID 1640088948-3690-2-git-send-email-abel.vesa@nxp.com (mailing list archive)
State New, archived
Headers show
Series Add RTC support to i.MX8QM | expand

Commit Message

Abel Vesa Dec. 21, 2021, 12:15 p.m. UTC
Add i.MX8QM rtc compatible to the SCU bindings documentation.

Signed-off-by: Abel Vesa <abel.vesa@nxp.com>
---
 Documentation/devicetree/bindings/arm/freescale/fsl,scu.txt | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

Comments

Rob Herring (Arm) Dec. 22, 2021, 6:29 p.m. UTC | #1
On Tue, 21 Dec 2021 14:15:46 +0200, Abel Vesa wrote:
> Add i.MX8QM rtc compatible to the SCU bindings documentation.
> 
> Signed-off-by: Abel Vesa <abel.vesa@nxp.com>
> ---
>  Documentation/devicetree/bindings/arm/freescale/fsl,scu.txt | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 

Acked-by: Rob Herring <robh@kernel.org>
Alexandre Belloni Dec. 29, 2021, 9:36 p.m. UTC | #2
On 21/12/2021 14:15:46+0200, Abel Vesa wrote:
> Add i.MX8QM rtc compatible to the SCU bindings documentation.
> 
> Signed-off-by: Abel Vesa <abel.vesa@nxp.com>
> ---
>  Documentation/devicetree/bindings/arm/freescale/fsl,scu.txt | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/arm/freescale/fsl,scu.txt b/Documentation/devicetree/bindings/arm/freescale/fsl,scu.txt
> index f1470d562156..4633be2182dd 100644
> --- a/Documentation/devicetree/bindings/arm/freescale/fsl,scu.txt
> +++ b/Documentation/devicetree/bindings/arm/freescale/fsl,scu.txt
> @@ -134,7 +134,9 @@ RTC bindings based on SCU Message Protocol
>  ------------------------------------------------------------
>  
>  Required properties:
> -- compatible: should be "fsl,imx8qxp-sc-rtc";
> +- compatible:		Should be one of:
> +			"fsl,imx8qm-sc-rtc",
> +			"fsl,imx8qxp-sc-rtc".

Are the imx8qm and imx8qxp SCU actually different? I would hope you
won't had a third messaging protocol for the RTC...
Abel Vesa Jan. 3, 2022, 7:46 p.m. UTC | #3
On 21-12-29 22:36:27, Alexandre Belloni wrote:
> On 21/12/2021 14:15:46+0200, Abel Vesa wrote:
> > Add i.MX8QM rtc compatible to the SCU bindings documentation.
> > 
> > Signed-off-by: Abel Vesa <abel.vesa@nxp.com>
> > ---
> >  Documentation/devicetree/bindings/arm/freescale/fsl,scu.txt | 4 +++-
> >  1 file changed, 3 insertions(+), 1 deletion(-)
> > 
> > diff --git a/Documentation/devicetree/bindings/arm/freescale/fsl,scu.txt b/Documentation/devicetree/bindings/arm/freescale/fsl,scu.txt
> > index f1470d562156..4633be2182dd 100644
> > --- a/Documentation/devicetree/bindings/arm/freescale/fsl,scu.txt
> > +++ b/Documentation/devicetree/bindings/arm/freescale/fsl,scu.txt
> > @@ -134,7 +134,9 @@ RTC bindings based on SCU Message Protocol
> >  ------------------------------------------------------------
> >  
> >  Required properties:
> > -- compatible: should be "fsl,imx8qxp-sc-rtc";
> > +- compatible:		Should be one of:
> > +			"fsl,imx8qm-sc-rtc",
> > +			"fsl,imx8qxp-sc-rtc".
> 
> Are the imx8qm and imx8qxp SCU actually different? I would hope you
> won't had a third messaging protocol for the RTC...
> 

Sorry, my bad.

No, there is no difference between imx8mq and imx8qxp.

I'll replace the compatible in the imx8qm.dtsi with fsl,imx8qxp-sc-rtc,
drop this patch and the one that adds the compatible to the rtc driver.

> 
> -- 
> Alexandre Belloni, co-owner and COO, Bootlin
> Embedded Linux and Kernel engineering
> https://bootlin.com/
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/arm/freescale/fsl,scu.txt b/Documentation/devicetree/bindings/arm/freescale/fsl,scu.txt
index f1470d562156..4633be2182dd 100644
--- a/Documentation/devicetree/bindings/arm/freescale/fsl,scu.txt
+++ b/Documentation/devicetree/bindings/arm/freescale/fsl,scu.txt
@@ -134,7 +134,9 @@  RTC bindings based on SCU Message Protocol
 ------------------------------------------------------------
 
 Required properties:
-- compatible: should be "fsl,imx8qxp-sc-rtc";
+- compatible:		Should be one of:
+			"fsl,imx8qm-sc-rtc",
+			"fsl,imx8qxp-sc-rtc".
 
 OCOTP bindings based on SCU Message Protocol
 ------------------------------------------------------------