From patchwork Wed Nov 28 05:23:09 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kim Kukjin X-Patchwork-Id: 1814041 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork1.kernel.org Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) by patchwork1.kernel.org (Postfix) with ESMTP id 0A92F3FD1A for ; Wed, 28 Nov 2012 05:26:06 +0000 (UTC) Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.76 #1 (Red Hat Linux)) id 1Tda7D-0007zk-Kj; Wed, 28 Nov 2012 05:23:19 +0000 Received: from mailout2.samsung.com ([203.254.224.25]) by merlin.infradead.org with esmtp (Exim 4.76 #1 (Red Hat Linux)) id 1Tda78-0007zP-OH for linux-arm-kernel@lists.infradead.org; Wed, 28 Nov 2012 05:23:16 +0000 Received: from epcpsbgm2.samsung.com (epcpsbgm2 [203.254.230.27]) by mailout2.samsung.com (Oracle Communications Messaging Server 7u4-24.01(7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0ME60047NMXWUYK0@mailout2.samsung.com> for linux-arm-kernel@lists.infradead.org; Wed, 28 Nov 2012 14:23:09 +0900 (KST) Received: from epcpsbgm2.samsung.com ( [203.254.230.48]) by epcpsbgm2.samsung.com (EPCPMTA) with SMTP id F8.A7.12699.DBF95B05; Wed, 28 Nov 2012 14:23:09 +0900 (KST) X-AuditID: cbfee61b-b7f616d00000319b-a2-50b59fbd10cf Received: from epmmp2 ( [203.254.227.17]) by epcpsbgm2.samsung.com (EPCPMTA) with SMTP id 98.A7.12699.DBF95B05; Wed, 28 Nov 2012 14:23:09 +0900 (KST) Received: from DOKGENEKIM03 ([12.23.120.199]) by mmp2.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTPA id <0ME600HEJMYLVZ00@mmp2.samsung.com> for linux-arm-kernel@lists.infradead.org; Wed, 28 Nov 2012 14:23:09 +0900 (KST) From: Kukjin Kim To: 'Olof Johansson' References: <1354045994-8977-1-git-send-email-dianders@chromium.org> <50B53E37.40303@samsung.com> In-reply-to: Subject: RE: [PATCH] ARM: EXYNOS: Avoid early use of of_machine_is_compatible() Date: Wed, 28 Nov 2012 14:23:09 +0900 Message-id: <18d701cdcd28$74198d70$5c4ca850$%kim@samsung.com> MIME-version: 1.0 X-Mailer: Microsoft Office Outlook 12.0 Thread-index: Ac3M78/Zev9PNB8vTUSwvwHdOKHh8wANoFjQ Content-language: ko DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrJIsWRmVeSWpSXmKPExsVy+t8zA92987cGGHx9K2ex6fE1VgdGj81L 6gMYo7hsUlJzMstSi/TtErgyZp5vZyy4KVux/HM/awPjB4kuRk4OCQETid1H1jNC2GISF+6t Z+ti5OIQEljGKPF8628mmKJfZ+6xQCSmM0o8OzyNFaqKSeLBum9gVWwCGhKH3z9jB7FFBFQl njzpAitiFnjAKDGl/SwTRMdHRokjq0+xgVRxCgRL/P9/H6xDWMBfYvq5tWA2C1D3ioUbwGp4 BWwlrjZ8ZYGwBSV+TL4HZjMLaEms33mcCcKWl9i85i1zFyMH0K3qEo/+6kIcYSTx88RHqBIR iX0v3jFCjBeQ+Db5EAtEuazEpgPMIKdJCMxjl1gz8wQ0LCQlDq64wTKBUWIWks2zkGyehWTz LCQrFjCyrGIUTS1ILihOSs810itOzC0uzUvXS87P3cQIiS/pHYyrGiwOMQpwMCrx8Do4bg0Q Yk0sK67MPcQowcGsJMLL0wYU4k1JrKxKLcqPLyrNSS0+xOgDdPlEZinR5Hxg7OeVxBsaG5uY mZiamFuampviEFYS5232SAkQEkhPLEnNTk0tSC2CGcfEwSnVwDh/x3FDdpW8/3t+eWyyzmFa WfvK93fiI9/bJdqf5M6cLNUUVRVy3dv4LfXJZKcthtzGDo/i+/18du7PqdhWkpQQvcoudmvF F5cPXZ86nmxX2GBqc+ydYmHbVhnxnrB/POck/t5J6n1htm/DtfDwF64LHopP6w7dYOZq7295 8f374x7P3Gau1VFiKc5INNRiLipOBAA/j8N03AIAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrBIsWRmVeSWpSXmKPExsVy+t9jQd2987cGGExZLmWx6fE1VgdGj81L 6gMYoxoYbTJSE1NSixRS85LzUzLz0m2VvIPjneNNzQwMdQ0tLcyVFPISc1NtlVx8AnTdMnOA pioplCXmlAKFAhKLi5X07TBNCA1x07WAaYzQ9Q0JgusxMkADCesYM2aeb2csuClbsfxzP2sD 4weJLkZODgkBE4lfZ+6xQNhiEhfurWfrYuTiEBKYzijx7PA0VghnGZPEg3XfmECq2AQ0JA6/ f8YOYosIqEo8edIFVsQs8IBRYkr7WSaIjo+MEkdWn2IDqeIUCJb4//8+WIewgL/E9HNrwWwW oO4VCzeA1fAK2EpcbfjKAmELSvyYDHETs4CWxPqdx5kgbHmJzWveMncxcgDdqi7x6K8uxBFG Ej9PfIQqEZHY9+Id4wRGoVlIJs1CMmkWkkmzkLQsYGRZxSiaWpBcUJyUnmukV5yYW1yal66X nJ+7iREcvc+kdzCuarA4xCjAwajEw+vguDVAiDWxrLgy9xCjBAezkggvTxtQiDclsbIqtSg/ vqg0J7X4EKMP0KMTmaVEk/OBiSWvJN7Q2MTMyNLIzMLIxNwch7CSOG+zR0qAkEB6Yklqdmpq QWoRzDgmDk6pBsb8+L4H+SeNK6bzMkyafn6livN3fts31x8kt3ndW7i3T/NCtI+m6MrPQuF6 n70eCTjda0iMfLtZz+PGfkHRNVdnyMlrn7kZwPI08IYe37E1Ar6RKQoZM3i0zVwruv2Nf/m0 z5L0EHr2QGb70pjjX1j0Zlp4OYTMk4pcXF63rGurQ9lvlmyzICWW4oxEQy3mouJEAA91F4gL AwAA X-CFilter-Loop: Reflected X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20121128_002315_315206_5FBA62D6 X-CRM114-Status: GOOD ( 21.62 ) X-Spam-Score: -7.6 (-------) X-Spam-Report: SpamAssassin version 3.3.2 on merlin.infradead.org summary: Content analysis details: (-7.6 points) pts rule name description ---- ---------------------- -------------------------------------------------- -5.0 RCVD_IN_DNSWL_HI RBL: Sender listed at http://www.dnswl.org/, high trust [203.254.224.25 listed in list.dnswl.org] -0.0 SPF_HELO_PASS SPF: HELO matches SPF record -0.7 RP_MATCHES_RCVD Envelope sender domain matches handover relay domain -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] Cc: linux-samsung-soc@vger.kernel.org, 'Russell King' , 'Arnd Bergmann' , 'Doug Anderson' , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-arm-kernel-bounces@lists.infradead.org Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org Olof Johansson wrote: > > On Tue, Nov 27, 2012 at 2:27 PM, Kukjin Kim wrote: > > On 11/28/12 07:11, Olof Johansson wrote: > >> > >> On Tue, Nov 27, 2012 at 11:53 AM, Doug Anderson > >> wrote: > >>> > >>> The recent commit "ARM: EXYNOS: add support for EXYNOS5440 SoC" broke > >>> support for exynos5250 because of_machine_is_compatible() was used too > >>> early in the boot process. It also probably meant that the exynos5440 > >>> failed to use the proper iotable. Switch to use > >>> of_flat_dt_is_compatible() in both of these cases. > >>> > >>> The failure I was seeing in exynos5250 because of this was: > >>> Division by zero in kernel. > >>> [<80015ed4>] (unwind_backtrace+0x0/0xec) from [<8045c7a4>] > >>> (dump_stack+0x20/0x24) > >>> [<8045c7a4>] (dump_stack+0x20/0x24) from [<80012990>] > >>> (__div0+0x20/0x28) > >>> [<80012990>] (__div0+0x20/0x28) from [<8021ab04>] (Ldiv0_64+0x8/0x18) > >>> [<8021ab04>] (Ldiv0_64+0x8/0x18) from [<80068560>] > >>> (__clocksource_updatefreq_scale+0x54/0x134) > >>> [<80068560>] (__clocksource_updatefreq_scale+0x54/0x134) from > >>> [<8006865c>] (__clocksource_register_scale+0x1c/0x54) > >>> [<8006865c>] (__clocksource_register_scale+0x1c/0x54) from > >>> [<80612a18>] (exynos_timer_init+0x100/0x1e8) > >>> [<80612a18>] (exynos_timer_init+0x100/0x1e8) from [<8060d184>] > >>> (time_init+0x28/0x38) > >>> [<8060d184>] (time_init+0x28/0x38) from [<8060a754>] > >>> (start_kernel+0x1e0/0x3c8) > >>> [<8060a754>] (start_kernel+0x1e0/0x3c8) from [<40008078>] > (0x40008078) > >>> > >>> Signed-off-by: Doug Anderson > >> > >> > >> Thanks Doug. > >> > >> Kukjin, I'll apply this directly on top of the previous branch in > >> arm-soc, if that's OK with you. > >> > > Sure, go ahead with my ack if you want, > > > > Acked-by: Kukjin Kim > > > > Note, actually there was a fix which uses soc_is_exynos5440() in my > local > > :-) I'm not sure which one is better at this moment, but I'm OK on this. > > Ok, applied. Thanks all. > Olof, just note, happens build error with exynos4_defconfig because of non-DT. Following can resolve it or we should create null function for of_get_flat_dt_root() and of_flat_dt_is_compatible()... 8<--------------------------------------- From: Kukjin Kim Subject: ARM: EXYNOS: fix a build error with non-DT for exynos4 This fixes following in case of non-DT: arch/arm/mach-exynos/common.c: In function 'exynos_init_io': arch/arm/mach-exynos/common.c:339: error: implicit declaration of function 'of_get_flat_dt_root' arch/arm/mach-exynos/common.c:342: error: implicit declaration of function 'of_flat_dt_is_compatible' make[1]: *** [arch/arm/mach-exynos/common.o] Error 1 Signed-off-by: Kukjin Kim --- if (mach_desc) 8<--------------------------------------- Thanks. Best regards, Kgene. -- Kukjin Kim , Senior Engineer, SW Solution Development Team, Samsung Electronics Co., Ltd. diff --git a/arch/arm/mach-exynos/common.c b/arch/arm/mach-exynos/common.c index b919f5f..2110091 100644 --- a/arch/arm/mach-exynos/common.c +++ b/arch/arm/mach-exynos/common.c @@ -336,12 +336,14 @@ void __init exynos_init_late(void) void __init exynos_init_io(struct map_desc *mach_desc, int size) { +#ifdef CONFIG_OF unsigned long root = of_get_flat_dt_root(); /* initialize the io descriptors we need for initialization */ if (of_flat_dt_is_compatible(root, "samsung,exynos5440")) iotable_init(exynos5440_iodesc, ARRAY_SIZE(exynos5440_iodesc)); else +#endif iotable_init(exynos_iodesc, ARRAY_SIZE(exynos_iodesc));