From patchwork Tue Nov 17 03:17:24 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Peter Collingbourne X-Patchwork-Id: 11911391 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0439DC388F9 for ; Tue, 17 Nov 2020 03:19:28 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 830D624694 for ; Tue, 17 Nov 2020 03:19:27 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="YTSKFZK4"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=google.com header.i=@google.com header.b="uFaM/YxQ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 830D624694 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:To:From:Subject:References:Mime-Version:Message-Id: In-Reply-To:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=0Job9qdeL50EZFmQc6CkWUw9aC0xPSw5nRdwhOgIyXE=; b=YTSKFZK4rRyFbpcwhM74r/cpq nvuqLpGoKkecGgByb4p2zu0ssBV95/2/qAfsDrVH6MamnO7X69DEBTZui2zy6JSy30zXUHQ/iGn7X l6d+OKfDLrYLVcaaw8a8PEHwrAM+mMPs2qf1M+zm6CwV+YYXSXiLwGsUwmkLtPGKjZqzngJvnGpYE 73y30UAVbPZk+isTyM1774tL1ty87lGuI6d0T+P9erUFZS7xnio9Mrcx1MbgR7XRBIbUUkUm2ti3i f8H/OR6gjSDWTVjydwhAGDK6ApedVxbk8i2nyJrkxo10oJ6YOw0scvtXkPSwWYC1b0JUCYrTVrX3h TdwoCZ2Ow==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kerV0-00049F-LE; Tue, 17 Nov 2020 03:17:42 +0000 Received: from mail-pf1-x44a.google.com ([2607:f8b0:4864:20::44a]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kerUx-00048M-LN for linux-arm-kernel@lists.infradead.org; Tue, 17 Nov 2020 03:17:40 +0000 Received: by mail-pf1-x44a.google.com with SMTP id a24so13761087pfo.3 for ; Mon, 16 Nov 2020 19:17:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=sender:date:in-reply-to:message-id:mime-version:references:subject :from:to:cc; bh=HuMspXIQ1vn0+ZumsLYjmGAwT+zGOwAT2v6OIPNSsT0=; b=uFaM/YxQUDATljb5DcWZr3qKob3St2pMqUOQg88VWbjSTsDum+IS9ohXmhW3Wn53vs Y2qB0OmWgOorDg1fGE4CaRg69UhOQVlD7OUTv3uiS0snh0qxfSJh2lM/LBvEecxi9rjC B7d5azTwTnP7uKwhJ5r52je5aAODT0p9ZV3HGuwfiOxfNcAlhawzfNaGCe3+IT/qRku0 ugijBxuOF1KZxc6MnxyPxffLzd4c3ETWF5drrrvFtUJaHDSLZOuQ8CscJy/cXIHA9z6o oRPk4Z8xgomZGSWmh6o7oZKlfU5l5w7BWKsbUwD3mMgOEXbQ9wZYWhwQWfHlCsfU1JjV UF6A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:in-reply-to:message-id:mime-version :references:subject:from:to:cc; bh=HuMspXIQ1vn0+ZumsLYjmGAwT+zGOwAT2v6OIPNSsT0=; b=DIFXTuWa4kRLNjWI2okVsH2T+RR7/j6CvGLrLTqjRrOtpUQrP/wx/gatuIBAOu9vEK 0AIajzVzqYmdLMvWbIeDAHhrtuNdDnRRgBNambHpuiVvrr3hYnWXjFtZO9mE80x9TyFk XLC3IjkylkTa2L59MJqm0kqfODoetWBHuKNdUjkhrFxElxrt6N41tDpynleFXxXyHpoI vtSFZyIOt6cbatTnXP74L/sJTm9Qt4Ed3l8gZQ3xXSLNkPGUzz0i8ArjcbQtgtdGas9z de75ayL+heyW80K7Qza+uEsk8bNgzTqJx2pHh6cak+6A4/ioura42dMbh1BxlFe2g3R3 vA1w== X-Gm-Message-State: AOAM531HtqJBXDDE2Lvxww2Pkfd6iicmm+Jyh/0jF/gou7H9b4zCCHUo q5oIxAhyihNrnKJM92AlZ8IaaDk= X-Google-Smtp-Source: ABdhPJznLr5RckPvsSEPyZ7t77ewqqdyK65KCvVE16OkknBRcsvR3X4WQUBiu8bqRK2IQsHfIpLlITE= X-Received: from pcc-desktop.svl.corp.google.com ([2620:15c:2ce:0:7220:84ff:fe09:385a]) (user=pcc job=sendgmr) by 2002:a17:902:a504:b029:d8:ebc7:a864 with SMTP id s4-20020a170902a504b02900d8ebc7a864mr6768825plq.60.1605583055418; Mon, 16 Nov 2020 19:17:35 -0800 (PST) Date: Mon, 16 Nov 2020 19:17:24 -0800 In-Reply-To: Message-Id: <198c8b68c76bf3ed73117d817c7cdf9bc0eb174f.1605582887.git.pcc@google.com> Mime-Version: 1.0 References: X-Mailer: git-send-email 2.29.2.299.gdc1121823c-goog Subject: [PATCH v17 1/3] arch: provide better documentation for the arch-specific SA_* flags From: Peter Collingbourne To: Catalin Marinas , Evgenii Stepanov , Kostya Serebryany , Vincenzo Frascino , Dave Martin , Will Deacon , Oleg Nesterov , "Eric W. Biederman" , "James E.J. Bottomley" X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201116_221739_767680_B931A4DE X-CRM114-Status: GOOD ( 14.35 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Andrey Konovalov , Helge Deller , Kevin Brodsky , linux-api@vger.kernel.org, David Spickett , Peter Collingbourne , Linux ARM Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Instead of documenting the arch-specific flag values in a comment at the top where they may be easily overlooked, document them in comments inline with the definitions in numerical order so that it is clear why specific values must be chosen for new generic flags and to reduce the likelihood of conflicts between generic and arch-specific flags. Signed-off-by: Peter Collingbourne Link: https://linux-review.googlesource.com/id/I40a129cf7c3a71ba1bfd6d936c544072ee3b7ce6 --- include/uapi/asm-generic/signal-defs.h | 22 ++++++++++++++-------- 1 file changed, 14 insertions(+), 8 deletions(-) diff --git a/include/uapi/asm-generic/signal-defs.h b/include/uapi/asm-generic/signal-defs.h index 493953fe319b..44f070982752 100644 --- a/include/uapi/asm-generic/signal-defs.h +++ b/include/uapi/asm-generic/signal-defs.h @@ -17,9 +17,6 @@ * * SA_ONESHOT and SA_NOMASK are the historical Linux names for the Single * Unix names RESETHAND and NODEFER respectively. - * - * The following bits are used in architecture-specific SA_* definitions and - * should be avoided for new generic flags: 3, 4, 5, 6, 7, 8, 9, 16, 24, 25, 26. */ #ifndef SA_NOCLDSTOP #define SA_NOCLDSTOP 0x00000001 @@ -30,6 +27,20 @@ #ifndef SA_SIGINFO #define SA_SIGINFO 0x00000004 #endif +/* 0x00000008 used on alpha, mips, parisc */ +/* 0x00000010 used on alpha, parisc */ +/* 0x00000020 used on alpha, parisc, sparc */ +/* 0x00000040 used on alpha, parisc */ +/* 0x00000080 used on parisc */ +/* 0x00000100 used on sparc */ +/* 0x00000200 used on sparc */ +/* 0x00010000 used on mips */ +/* 0x01000000 used on x86 */ +/* 0x02000000 used on x86 */ +/* + * New architectures should not define the obsolete + * SA_RESTORER 0x04000000 + */ #ifndef SA_ONSTACK #define SA_ONSTACK 0x08000000 #endif @@ -46,11 +57,6 @@ #define SA_NOMASK SA_NODEFER #define SA_ONESHOT SA_RESETHAND -/* - * New architectures should not define the obsolete - * SA_RESTORER 0x04000000 - */ - #ifndef SIG_BLOCK #define SIG_BLOCK 0 /* for blocking signals */ #endif