From patchwork Fri Sep 16 18:09:15 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Javier Martinez Canillas X-Patchwork-Id: 9336343 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 77A4060839 for ; Fri, 16 Sep 2016 18:11:44 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 6B78B2A05C for ; Fri, 16 Sep 2016 18:11:44 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 5FE632A05E; Fri, 16 Sep 2016 18:11:44 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=2.0 tests=BAYES_00, RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.9]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id EFC332A05C for ; Fri, 16 Sep 2016 18:11:43 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.85_2 #1 (Red Hat Linux)) id 1bkxaR-0007xf-R6; Fri, 16 Sep 2016 18:10:07 +0000 Received: from ec2-52-27-115-49.us-west-2.compute.amazonaws.com ([52.27.115.49] helo=s-opensource.com) by bombadil.infradead.org with esmtp (Exim 4.85_2 #1 (Red Hat Linux)) id 1bkxa8-0007Vk-GX for linux-arm-kernel@lists.infradead.org; Fri, 16 Sep 2016 18:09:49 +0000 Received: from localhost (localhost [127.0.0.1]) by s-opensource.com (Postfix) with ESMTP id 9E33CA0E79; Fri, 16 Sep 2016 18:09:29 +0000 (UTC) X-Virus-Scanned: amavisd-new at osg.samsung.com Received: from s-opensource.com ([127.0.0.1]) by localhost (s-opensource.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Z-tIwgcYJTmr; Fri, 16 Sep 2016 18:09:29 +0000 (UTC) Received: from [10.0.0.105] (host-156.58.217.201.copaco.com.py [201.217.58.156]) by s-opensource.com (Postfix) with ESMTPSA id 3A716A0E61; Fri, 16 Sep 2016 18:09:23 +0000 (UTC) Subject: Re: [PATCH v6 2/3] ARM: dts: add TOPEET itop elite based board To: Krzysztof Kozlowski , ayaka References: <1473285535-21996-1-git-send-email-ayaka@soulik.info> <1473285535-21996-3-git-send-email-ayaka@soulik.info> <6bd9905d-0818-a917-8b8e-6abce134a3d3@kernel.org> <865b9f84-385f-fea8-2e3d-2b31e3bfe84c@soulik.info> <20160916172110.GA7511@kozik-lap> From: Javier Martinez Canillas Message-ID: <1e4335db-9004-bb7c-6dc1-e435e66b8126@osg.samsung.com> Date: Fri, 16 Sep 2016 14:09:15 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <20160916172110.GA7511@kozik-lap> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20160916_110948_640900_587A0A26 X-CRM114-Status: GOOD ( 10.77 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mark.rutland@arm.com, devicetree@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux@armlinux.org.uk, linux-kernel@vger.kernel.org, kgene@kernel.org, linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP Hello Randy, On 09/16/2016 01:21 PM, Krzysztof Kozlowski wrote: [snip] >>>> + >>>> + beep { >>>> + compatible = "pwm-beeper"; >>>> + pwms = <&pwm 0 4000000 PWM_POLARITY_INVERTED>; >>> I have serious doubts that you run this code... if it does not even >>> compile. Sorry, I cannot accept code that does not compile and was not >>> tested. >>> >>> Please, test your DTS on top of current Linux tree, which would be one of: >>> 1. Linus' master branch: v4.8-rc6, >>> 2. one of my branches (for-next, next/dt etc), >> When I sent those patches, I tested in "Add linux-next specific files for >> 20160907" > > OK, good, but please tell me why kbuild reported that build error? > I agree with Krzysztof, it doesn't seem that you tested the exact version that was posted. You will need the following change to make the DTS build in latest linux-next: So please squash that change and resend. Best regards, diff --git a/arch/arm/boot/dts/exynos4412-itop-elite.dts b/arch/arm/boot/dts/exynos4412-itop-elite.dts index dd83689892ff..8559f891a740 100644 --- a/arch/arm/boot/dts/exynos4412-itop-elite.dts +++ b/arch/arm/boot/dts/exynos4412-itop-elite.dts @@ -14,6 +14,7 @@ */ /dts-v1/; +#include #include #include "exynos4412-itop-scp-core.dtsi"