| Message ID | 1f57f120e915ea9af75a45f48c8ef2f446d10486.1548052878.git.baolin.wang@linaro.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Add new device nodes for Spreadtrum SC9860 platform | expand |
On Mon, Jan 21, 2019 at 8:39 AM Baolin Wang <baolin.wang@linaro.org> wrote: > > Add charger device node and related battery node for SC2731 PMIC. > > Signed-off-by: Baolin Wang <baolin.wang@linaro.org> > --- > arch/arm64/boot/dts/sprd/sc2731.dtsi | 6 ++++++ > arch/arm64/boot/dts/sprd/sp9860g-1h10.dts | 16 ++++++++++++++++ > 2 files changed, 22 insertions(+) > > diff --git a/arch/arm64/boot/dts/sprd/sc2731.dtsi b/arch/arm64/boot/dts/sprd/sc2731.dtsi > index a2edc25..b52eaf0 100644 > --- a/arch/arm64/boot/dts/sprd/sc2731.dtsi > +++ b/arch/arm64/boot/dts/sprd/sc2731.dtsi > @@ -17,6 +17,12 @@ > #address-cells = <1>; > #size-cells = <0>; > > + charger@0 { > + compatible = "sprd,sc27xx-charger", "sprd,sc2731-charger"; > + reg = <0x0>; > + monitored-battery = <&bat>; > + }; I see some of these have already slipped through, but we should probably fix those and not add new ones: "sprd,sc27xx-charger" is not an appropriate compatible string, because it has a 'xx' wildcard. What you should have instead is to list compatibility with specific older models. You also need to have the more generic string as the last one, not the first. Arnd
diff --git a/arch/arm64/boot/dts/sprd/sc2731.dtsi b/arch/arm64/boot/dts/sprd/sc2731.dtsi index a2edc25..b52eaf0 100644 --- a/arch/arm64/boot/dts/sprd/sc2731.dtsi +++ b/arch/arm64/boot/dts/sprd/sc2731.dtsi @@ -17,6 +17,12 @@ #address-cells = <1>; #size-cells = <0>; + charger@0 { + compatible = "sprd,sc27xx-charger", "sprd,sc2731-charger"; + reg = <0x0>; + monitored-battery = <&bat>; + }; + led-controller@200 { compatible = "sprd,sc27xx-bltc", "sprd,sc2731-bltc"; reg = <0x200>; diff --git a/arch/arm64/boot/dts/sprd/sp9860g-1h10.dts b/arch/arm64/boot/dts/sprd/sp9860g-1h10.dts index 3bd18e3..2a963bd 100644 --- a/arch/arm64/boot/dts/sprd/sp9860g-1h10.dts +++ b/arch/arm64/boot/dts/sprd/sp9860g-1h10.dts @@ -41,6 +41,22 @@ #size-cells = <2>; ranges; }; + + bat: battery { + compatible = "simple-battery"; + charge-full-design-microamp-hours = <1900000>; + charge-term-current-microamp = <120000>; + constant_charge_voltage_max_microvolt = <4350000>; + internal-resistance-micro-ohms = <250000>; + ocv-capacity-celsius = <20>; + ocv-capacity-table-0 = <4185000 100>, <4113000 95>, <4066000 90>, + <4022000 85>, <3983000 80>, <3949000 75>, + <3917000 70>, <3889000 65>, <3864000 60>, + <3835000 55>, <3805000 50>, <3787000 45>, + <3777000 40>, <3773000 35>, <3770000 30>, + <3765000 25>, <3752000 20>, <3724000 15>, + <3680000 10>, <3605000 5>, <3400000 0>; + }; }; &uart0 {
Add charger device node and related battery node for SC2731 PMIC. Signed-off-by: Baolin Wang <baolin.wang@linaro.org> --- arch/arm64/boot/dts/sprd/sc2731.dtsi | 6 ++++++ arch/arm64/boot/dts/sprd/sp9860g-1h10.dts | 16 ++++++++++++++++ 2 files changed, 22 insertions(+)