| Message ID | 20009.28803.497535.598471@pilspetsen.it.uu.se (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Fri, Jul 22, 2011 at 02:43:47PM +0200, Mikael Pettersson wrote: > Building 3.0 for an n2100 (plat-iop) results in: > > In file included from arch/arm/plat-iop/cp6.c:20: > /tmp/linux-3.0/arch/arm/include/asm/traps.h:12: warning: 'struct pt_regs' declared inside parameter list > /tmp/linux-3.0/arch/arm/include/asm/traps.h:12: warning: its scope is only this definition or declaration, which is probably not what you want > /tmp/linux-3.0/arch/arm/include/asm/traps.h:48: warning: 'struct pt_regs' declared inside parameter list > /tmp/linux-3.0/arch/arm/include/asm/traps.h:48: warning: 'struct task_struct' declared inside parameter list > arch/arm/plat-iop/cp6.c:45: warning: initialization from incompatible pointer type > > The pt_regs and incompatible pointer type warnings are fixed by including > <asm/ptrace.h> before <asm/traps.h>. Nothing here depends on task_struct, > so that warning can be fixed by a forward struct declaration. Why not add a forward declaration of struct pt_regs and task_struct to asm/traps.h ?
--- linux-3.0/arch/arm/plat-iop/cp6.c.~1~ 2011-07-22 12:01:07.000000000 +0200 +++ linux-3.0/arch/arm/plat-iop/cp6.c 2011-07-22 14:26:51.000000000 +0200 @@ -17,8 +17,9 @@ * */ #include <linux/init.h> -#include <asm/traps.h> #include <asm/ptrace.h> +struct task_struct; +#include <asm/traps.h> static int cp6_trap(struct pt_regs *regs, unsigned int instr) {
Building 3.0 for an n2100 (plat-iop) results in: In file included from arch/arm/plat-iop/cp6.c:20: /tmp/linux-3.0/arch/arm/include/asm/traps.h:12: warning: 'struct pt_regs' declared inside parameter list /tmp/linux-3.0/arch/arm/include/asm/traps.h:12: warning: its scope is only this definition or declaration, which is probably not what you want /tmp/linux-3.0/arch/arm/include/asm/traps.h:48: warning: 'struct pt_regs' declared inside parameter list /tmp/linux-3.0/arch/arm/include/asm/traps.h:48: warning: 'struct task_struct' declared inside parameter list arch/arm/plat-iop/cp6.c:45: warning: initialization from incompatible pointer type The pt_regs and incompatible pointer type warnings are fixed by including <asm/ptrace.h> before <asm/traps.h>. Nothing here depends on task_struct, so that warning can be fixed by a forward struct declaration. Signed-off-by: Mikael Pettersson <mikpe@it.uu.se> ---