From patchwork Mon Jun 20 17:34:45 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Felipe Balbi X-Patchwork-Id: 897862 Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) by demeter2.kernel.org (8.14.4/8.14.4) with ESMTP id p5KHZ9bj006687 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO) for ; Mon, 20 Jun 2011 17:35:30 GMT Received: from canuck.infradead.org ([2001:4978:20e::1]) by merlin.infradead.org with esmtps (Exim 4.76 #1 (Red Hat Linux)) id 1QYiNE-0003Ru-FX; Mon, 20 Jun 2011 17:34:56 +0000 Received: from localhost ([127.0.0.1] helo=canuck.infradead.org) by canuck.infradead.org with esmtp (Exim 4.76 #1 (Red Hat Linux)) id 1QYiNE-00075M-3W; Mon, 20 Jun 2011 17:34:56 +0000 Received: from na3sys009aog102.obsmtp.com ([74.125.149.69]) by canuck.infradead.org with smtps (Exim 4.76 #1 (Red Hat Linux)) id 1QYiNA-000753-Ql for linux-arm-kernel@lists.infradead.org; Mon, 20 Jun 2011 17:34:54 +0000 Received: from mail-fx0-f49.google.com ([209.85.161.49]) (using TLSv1) by na3sys009aob102.postini.com ([74.125.148.12]) with SMTP ID DSNKTf+Eud3f3FgcIZ4p6iLt1ALDqp3b6Zx4@postini.com; Mon, 20 Jun 2011 10:34:52 PDT Received: by mail-fx0-f49.google.com with SMTP id 14so920688fxm.22 for ; Mon, 20 Jun 2011 10:34:49 -0700 (PDT) Received: by 10.223.40.198 with SMTP id l6mr2753375fae.14.1308591289331; Mon, 20 Jun 2011 10:34:49 -0700 (PDT) Received: from localhost (cs181221225.pp.htv.fi [82.181.221.225]) by mx.google.com with ESMTPS id q14sm2942243faa.3.2011.06.20.10.34.46 (version=TLSv1/SSLv3 cipher=OTHER); Mon, 20 Jun 2011 10:34:48 -0700 (PDT) Date: Mon, 20 Jun 2011 20:34:45 +0300 From: Felipe Balbi To: Viliam Mateicka Subject: Re: [PATCH] s3c2410_udc: fix custom UDC command handling Message-ID: <20110620173444.GG26623@legolas.emea.dhcp.ti.com> References: <20110620151522.GN14262@legolas.emea.dhcp.ti.com> <20110620153645.GQ14262@legolas.emea.dhcp.ti.com> <20110620160650.GA26623@legolas.emea.dhcp.ti.com> <20110620170551.GE26623@legolas.emea.dhcp.ti.com> MIME-Version: 1.0 In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) X-CRM114-Version: 20090807-BlameThorstenAndJenny ( TRE 0.7.6 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20110620_133453_119813_9B4FC6BF X-CRM114-Status: GOOD ( 19.19 ) X-Spam-Score: -2.3 (--) X-Spam-Report: SpamAssassin version 3.3.1 on canuck.infradead.org summary: Content analysis details: (-2.3 points) pts rule name description ---- ---------------------- -------------------------------------------------- -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at http://www.dnswl.org/, medium trust [74.125.149.69 listed in list.dnswl.org] Cc: Kukjin Kim , Greg Kroah-Hartman , linux-kernel@vger.kernel.org, balbi@ti.com, Skacore Systems , linux-usb@vger.kernel.org, Alan Stern , Ben Dooks , linux-arm-kernel@lists.infradead.org X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.12 Precedence: list Reply-To: balbi@ti.com List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-arm-kernel-bounces@lists.infradead.org Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Greylist: IP, sender and recipient auto-whitelisted, not delayed by milter-greylist-4.2.6 (demeter2.kernel.org [140.211.167.43]); Mon, 20 Jun 2011 17:35:30 +0000 (UTC) Hi, On Mon, Jun 20, 2011 at 07:27:18PM +0200, Viliam Mateicka wrote: > I wonder then, who applies the patch first. One ass can't stop > progress (was there some progress afterall ?) because of one > line-break (which git produces by default afterall) and several > non-conforming whitespace conversions. I think you should stop > replying to me, because I'm kinda starting to like trolling afterall. Look, maybe you're just new to git/linux and that's fine. The only problem we had from day one is that you have been a complete dick when replying. If you go that road, that's what you'll get in return. Just so you see the properly formatted patch, I'm quoting below. See that there's no line breaks introduced by git. commit c27c9b5312f4b2a7e66ee772943355d77fc2c550 Author: Viliam Mateicka Date: Mon Jun 20 19:08:27 2011 +0300 usb: gadget: s3c2410_udc: fix custom UDC command handling There is a bug in Samsung's UDC driver, which is completely disabling the USB device when a custom UDC command is used. Following patch seems to get the right behavior (e.g. enabling pull-up instead of disabling then Vcc is applied). Signed-off-by: Viliam Mateicka [ balbi@ti.com : manually re-created the patch because author was unable to send a proper one ] Signed-off-by: Felipe Balbi (if you see any line breaks that's your mailer, it's better to check from the archives [1]) [1] http://marc.info/?l=linux-usb diff --git a/drivers/usb/gadget/s3c2410_udc.c b/drivers/usb/gadget/s3c2410_udc.c index 100f263..b6e1ca5 100644 --- a/drivers/usb/gadget/s3c2410_udc.c +++ b/drivers/usb/gadget/s3c2410_udc.c @@ -1567,7 +1567,7 @@ static void s3c2410_udc_command(enum s3c2410_udc_cmd_e cmd) return; if (udc_info->udc_command) { - udc_info->udc_command(S3C2410_UDC_P_DISABLE); + udc_info->udc_command(cmd); } else if (gpio_is_valid(udc_info->pullup_pin)) { int value;