From patchwork Tue Jun 21 09:15:29 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Russell King - ARM Linux X-Patchwork-Id: 900582 Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) by demeter1.kernel.org (8.14.4/8.14.4) with ESMTP id p5L9G172022646 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO) for ; Tue, 21 Jun 2011 09:16:22 GMT Received: from canuck.infradead.org ([2001:4978:20e::1]) by merlin.infradead.org with esmtps (Exim 4.76 #1 (Red Hat Linux)) id 1QYx3n-0006Vq-8v; Tue, 21 Jun 2011 09:15:51 +0000 Received: from localhost ([127.0.0.1] helo=canuck.infradead.org) by canuck.infradead.org with esmtp (Exim 4.76 #1 (Red Hat Linux)) id 1QYx3m-0000Br-Rh; Tue, 21 Jun 2011 09:15:50 +0000 Received: from [2002:4e20:1eda::1] (helo=caramon.arm.linux.org.uk) by canuck.infradead.org with esmtps (Exim 4.76 #1 (Red Hat Linux)) id 1QYx3i-0000BX-3g for linux-arm-kernel@lists.infradead.org; Tue, 21 Jun 2011 09:15:47 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=arm.linux.org.uk; s=caramon; h=Sender:In-Reply-To:Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date; bh=x8dq8QG11Z2hXOGdYut4VFXVBohNZ1N415uG9728CGs=; b=KXEtMNzTprHalHvNwdwL/Ctjpu7FmTJ8fa7/YHhaNn7XP3QXkAwCglpzRdnW8A8tl6bDhvgkHv4+s3T/wSZ+kfsy6Kn5JtkCP3nceyAr9nWQYc3h2HhS4zDJgbTSKmHruUJC0VH4X/Rb8SHwmnQXDbhZZ4OeXQx7qaDMhs1f1o0=; Received: from n2100.arm.linux.org.uk ([2002:4e20:1eda:1:214:fdff:fe10:4f86]) by caramon.arm.linux.org.uk with esmtpsa (TLSv1:AES256-SHA:256) (Exim 4.72) (envelope-from ) id 1QYx3T-00026f-Jw; Tue, 21 Jun 2011 10:15:32 +0100 Received: from linux by n2100.arm.linux.org.uk with local (Exim 4.72) (envelope-from ) id 1QYx3S-00061r-A5; Tue, 21 Jun 2011 10:15:30 +0100 Date: Tue, 21 Jun 2011 10:15:29 +0100 From: Russell King - ARM Linux To: TAO HU Subject: Re: Bug in _und_usr on dual-core ARM? Message-ID: <20110621091529.GA22868@n2100.arm.linux.org.uk> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.19 (2009-01-05) X-CRM114-Version: 20090807-BlameThorstenAndJenny ( TRE 0.7.6 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20110621_051546_725511_7592B6F8 X-CRM114-Status: GOOD ( 13.91 ) X-Spam-Score: 1.2 (+) X-Spam-Report: SpamAssassin version 3.3.1 on canuck.infradead.org summary: Content analysis details: (1.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 1.3 RDNS_NONE Delivered to internal network by a host with no rDNS Cc: linux-omap , Zhou Ming-a17711 , linux-arm-kernel@lists.infradead.org X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-arm-kernel-bounces@lists.infradead.org Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Greylist: IP, sender and recipient auto-whitelisted, not delayed by milter-greylist-4.2.6 (demeter1.kernel.org [140.211.167.41]); Tue, 21 Jun 2011 09:16:23 +0000 (UTC) On Tue, Jun 21, 2011 at 04:31:19PM +0800, TAO HU wrote: > Hi, All > > We got an issue on our OMAP4 SMP system. > Looks like __und_user(), which was triggered by a user space > exception, got a page fault hence lead to might_sleep() failure. Could you see whether this patch prevents the warning please. diff --git a/arch/arm/mm/fault.c b/arch/arm/mm/fault.c index bc0e1d8..d52b940 100644 --- a/arch/arm/mm/fault.c +++ b/arch/arm/mm/fault.c @@ -289,7 +289,7 @@ do_page_fault(unsigned long addr, unsigned int fsr, struct pt_regs *regs) * If we're in an interrupt or have no user * context, we must not take the fault.. */ - if (in_atomic() || !mm) + if (in_atomic() || irqs_disabled() || !mm) goto no_context; /*