diff mbox

ARM: exynos4: Add TWD base address

Message ID 20110727042406.GA14024@july (mailing list archive)
State New, archived
Headers show

Commit Message

Kyungmin Park July 27, 2011, 4:24 a.m. UTC 
From: Kyungmin Park <kyungmin.park@samsung.com>

When use the s5p_timer for EXYNOS4210 EVT0, it's required.
Other s5p platform is guided from CONFIG_LOCAL_TIMER

Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
---

Comments

Kim Kukjin Aug. 12, 2011, 9:47 a.m. UTC | #1 
Kyungmin Park wrote:
> 
> From: Kyungmin Park <kyungmin.park@samsung.com>
> 
> When use the s5p_timer for EXYNOS4210 EVT0, it's required.
> Other s5p platform is guided from CONFIG_LOCAL_TIMER
> 
> Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
> ---
> diff --git a/arch/arm/plat-s5p/s5p-time.c b/arch/arm/plat-s5p/s5p-time.c
> index c833e7b..bdf5430 100644
> --- a/arch/arm/plat-s5p/s5p-time.c
> +++ b/arch/arm/plat-s5p/s5p-time.c
> @@ -409,6 +409,9 @@ static void __init s5p_timer_resources(void)
> 
>  static void __init s5p_timer_init(void)
>  {
> +#ifdef CONFIG_LOCAL_TIMERS
> +	twd_base = S5P_VA_TWD;
> +#endif
>  	s5p_timer_resources();
>  	s5p_clockevent_init();
>  	s5p_clocksource_init();

As we talked about this at Linaro Connect, this is wrong. Basically
EXYNOS4210 uses MCT and the ARM_TWD cannot be used at one time on
EXYNOS4210.

Thanks.

Best regards,
Kgene.
--
Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.
diff mbox

Patch

diff --git a/arch/arm/plat-s5p/s5p-time.c b/arch/arm/plat-s5p/s5p-time.c
index c833e7b..bdf5430 100644
--- a/arch/arm/plat-s5p/s5p-time.c
+++ b/arch/arm/plat-s5p/s5p-time.c
@@ -409,6 +409,9 @@  static void __init s5p_timer_resources(void)
 
 static void __init s5p_timer_init(void)
 {
+#ifdef CONFIG_LOCAL_TIMERS
+	twd_base = S5P_VA_TWD;
+#endif
 	s5p_timer_resources();
 	s5p_clockevent_init();
 	s5p_clocksource_init();