From patchwork Fri Aug 19 11:08:22 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Will Deacon X-Patchwork-Id: 1079042 Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) by demeter2.kernel.org (8.14.4/8.14.4) with ESMTP id p7JB91MP025041 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO) for ; Fri, 19 Aug 2011 11:09:27 GMT Received: from canuck.infradead.org ([2001:4978:20e::1]) by merlin.infradead.org with esmtps (Exim 4.76 #1 (Red Hat Linux)) id 1QuMwC-0007H6-Hf; Fri, 19 Aug 2011 11:08:32 +0000 Received: from localhost ([127.0.0.1] helo=canuck.infradead.org) by canuck.infradead.org with esmtp (Exim 4.76 #1 (Red Hat Linux)) id 1QuMwC-0003Jf-3C; Fri, 19 Aug 2011 11:08:32 +0000 Received: from cam-admin0.cambridge.arm.com ([217.140.96.50]) by canuck.infradead.org with esmtp (Exim 4.76 #1 (Red Hat Linux)) id 1QuMw8-0003JM-Nr for linux-arm-kernel@lists.infradead.org; Fri, 19 Aug 2011 11:08:29 +0000 Received: from e102144-lin.cambridge.arm.com (e102144-lin.cambridge.arm.com [10.1.69.60]) by cam-admin0.cambridge.arm.com (8.12.6/8.12.6) with ESMTP id p7JB7E11008924; Fri, 19 Aug 2011 12:07:14 +0100 (BST) Date: Fri, 19 Aug 2011 12:08:22 +0100 From: Will Deacon To: Shawn Guo Subject: Re: [PATCH 1/3] ARM: debug: use kconfig choice for selecting DEBUG_LL UART Message-ID: <20110819110822.GB8918@e102144-lin.cambridge.arm.com> References: <1313530873-24961-1-git-send-email-will.deacon@arm.com> <20110818161105.GA12527@S2100-06.ap.freescale.net> <20110818160712.GA26691@e102144-lin.cambridge.arm.com> <20110819045956.GB12527@S2100-06.ap.freescale.net> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20110819045956.GB12527@S2100-06.ap.freescale.net> User-Agent: Mutt/1.5.20 (2009-06-14) X-CRM114-Version: 20090807-BlameThorstenAndJenny ( TRE 0.7.6 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20110819_070829_064163_BF91EBBC X-CRM114-Status: GOOD ( 24.42 ) X-Spam-Score: -3.3 (---) X-Spam-Report: SpamAssassin version 3.3.1 on canuck.infradead.org summary: Content analysis details: (-3.3 points) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 RP_MATCHES_RCVD Envelope sender domain matches handover relay domain -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at http://www.dnswl.org/, medium trust [217.140.96.50 listed in list.dnswl.org] Cc: Linus Walleij , "linux-arm-kernel@lists.infradead.org" X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-arm-kernel-bounces@lists.infradead.org Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Greylist: IP, sender and recipient auto-whitelisted, not delayed by milter-greylist-4.2.6 (demeter2.kernel.org [140.211.167.43]); Fri, 19 Aug 2011 11:09:27 +0000 (UTC) On Fri, Aug 19, 2011 at 05:59:57AM +0100, Shawn Guo wrote: > On Thu, Aug 18, 2011 at 05:07:12PM +0100, Will Deacon wrote: > > I'm not sure that sorting this list in alphabetical order is a good idea. > > This is a Kconfig choice, so the default value is the first one in the list > > that has its dependencies satisfied. Therefore, the ordering has a direct > > impact on the default UART selection. > > > I'm unsure that the default UART selection makes much sense here. > When we build so many platforms into single image, it's hard to say > which one should be the default. People anyway need to check if the > the UART selection matches the platform they are debugging on. Ok, how about having the default choice as a dummy option which doesn't correspond to a UART?: That way, you really have to select the UART for DEBUG_LL to be enabled. > BTW, I just posted one patch for imx based on your series. Are you > interested in folding it into yours? Yep, I'll pick it up once Sascha is happy with it. If we go with the above, I'm happy to make the necessary changes. Cheers, Will diff --git a/arch/arm/Kconfig.debug b/arch/arm/Kconfig.debug index f23975a..455bc8c 100644 --- a/arch/arm/Kconfig.debug +++ b/arch/arm/Kconfig.debug @@ -65,8 +65,12 @@ config DEBUG_USER # These options are only for real kernel hackers who want to get their hands dirty. config DEBUG_LL + bool + +config DEBUG_LL_UART bool "Kernel low-level debugging functions" depends on DEBUG_KERNEL + select DEBUG_LL if !DEBUG_UART_NONE help Say Y here to include definitions of printascii, printch, printhex in the kernel. This is helpful if you are debugging code that @@ -74,7 +78,12 @@ config DEBUG_LL choice prompt "Kernel low-level debugging port" - depends on DEBUG_LL + depends on DEBUG_LL_UART && (FOOTBRIDGE || ARCH_CLPS711X || \ + PLAT_SAMSUNG || ARCH_REALVIEW) + default DEBUG_UART_NONE + + config DEBUG_UART_NONE + bool "No UART selected (default)" config DEBUG_DC21285_PORT bool "Kernel low-level debugging messages via footbridge serial port"