From patchwork Wed Sep 5 01:14:24 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tony Lindgren X-Patchwork-Id: 1404731 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork2.kernel.org Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) by patchwork2.kernel.org (Postfix) with ESMTP id AFE36DF280 for ; Wed, 5 Sep 2012 01:17:55 +0000 (UTC) Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.76 #1 (Red Hat Linux)) id 1T94CQ-0005IR-AN; Wed, 05 Sep 2012 01:14:34 +0000 Received: from mho-01-ewr.mailhop.org ([204.13.248.71]) by merlin.infradead.org with esmtps (Exim 4.76 #1 (Red Hat Linux)) id 1T94CJ-0005Gg-HX for linux-arm-kernel@lists.infradead.org; Wed, 05 Sep 2012 01:14:30 +0000 Received: from c-98-234-237-12.hsd1.ca.comcast.net ([98.234.237.12] helo=localhost.localdomain) by mho-01-ewr.mailhop.org with esmtpa (Exim 4.72) (envelope-from ) id 1T94CH-0005mR-IH; Wed, 05 Sep 2012 01:14:26 +0000 Received: from Mutt by mutt-smtp-wrapper.pl 1.2 (www.zdo.com/articles/mutt-smtp-wrapper.shtml) X-Mail-Handler: Dyn Standard SMTP by Dyn X-Originating-IP: 98.234.237.12 X-Report-Abuse-To: abuse@dyndns.com (see http://www.dyndns.com/services/sendlabs/outbound_abuse.html for abuse reporting information) X-MHO-User: U2FsdGVkX18qR3vS0M28L2/sUsGoCVcB Date: Tue, 4 Sep 2012 18:14:24 -0700 From: Tony Lindgren To: linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 7/9] ARM: OMAP2+: Prepare for irqs.h removal Message-ID: <20120905011423.GZ1303@atomide.com> References: <20120831004828.28732.902.stgit@muffinssi.local> <20120831005237.28732.96766.stgit@muffinssi.local> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20120831005237.28732.96766.stgit@muffinssi.local> User-Agent: Mutt/1.5.20 (2009-06-14) X-Spam-Note: CRM114 invocation failed X-Spam-Score: -1.9 (-) X-Spam-Report: SpamAssassin version 3.3.2 on merlin.infradead.org summary: Content analysis details: (-1.9 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/, no trust [204.13.248.71 listed in list.dnswl.org] -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] 0.0 UNPARSEABLE_RELAY Informational: message has unparseable relay lines Cc: Omar Ramirez Luna , Greg Kroah-Hartman , linux-omap@vger.kernel.org X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-arm-kernel-bounces@lists.infradead.org Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org * Tony Lindgren [120830 17:53]: > As the interrupts should only be defined in the platform_data, and > eventually coming from device tree, there's no need to define them > in header files. > > Let's remove the hardcoded references to irqs.h and fix up the includes > so we don't rely on headers included in irqs.h. While at it, sort > the includes the standard way. Turns out this patch was not quite working with SPARSE_IRQ, we have to add OMAP_INTC_START for that. Also fixed up is compile for drivers/staging/tidspbridge. Updated patch below. Regards, Tony From: Tony Lindgren Date: Mon, 27 Aug 2012 17:43:01 -0700 Subject: [PATCH] ARM: OMAP2+: Prepare for irqs.h removal As the interrupts should only be defined in the platform_data, and eventually coming from device tree, there's no need to define them in header files. Let's remove the hardcoded references to irqs.h and fix up the includes so we don't rely on headers included in irqs.h. Note that we're defining OMAP_INTC_START as 0 to the interrupts. This will be needed when we enable SPARSE_IRQ. While at it, sort the includes the standard way, and add the trailing commas where they are missing in the related data structures. Note that for drivers/staging/tidspbridge we just define things locally. Signed-off-by: Tony Lindgren diff --git a/arch/arm/mach-omap2/board-2430sdp.c b/arch/arm/mach-omap2/board-2430sdp.c index cacc498..7e31981 100644 --- a/arch/arm/mach-omap2/board-2430sdp.c +++ b/arch/arm/mach-omap2/board-2430sdp.c @@ -28,19 +28,20 @@ #include #include -#include #include #include #include -#include "common.h" #include #include #include +#include + #include