| Message ID | 20121024200431.GE6713@beefymiracle.amer.corp.natinst.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
> -----Original Message----- > From: Josh Cartwright [mailto:josh.cartwright@ni.com] > Sent: Wednesday, October 24, 2012 10:05 PM > To: arm@kernel.org; Arnd Bergmann > Cc: linux-kernel@vger.kernel.org; linux-arm-kernel@lists.infradead.org; John > Linn; Nick Bowler; Michal Simek > Subject: [PATCH v4 4/5] ARM: annotate VMALLOC_END definition with _AC > > This makes the definition of VMALLOC_END suitable for use within assembly > code. This is necessary to allow the use of VMALLOC_END in defining where the > early uart is mapped for use with DEBUG_LL. > > Signed-off-by: Josh Cartwright <josh.cartwright@ni.com> > Acked-by: Arnd Bergmann <arnd@arndb.de> > --- > arch/arm/include/asm/pgtable.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm/include/asm/pgtable.h b/arch/arm/include/asm/pgtable.h > index 08c1231..72904a2 100644 > --- a/arch/arm/include/asm/pgtable.h > +++ b/arch/arm/include/asm/pgtable.h > @@ -40,7 +40,7 @@ > */ > #define VMALLOC_OFFSET (8*1024*1024) > #define VMALLOC_START (((unsigned long)high_memory + > VMALLOC_OFFSET) & ~(VMALLOC_OFFSET-1)) > -#define VMALLOC_END 0xff000000UL > +#define VMALLOC_END _AC(0xff000000,UL) This shouldn't be the part of this series but should go to mainline through different tree. Arnd, Olof: Can you take this patch to your arm-soc tree? I don't think it is a good workstyle to propose it to mainline through zynq soc tree. What do you think? Thanks, Michal
On Saturday 27 October 2012, Michal Simek wrote: > > diff --git a/arch/arm/include/asm/pgtable.h b/arch/arm/include/asm/pgtable.h > > index 08c1231..72904a2 100644 > > --- a/arch/arm/include/asm/pgtable.h > > +++ b/arch/arm/include/asm/pgtable.h > > @@ -40,7 +40,7 @@ > > */ > > #define VMALLOC_OFFSET (8*1024*1024) > > #define VMALLOC_START (((unsigned long)high_memory + > > VMALLOC_OFFSET) & ~(VMALLOC_OFFSET-1)) > > -#define VMALLOC_END 0xff000000UL > > +#define VMALLOC_END _AC(0xff000000,UL) > > This shouldn't be the part of this series but should go to mainline through different tree. > Arnd, Olof: Can you take this patch to your arm-soc tree? > > I don't think it is a good workstyle to propose it to mainline through zynq soc tree. > What do you think? The arm-soc tree is not the right place either, this is architecture code which is in Russell's domain. I would suggest getting an Ack from Russell if he's ok with it and then merging it together with your other changes into arm-soc. Arnd
> -----Original Message----- > From: Arnd Bergmann [mailto:arnd@arndb.de] > Sent: Tuesday, October 30, 2012 11:22 PM > To: Michal Simek > Cc: Josh Cartwright; arm@kernel.org; linux-kernel@vger.kernel.org; linux-arm- > kernel@lists.infradead.org; John Linn; Nick Bowler; Russell King - ARM Linux > Subject: Re: [PATCH v4 4/5] ARM: annotate VMALLOC_END definition with _AC > > On Saturday 27 October 2012, Michal Simek wrote: > > > diff --git a/arch/arm/include/asm/pgtable.h > > > b/arch/arm/include/asm/pgtable.h index 08c1231..72904a2 100644 > > > --- a/arch/arm/include/asm/pgtable.h > > > +++ b/arch/arm/include/asm/pgtable.h > > > @@ -40,7 +40,7 @@ > > > */ > > > #define VMALLOC_OFFSET (8*1024*1024) > > > #define VMALLOC_START (((unsigned long)high_memory + > > > VMALLOC_OFFSET) & ~(VMALLOC_OFFSET-1)) > > > -#define VMALLOC_END 0xff000000UL > > > +#define VMALLOC_END _AC(0xff000000,UL) > > > > This shouldn't be the part of this series but should go to mainline through > different tree. > > Arnd, Olof: Can you take this patch to your arm-soc tree? > > > > I don't think it is a good workstyle to propose it to mainline through zynq soc > tree. > > What do you think? > > The arm-soc tree is not the right place either, this is architecture code which is in > Russell's domain. I would suggest getting an Ack from Russell if he's ok with it > and then merging it together with your other changes into arm-soc. That's what I thought too. Not sure if Josh wants to push this to mainline. Thanks, Michal This email and any attachments are intended for the sole use of the named recipient(s) and contain(s) confidential information that may be proprietary, privileged or copyrighted under applicable law. If you are not the intended recipient, do not read, copy, or forward this email message or any attachments. Delete this email message and any attachments immediately.
On Wed, Oct 31, 2012 at 08:43:35AM +0000, Michal Simek wrote: > > > > -----Original Message----- > > From: Arnd Bergmann [mailto:arnd@arndb.de] > > Sent: Tuesday, October 30, 2012 11:22 PM > > To: Michal Simek > > Cc: Josh Cartwright; arm@kernel.org; linux-kernel@vger.kernel.org; linux-arm- > > kernel@lists.infradead.org; John Linn; Nick Bowler; Russell King - ARM Linux > > Subject: Re: [PATCH v4 4/5] ARM: annotate VMALLOC_END definition with _AC > > > > On Saturday 27 October 2012, Michal Simek wrote: > > > > diff --git a/arch/arm/include/asm/pgtable.h > > > > b/arch/arm/include/asm/pgtable.h index 08c1231..72904a2 100644 > > > > --- a/arch/arm/include/asm/pgtable.h > > > > +++ b/arch/arm/include/asm/pgtable.h > > > > @@ -40,7 +40,7 @@ > > > > */ > > > > #define VMALLOC_OFFSET (8*1024*1024) > > > > #define VMALLOC_START (((unsigned long)high_memory + > > > > VMALLOC_OFFSET) & ~(VMALLOC_OFFSET-1)) > > > > -#define VMALLOC_END 0xff000000UL > > > > +#define VMALLOC_END _AC(0xff000000,UL) > > > > > > This shouldn't be the part of this series but should go to mainline through > > different tree. > > > Arnd, Olof: Can you take this patch to your arm-soc tree? > > > > > > I don't think it is a good workstyle to propose it to mainline through zynq soc > > tree. > > > What do you think? > > > > The arm-soc tree is not the right place either, this is architecture code which is in > > Russell's domain. I would suggest getting an Ack from Russell if he's ok with it > > and then merging it together with your other changes into arm-soc. > > That's what I thought too. > Not sure if Josh wants to push this to mainline. The patch is not relevant anymore. It was needed when the virtual address of the early uart mapping was defined via VMALLOC_END. That was causing us problems, so we ended up choosing a fixed, known working address within the vmalloc region to map the uart. Thanks, Josh
diff --git a/arch/arm/include/asm/pgtable.h b/arch/arm/include/asm/pgtable.h index 08c1231..72904a2 100644 --- a/arch/arm/include/asm/pgtable.h +++ b/arch/arm/include/asm/pgtable.h @@ -40,7 +40,7 @@ */ #define VMALLOC_OFFSET (8*1024*1024) #define VMALLOC_START (((unsigned long)high_memory + VMALLOC_OFFSET) & ~(VMALLOC_OFFSET-1)) -#define VMALLOC_END 0xff000000UL +#define VMALLOC_END _AC(0xff000000,UL) #define LIBRARY_TEXT_START 0x0c000000