From patchwork Thu Oct 25 17:56:07 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Nishanth Menon X-Patchwork-Id: 1646251 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork1.kernel.org Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) by patchwork1.kernel.org (Postfix) with ESMTP id 308B03FE1C for ; Thu, 25 Oct 2012 17:58:17 +0000 (UTC) Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.76 #1 (Red Hat Linux)) id 1TRRfH-00075X-Hg; Thu, 25 Oct 2012 17:56:20 +0000 Received: from arroyo.ext.ti.com ([192.94.94.40]) by merlin.infradead.org with esmtps (Exim 4.76 #1 (Red Hat Linux)) id 1TRRfE-00075F-6T for linux-arm-kernel@lists.infradead.org; Thu, 25 Oct 2012 17:56:16 +0000 Received: from dlelxv30.itg.ti.com ([172.17.2.17]) by arroyo.ext.ti.com (8.13.7/8.13.7) with ESMTP id q9PHu7Ti030807; Thu, 25 Oct 2012 12:56:07 -0500 Received: from DLEE74.ent.ti.com (dlee74.ent.ti.com [157.170.170.8]) by dlelxv30.itg.ti.com (8.13.8/8.13.8) with ESMTP id q9PHu7HP023990; Thu, 25 Oct 2012 12:56:07 -0500 Received: from dlelxv22.itg.ti.com (172.17.1.197) by DLEE74.ent.ti.com (157.170.170.8) with Microsoft SMTP Server id 14.1.323.3; Thu, 25 Oct 2012 12:56:07 -0500 Received: from localhost (kahuna.am.dhcp.ti.com [128.247.75.12]) by dlelxv22.itg.ti.com (8.13.8/8.13.8) with ESMTP id q9PHu7Ta010221; Thu, 25 Oct 2012 12:56:07 -0500 Date: Thu, 25 Oct 2012 12:56:07 -0500 From: Nishanth Menon To: Kevin Hilman Subject: Re: [PATCH] ARM: OMAP2+: PM: add missing newline to VC warning message Message-ID: <20121025175607.GA21937@kahuna> References: <1351186501-32223-1-git-send-email-khilman@deeprootsystems.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1351186501-32223-1-git-send-email-khilman@deeprootsystems.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-Spam-Note: CRM114 invocation failed X-Spam-Score: -7.6 (-------) X-Spam-Report: SpamAssassin version 3.3.2 on merlin.infradead.org summary: Content analysis details: (-7.6 points) pts rule name description ---- ---------------------- -------------------------------------------------- -5.0 RCVD_IN_DNSWL_HI RBL: Sender listed at http://www.dnswl.org/, high trust [192.94.94.40 listed in list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record -0.7 RP_MATCHES_RCVD Envelope sender domain matches handover relay domain -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] Cc: Tony Lindgren , Russell King , linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-arm-kernel-bounces@lists.infradead.org Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org On 10:35-20121025, Kevin Hilman wrote: > From: Kevin Hilman > > Add missing newline to warning message to avoid annoying > wrapping problems during kernel boot like this one: > > omap_vc_i2c_init: I2C config for vdd_iva does not match other channels (0). > omap_vc_i2c_init: I2C config for vdd_mpu does not match other channels (0).Power Management for TI OMAP4. > > Reported-by: Russell King > Signed-off-by: Kevin Hilman > --- > arch/arm/mach-omap2/vc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm/mach-omap2/vc.c b/arch/arm/mach-omap2/vc.c > index 880249b..75878c3 100644 > --- a/arch/arm/mach-omap2/vc.c > +++ b/arch/arm/mach-omap2/vc.c > @@ -264,7 +264,7 @@ static void __init omap_vc_i2c_init(struct voltagedomain *voltdm) > > if (initialized) { > if (voltdm->pmic->i2c_high_speed != i2c_high_speed) > - pr_warn("%s: I2C config for vdd_%s does not match other channels (%u).", > + pr_warn("%s: I2C config for vdd_%s does not match other channels (%u).\n", > __func__, voltdm->name, i2c_high_speed); > return; > } Acked-by: Nishanth Menon while we are at it, could we clean up the pr_warning usage back to pr_warn as well? diff --git a/arch/arm/mach-omap2/vc.c b/arch/arm/mach-omap2/vc.c index 880249b..2d66f8c 100644 --- a/arch/arm/mach-omap2/vc.c +++ b/arch/arm/mach-omap2/vc.c @@ -186,7 +186,7 @@ int omap_vc_bypass_scale(struct voltagedomain *voltdm, loop_cnt++; if (retries_cnt > 10) { - pr_warning("%s: Retry count exceeded\n", __func__); + pr_warn("%s: Retry count exceeded\n", __func__); return -ETIMEDOUT; }