diff mbox

arm: socfpga: fix build break for allyesconfig

Message ID 20121026230052.GA24573@elf.ucw.cz (mailing list archive)
State New, archived
Headers show

Commit Message

Pavel Machek Oct. 26, 2012, 11 p.m. UTC 
Hi!

> > > If the above assembly file can only run on ARMv7, consider putting
> > > 
> > > 	.march	armv7
> > > 
> > > or similar before it.
> > 
> > My version of gas does not seem to recognize .march
> 
> Ah, that's because it's .arch not .march.  Please could you check with
> .arch instead.  If proven successful we should move the existing
> AFLAGS_xxx.o Makefile stuff into the assembly files concerned.

        .arch  armv7

results in

arch/arm/mach-socfpga/headsmp.S:21: Error: attempt to use an ARM
instruction on a Thumb-only processor -- `movw
r0,#:lower16:(0xffd08000+0x10)'
...

Using .arch armv7-a indeed works and is a very nice solution.

Signed-off-by: Pavel Machek <pavel@denx.de>

Comments

Arnd Bergmann Oct. 27, 2012, 10:43 a.m. UTC | #1 
On Friday 26 October 2012, Pavel Machek wrote:
> arch/arm/mach-socfpga/headsmp.S:21: Error: attempt to use an ARM
> instruction on a Thumb-only processor -- `movw
> r0,#:lower16:(0xffd08000+0x10)'
> ...
> 
> Using .arch armv7-a indeed works and is a very nice solution.
> 
> Signed-off-by: Pavel Machek <pavel@denx.de>
> 
> --- a/arch/arm/mach-socfpga/headsmp.S
> +++ b/arch/arm/mach-socfpga/headsmp.S
> @@ -11,6 +11,7 @@
>  #include <linux/init.h>
>  
>         __INIT
> +       .arch   armv7-a
>  
>  #define HPS_SYSMGR_ADDRESS     0xffd08000
>  #define CONFIG_SYSTEM_MANAGER  HPS_SYSMGR_ADDRESS
> 

Thanks, applied with new commit message.

	Arnd
Pavel Machek Oct. 27, 2012, 11:24 a.m. UTC | #2 
On Sat 2012-10-27 10:43:40, Arnd Bergmann wrote:
> On Friday 26 October 2012, Pavel Machek wrote:
> > arch/arm/mach-socfpga/headsmp.S:21: Error: attempt to use an ARM
> > instruction on a Thumb-only processor -- `movw
> > r0,#:lower16:(0xffd08000+0x10)'
> > ...
> > 
> > Using .arch armv7-a indeed works and is a very nice solution.
> > 
> > Signed-off-by: Pavel Machek <pavel@denx.de>
> > 
> > --- a/arch/arm/mach-socfpga/headsmp.S
> > +++ b/arch/arm/mach-socfpga/headsmp.S
> > @@ -11,6 +11,7 @@
> >  #include <linux/init.h>
> >  
> >         __INIT
> > +       .arch   armv7-a
> >  
> >  #define HPS_SYSMGR_ADDRESS     0xffd08000
> >  #define CONFIG_SYSTEM_MANAGER  HPS_SYSMGR_ADDRESS
> > 
> 
> Thanks, applied with new commit message.

Thanks!
									Pavel
diff mbox

Patch

--- a/arch/arm/mach-socfpga/headsmp.S
+++ b/arch/arm/mach-socfpga/headsmp.S
@@ -11,6 +11,7 @@ 
 #include <linux/init.h>
 
 	__INIT
+	.arch	armv7-a
 
 #define HPS_SYSMGR_ADDRESS	0xffd08000
 #define CONFIG_SYSTEM_MANAGER	HPS_SYSMGR_ADDRESS