diff mbox

ARM: mxs: select USB_ARCH_HAS_EHCI

Message ID 20130110034805.GF2265@S2101-09.ap.freescale.net (mailing list archive)
State New, archived
Headers show

Commit Message

Shawn Guo Jan. 10, 2013, 3:48 a.m. UTC 
On Wed, Jan 09, 2013 at 03:36:02PM +0100, Maxime Ripard wrote:
> Commit 09f6ffde introduced a dependency on USB_EHCI_HCD for the chipidea
> USB host driver, that in turns depends on USB_ARCH_HAS_EHCI.
> 
> If this symbol is not selected by the ARCH, we are not able to use the
> chipidea driver anymore.
> 
> Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com>
> ---
>  arch/arm/Kconfig |    1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
> index f95ba14..c77d1d1 100644
> --- a/arch/arm/Kconfig
> +++ b/arch/arm/Kconfig
> @@ -456,6 +456,7 @@ config ARCH_MXS
>  	select PINCTRL
>  	select SPARSE_IRQ
>  	select USE_OF
> +	select USB_ARCH_HAS_EHCI
>  	help
>  	  Support for Freescale MXS-based family of processors
>  

I prefer to fix it with the patch below.

Shawn

Comments

Maxime Ripard Jan. 10, 2013, 10:34 a.m. UTC | #1 
On 10/01/2013 04:48, Shawn Guo wrote:
> On Wed, Jan 09, 2013 at 03:36:02PM +0100, Maxime Ripard wrote:
> I prefer to fix it with the patch below.
> 
> Shawn
> 
> diff --git a/drivers/usb/Kconfig b/drivers/usb/Kconfig
> index 4c90b51..640ae6c 100644
> --- a/drivers/usb/Kconfig
> +++ b/drivers/usb/Kconfig
> @@ -37,6 +37,7 @@ config USB_ARCH_HAS_EHCI
>         default y if ARCH_W90X900
>         default y if ARCH_AT91
>         default y if ARCH_MXC
> +       default y if ARCH_MXS
>         default y if ARCH_OMAP3
>         default y if ARCH_CNS3XXX
>         default y if ARCH_VT8500
> 
> 

Ah yes, of course.
Do you want me to send a v2 with this fix, or do you want to do it yourself?

Maxime
Shawn Guo Jan. 10, 2013, 10:46 a.m. UTC | #2 
On Thu, Jan 10, 2013 at 11:34:05AM +0100, Maxime Ripard wrote:
> Do you want me to send a v2 with this fix, or do you want to do it yourself?
> 
It's your patch.  What I'm doing is just giving a comment.

Shawn
diff mbox

Patch

diff --git a/drivers/usb/Kconfig b/drivers/usb/Kconfig
index 4c90b51..640ae6c 100644
--- a/drivers/usb/Kconfig
+++ b/drivers/usb/Kconfig
@@ -37,6 +37,7 @@  config USB_ARCH_HAS_EHCI
        default y if ARCH_W90X900
        default y if ARCH_AT91
        default y if ARCH_MXC
+       default y if ARCH_MXS
        default y if ARCH_OMAP3
        default y if ARCH_CNS3XXX
        default y if ARCH_VT8500