From patchwork Tue Jan 22 06:11:18 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Shawn Guo X-Patchwork-Id: 2015461 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork1.kernel.org Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) by patchwork1.kernel.org (Postfix) with ESMTP id 828BD3FCDE for ; Tue, 22 Jan 2013 05:46:31 +0000 (UTC) Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.76 #1 (Red Hat Linux)) id 1TxWdp-0005z5-DY; Tue, 22 Jan 2013 05:43:25 +0000 Received: from co9ehsobe004.messaging.microsoft.com ([207.46.163.27] helo=co9outboundpool.messaging.microsoft.com) by merlin.infradead.org with esmtps (Exim 4.76 #1 (Red Hat Linux)) id 1TxWdl-0005yU-Kz for linux-arm-kernel@lists.infradead.org; Tue, 22 Jan 2013 05:43:22 +0000 Received: from mail18-co9-R.bigfish.com (10.236.132.238) by CO9EHSOBE017.bigfish.com (10.236.130.80) with Microsoft SMTP Server id 14.1.225.23; Tue, 22 Jan 2013 05:43:13 +0000 Received: from mail18-co9 (localhost [127.0.0.1]) by mail18-co9-R.bigfish.com (Postfix) with ESMTP id BAEE43A0172; Tue, 22 Jan 2013 05:43:13 +0000 (UTC) X-Forefront-Antispam-Report: CIP:70.37.183.190; KIP:(null); UIP:(null); IPV:NLI; H:mail.freescale.net; RD:none; EFVD:NLI X-SpamScore: -2 X-BigFish: VS-2(zz98dI1432I1447Izz1ee6h1de0h1202h1e76h1d1ah1d2ahzz177df4h17326ah8275eh8275dha1495iz2dh87h2a8h668h839h944hd25hf0ah1220h1288h12a5h12a9h12bdh137ah13b6h1441h1504h1537h153bh162dh1631h1758h18e1h1155h) X-FB-DOMAIN-IP-MATCH: fail Received: from mail18-co9 (localhost.localdomain [127.0.0.1]) by mail18-co9 (MessageSwitch) id 1358833390295753_8210; Tue, 22 Jan 2013 05:43:10 +0000 (UTC) Received: from CO9EHSMHS030.bigfish.com (unknown [10.236.132.242]) by mail18-co9.bigfish.com (Postfix) with ESMTP id 3A38A34005C; Tue, 22 Jan 2013 05:43:10 +0000 (UTC) Received: from mail.freescale.net (70.37.183.190) by CO9EHSMHS030.bigfish.com (10.236.130.40) with Microsoft SMTP Server (TLS) id 14.1.225.23; Tue, 22 Jan 2013 05:43:09 +0000 Received: from az84smr01.freescale.net (10.64.34.197) by 039-SN1MMR1-004.039d.mgd.msft.net (10.84.1.14) with Microsoft SMTP Server (TLS) id 14.2.318.3; Tue, 22 Jan 2013 05:43:03 +0000 Received: from S2100-06.ap.freescale.net (S2100-06.ap.freescale.net [10.192.242.65]) by az84smr01.freescale.net (8.14.3/8.14.0) with ESMTP id r0M5gRva004943; Mon, 21 Jan 2013 22:42:30 -0700 Date: Tue, 22 Jan 2013 14:11:18 +0800 From: Shawn Guo To: Arnd Bergmann Subject: Re: [PATCH 13/15] USB: ehci: make orion and mxc bus glues coexist Message-ID: <20130122061116.GD29677@S2100-06.ap.freescale.net> References: <201301212137.42611.arnd@arndb.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <201301212137.42611.arnd@arndb.de> User-Agent: Mutt/1.5.21 (2010-09-15) X-OriginatorOrg: sigmatel.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20130122_004321_827261_6D5597BA X-CRM114-Status: GOOD ( 20.15 ) X-Spam-Score: -1.2 (-) X-Spam-Report: SpamAssassin version 3.3.2 on merlin.infradead.org summary: Content analysis details: (-1.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- 3.0 KHOP_BIG_TO_CC Sent to 10+ recipients instaed of Bcc or a list -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at http://www.dnswl.org/, medium trust [207.46.163.27 listed in list.dnswl.org] -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] Cc: Andrew Lunn , Jason Cooper , Greg Kroah-Hartman , Manjunath Goudar , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Felipe Balbi , arm@kernel.org, Alan Stern , Gregory Clement , Sascha Hauer , linux-arm-kernel@lists.infradead.org X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-arm-kernel-bounces@lists.infradead.org Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org On Mon, Jan 21, 2013 at 09:37:42PM +0000, Arnd Bergmann wrote: > > Arnd, please take a look at > > > > http://marc.info/?l=linux-usb&m=135843716515529&w=2 > > > > I can't test it easily, not being set up for cross compilation. I'm > > waiting to hear from anybody whether it works before submitting it. > > (There's also a report of memory corruption involving a similar patch > > for ehci-omap; it hasn't been tracked down yet.) > > Your patch looks good to me, but it also seems to do some other > changes that are not required to fix the problem but could wait > for 3.9 instead. You definitely have my Ack if you are willing > to take it for 3.8 though. > > Shawn or Sascha should be able to test it. > Alan, Thanks for the patch. I just gave it try. The USB Host port still works for me with a couple of fixes on your changes integrated (one for compiling and the other for probing). So you have my ACK with the changes below rolled into your patch. Acked-by: Shawn Guo ---8<---- Tested-by: Shawn Guo diff --git a/drivers/usb/host/ehci-mxc.c b/drivers/usb/host/ehci-mxc.c index 177b354..a685945 100644 --- a/drivers/usb/host/ehci-mxc.c +++ b/drivers/usb/host/ehci-mxc.c @@ -37,7 +37,7 @@ #define DRIVER_DESC "Freescale On-Chip EHCI Host driver" -static const char hcd_name[] = "ehci-mxc"; +static const char hcd_name[] = "mxc-ehci"; #define ULPI_VIEWPORT_OFFSET 0x170 @@ -48,7 +48,7 @@ struct ehci_mxc_priv { static struct hc_driver __read_mostly ehci_mxc_hc_driver; static const struct ehci_driver_overrides ehci_mxc_overrides __initdata = { - .extra_priv_size = sizeof(struct ehci_mxc_priv); + .extra_priv_size = sizeof(struct ehci_mxc_priv), }; static int ehci_mxc_drv_probe(struct platform_device *pdev)