From patchwork Tue Jan 29 18:43:41 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pavel Machek X-Patchwork-Id: 2063571 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork1.kernel.org Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) by patchwork1.kernel.org (Postfix) with ESMTP id 4EC123FDD1 for ; Tue, 29 Jan 2013 18:47:13 +0000 (UTC) Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.76 #1 (Red Hat Linux)) id 1U0GA6-0002tU-HX; Tue, 29 Jan 2013 18:44:02 +0000 Received: from atrey.karlin.mff.cuni.cz ([195.113.26.193]) by merlin.infradead.org with esmtp (Exim 4.76 #1 (Red Hat Linux)) id 1U0G9p-0002mq-1S for linux-arm-kernel@lists.infradead.org; Tue, 29 Jan 2013 18:43:47 +0000 Received: by atrey.karlin.mff.cuni.cz (Postfix, from userid 512) id 3477E80ECE; Tue, 29 Jan 2013 19:43:42 +0100 (CET) Date: Tue, 29 Jan 2013 19:43:41 +0100 From: Pavel Machek To: dinguyen@altera.com Subject: Re: [PATCHv1 for soc 5/5] arm: socfpga: Add SMP support for actual socfpga harware Message-ID: <20130129184340.GA1962@amd.pavel.ucw.cz> References: <1359075633-13502-1-git-send-email-dinguyen@altera.com> <1359075633-13502-6-git-send-email-dinguyen@altera.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1359075633-13502-6-git-send-email-dinguyen@altera.com> User-Agent: Mutt/1.5.20 (2009-06-14) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20130129_134345_224554_385DFC4B X-CRM114-Status: GOOD ( 10.60 ) X-Spam-Score: -1.9 (-) X-Spam-Report: SpamAssassin version 3.3.2 on merlin.infradead.org summary: Content analysis details: (-1.9 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/, no trust [195.113.26.193 listed in list.dnswl.org] -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] Cc: wd@denx.deOH, linux@arm.linux.org.uk, Arnd Bergmann , kernel@pengutronix.de, Olof Johansson , linux-arm-kernel@lists.infradead.org X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-arm-kernel-bounces@lists.infradead.org Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org Hi! > index 9941caa..5b76dd4 100644 > --- a/arch/arm/mach-socfpga/core.h > +++ b/arch/arm/mach-socfpga/core.h > @@ -20,7 +20,7 @@ > #ifndef __MACH_CORE_H > #define __MACH_CORE_H > > -extern void secondary_startup(void); > +extern void v7_secondary_startup(void); > extern void __iomem *socfpga_scu_base_addr; > One more thing. v7_secondary_startup() may be too generic name for a symbol. mach-imx already uses that. Plus, mach-imx also has the useless #ifdef. --- Remove useless #ifdef; headsmp.S is only compiled in CONFIG_SMP configuration. Signed-off-by: Pavel Machek Thanks, Pavel diff --git a/arch/arm/mach-imx/headsmp.S b/arch/arm/mach-imx/headsmp.S index 7e49deb..4c9ec06 100644 --- a/arch/arm/mach-imx/headsmp.S +++ b/arch/arm/mach-imx/headsmp.S @@ -64,12 +64,10 @@ ENTRY(v7_invalidate_l1) mov pc, lr ENDPROC(v7_invalidate_l1) -#ifdef CONFIG_SMP ENTRY(v7_secondary_startup) bl v7_invalidate_l1 b secondary_startup ENDPROC(v7_secondary_startup) -#endif #ifdef CONFIG_PM /*