From patchwork Fri Feb 1 10:58:49 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mark Rutland X-Patchwork-Id: 2079181 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork1.kernel.org Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) by patchwork1.kernel.org (Postfix) with ESMTP id B857C40106 for ; Fri, 1 Feb 2013 11:02:38 +0000 (UTC) Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.76 #1 (Red Hat Linux)) id 1U1EKj-000131-IN; Fri, 01 Feb 2013 10:59:01 +0000 Received: from service87.mimecast.com ([91.220.42.44]) by merlin.infradead.org with esmtp (Exim 4.76 #1 (Red Hat Linux)) id 1U1EKf-00012b-6u for linux-arm-kernel@lists.infradead.org; Fri, 01 Feb 2013 10:58:58 +0000 Received: from cam-owa1.Emea.Arm.com (fw-tnat.cambridge.arm.com [217.140.96.21]) by service87.mimecast.com; Fri, 01 Feb 2013 10:58:52 +0000 Received: from e106331-lin.cambridge.arm.com ([10.1.255.212]) by cam-owa1.Emea.Arm.com with Microsoft SMTPSVC(6.0.3790.0); Fri, 1 Feb 2013 10:58:49 +0000 Date: Fri, 1 Feb 2013 10:58:49 +0000 From: Mark Rutland To: Simon Horman Subject: Re: [PATCH 2/4] ARM: mach-shmobile: r8a7779: Allow initialisation of GIC by DT Message-ID: <20130201105849.GB21191@e106331-lin.cambridge.arm.com> References: <1359597051-32700-1-git-send-email-horms+renesas@verge.net.au> <1359597051-32700-3-git-send-email-horms+renesas@verge.net.au> <20130131123213.GB7235@e106331-lin.cambridge.arm.com> <20130201001119.GO10312@verge.net.au> <20130201003410.GA30007@verge.net.au> MIME-Version: 1.0 In-Reply-To: <20130201003410.GA30007@verge.net.au> User-Agent: Mutt/1.5.20 (2009-06-14) X-OriginalArrivalTime: 01 Feb 2013 10:58:49.0927 (UTC) FILETIME=[1DA66D70:01CE006B] X-MC-Unique: 113020110585205601 Content-Disposition: inline X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20130201_055857_434081_8683BC92 X-CRM114-Status: GOOD ( 31.25 ) X-Spam-Score: -2.6 (--) X-Spam-Report: SpamAssassin version 3.3.2 on merlin.infradead.org summary: Content analysis details: (-2.6 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/, low trust [91.220.42.44 listed in list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] Cc: "linux-sh@vger.kernel.org" , Magnus Damm , Rob Herring , Grant Likely , Simon Horman , "linux-arm-kernel@lists.infradead.org" X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-arm-kernel-bounces@lists.infradead.org Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org On Fri, Feb 01, 2013 at 12:34:10AM +0000, Simon Horman wrote: > On Fri, Feb 01, 2013 at 09:11:19AM +0900, Simon Horman wrote: > > On Thu, Jan 31, 2013 at 12:32:13PM +0000, Mark Rutland wrote: > > > Hi Simon, > > > > > > On Thu, Jan 31, 2013 at 01:50:49AM +0000, Simon Horman wrote: > > > > This allows the GIC interrupt controller of the r8a7779 SoC to be > > > > initialised using a flattened device tree blob. > > > > > > > > Signed-off-by: Simon Horman > > > > --- > > > > arch/arm/boot/dts/r8a7779.dtsi | 40 ++++++++++++++++++++++++++ > > > > arch/arm/mach-shmobile/include/mach/common.h | 1 + > > > > arch/arm/mach-shmobile/intc-r8a7779.c | 27 +++++++++++++---- > > > > 3 files changed, 62 insertions(+), 6 deletions(-) > > > > create mode 100644 arch/arm/boot/dts/r8a7779.dtsi > > > > > > > > diff --git a/arch/arm/boot/dts/r8a7779.dtsi b/arch/arm/boot/dts/r8a7779.dtsi > > > > new file mode 100644 > > > > index 0000000..eadc12e > > > > --- /dev/null > > > > +++ b/arch/arm/boot/dts/r8a7779.dtsi > > > > @@ -0,0 +1,40 @@ > > > > +/* > > > > + * Device Tree Source for Renesas r8a7740 > > > > + * > > > > + * Copyright (C) 2013 Renesas Solutions Corp. > > > > + * Copyright (C) 2013 Simon Horman > > > > + * > > > > + * This file is licensed under the terms of the GNU General Public License > > > > + * version 2. This program is licensed "as is" without any warranty of any > > > > + * kind, whether express or implied. > > > > + */ > > > > + > > > > +/include/ "skeleton.dtsi" > > > > + > > > > +/ { > > > > + compatible = "renesas,r8a7779"; > > > > + > > > > + cpus { > > > > + cpu@0 { > > > > + compatible = "arm,cortex-a9"; > > > > + }; > > > > + cpu@1 { > > > > + compatible = "arm,cortex-a9"; > > > > + }; > > > > + cpu@2 { > > > > + compatible = "arm,cortex-a9"; > > > > + }; > > > > + cpu@3 { > > > > + compatible = "arm,cortex-a9"; > > > > + }; > > > > + }; > > > > > > Sorry to sound like a broken record, but it'd be good to see reg and > > > device_type set here. > > > > Sure, will do. > > > > > > + > > > > + gic: interrupt-controller@f0001000 { > > > > + compatible = "arm,cortex-a9-gic"; > > > > + #interrupt-cells = <3>; > > > > + #address-cells = <1>; > > > > > > Why is #address-cells needed here (and without #size-cells)? I see it's in the > > > binding document example, but I can't figure out why. > > > > Its here because I copied the example. > > I will see about removing it from here. Rob, Grant, do either of you know if there's a reason for this that we've missed? The gic doesn't have any direct children, and this doesn't seem to be some decvicetree interrupt-controller magic. If this is superfluous, how about the patch below? I took a quick look at arch/arm/boot/dts/. Some gic nodes don't have #address-cells, some have it but not #size-cells, and some have both. These should probably be cleaned up too. [...] Thanks, Mark. ---->8---- From dc734edb8040513785429c11e40a420870dc55a4 Mon Sep 17 00:00:00 2001 From: Mark Rutland Date: Fri, 1 Feb 2013 10:18:05 +0000 Subject: [PATCH] Docs: gic: remove #address-cells from example The gic has no child nodes, and so doesn't need #address-cells. Having the property defined in the example only serves as a source of confusion. Signed-off-by: Mark Rutland --- Documentation/devicetree/bindings/arm/gic.txt | 1 - 1 file changed, 1 deletion(-) diff --git a/Documentation/devicetree/bindings/arm/gic.txt b/Documentation/devicetree/bindings/arm/gic.txt index 62eb8df..45b99ab 100644 --- a/Documentation/devicetree/bindings/arm/gic.txt +++ b/Documentation/devicetree/bindings/arm/gic.txt @@ -54,7 +54,6 @@ Example: intc: interrupt-controller@fff11000 { compatible = "arm,cortex-a9-gic"; #interrupt-cells = <3>; - #address-cells = <1>; interrupt-controller; reg = <0xfff11000 0x1000>, <0xfff10100 0x100>;